fix missing react error with fragments in `react-native` by iisaduan · Pull Request #60615 · microsoft/TypeScript

Isabel Duan (iisaduan) · 2024-11-26T20:19:08Z

same problem and fix as #60122

Isabel Duan (iisaduan) · 2024-11-26T20:19:21Z

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) · 2024-11-26T20:19:26Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-11-26T20:41:59Z

Hey Isabel Duan (@iisaduan), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) · 2024-11-26T21:01:30Z

Isabel Duan (@iisaduan)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,329k (± 0.94%)}	_{194,901k (± 1.04%)}	_~	_193,030k	_196,861k	_{p=0.810 n=6}
_{Parse Time}	_{1.32s (± 0.62%)}	_{1.30s (± 1.06%)}	_~	_1.29s	_1.32s	_{p=0.183 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.81s (± 0.24%)}	_{9.81s (± 0.30%)}	_~	_9.77s	_9.85s	_{p=0.807 n=6}
_{Emit Time}	_{2.74s (± 0.54%)}	_{2.73s (± 0.28%)}	_~	_2.72s	_2.74s	_{p=0.216 n=6}
_{Total Time}	_{14.58s (± 0.19%)}	_{14.56s (± 0.21%)}	_~	_14.52s	_14.60s	_{p=0.105 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,226,014k (± 0.00%)}	_{1,226,029k (± 0.00%)}	_~	_1,225,988k	_1,226,088k	_{p=0.470 n=6}
_{Parse Time}	_{6.66s (± 0.42%)}	_{6.67s (± 0.71%)}	_~	_6.62s	_6.73s	_{p=0.936 n=6}
_{Bind Time}	_{1.88s (± 0.29%)}	_{1.88s (± 0.72%)}	_~	_1.86s	_1.90s	_{p=1.000 n=6}
_{Check Time}	_{32.01s (± 0.22%)}	_{31.98s (± 0.36%)}	_~	_31.85s	_32.15s	_{p=0.471 n=6}
_{Emit Time}	_{15.24s (± 0.43%)}	_{15.23s (± 0.57%)}	_~	_15.16s	_15.39s	_{p=0.573 n=6}
_{Total Time}	_{55.79s (± 0.18%)}	_{55.76s (± 0.22%)}	_~	_55.61s	_55.97s	_{p=0.688 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,500,013	_2,500,013	_~	_~	_~	_{p=1.000 n=6}
_Types	_909,416	_909,416	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,317,799k (± 0.00%)}	_{2,317,820k (± 0.00%)}	_~	_2,317,760k	_2,317,874k	_{p=0.298 n=6}
_{Parse Time}	_{9.29s (± 0.24%)}	_{9.28s (± 0.32%)}	_~	_9.25s	_9.33s	_{p=0.454 n=6}
_{Bind Time}	_{2.17s (± 0.35%)}	_{2.18s (± 1.22%)}	_~	_2.16s	_2.23s	_{p=0.406 n=6}
_{Check Time}	_{74.97s (± 0.46%)}	_{74.82s (± 0.46%)}	_~	_74.45s	_75.28s	_{p=0.470 n=6}
_{Emit Time}	_{0.29s (± 1.80%)}	_{0.29s (± 1.80%)}	_~	_0.28s	_0.29s	_{p=1.000 n=6}
_{Total Time}	_{86.71s (± 0.40%)}	_{86.58s (± 0.37%)}	_~	_86.23s	_87.02s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,545	_266,546	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,414,692k (± 6.14%)}	_{2,354,402k (± 0.04%)}	_~	_2,353,263k	_2,355,856k	_{p=0.936 n=6}
_{Parse Time}	_{5.27s (± 0.83%)}	_{5.20s (± 1.05%)}	_~	_5.12s	_5.26s	_{p=0.078 n=6}
_{Bind Time}	_{1.77s (± 0.92%)}	_{1.77s (± 0.56%)}	_~	_1.75s	_1.78s	_{p=0.870 n=6}
_{Check Time}	_{35.12s (± 0.97%)}	_{35.22s (± 0.20%)}	_~	_35.09s	_35.29s	_{p=0.471 n=6}
_{Emit Time}	_{2.97s (± 0.73%)}	_{2.92s (± 1.97%)}	_~	_2.86s	_3.00s	_{p=0.173 n=6}
_{Total Time}	_{45.13s (± 0.72%)}	_{45.12s (± 0.24%)}	_~	_44.95s	_45.25s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,251	_1,225,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,545	_266,546	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,028,968k (± 9.78%)}	_{2,908,353k (±12.85%)}	_~	_2,424,858k	_3,151,053k	_{p=0.471 n=6}
_{Parse Time}	_{6.96s (± 1.66%)}	_{6.96s (± 2.35%)}	_~	_6.71s	_7.17s	_{p=0.936 n=6}
_{Bind Time}	_{2.16s (± 1.94%)}	_{2.13s (± 1.21%)}	_~	_2.10s	_2.17s	_{p=0.261 n=6}
_{Check Time}	_{42.78s (± 0.48%)}	_{42.94s (± 0.61%)}	_~	_42.46s	_43.23s	_{p=0.230 n=6}
_{Emit Time}	_{3.44s (± 2.22%)}	_{3.52s (± 2.88%)}	_~	_3.42s	_3.70s	_{p=0.199 n=6}
_{Total Time}	_{55.35s (± 0.44%)}	_{55.55s (± 0.77%)}	_~	_54.74s	_55.93s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,223	_262,223	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,606	_106,607	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{439,813k (± 0.01%)}	_{439,786k (± 0.01%)}	_~	_439,740k	_439,838k	_{p=0.298 n=6}
_{Parse Time}	_{3.54s (± 1.18%)}	_{3.53s (± 0.92%)}	_~	_3.49s	_3.59s	_{p=0.871 n=6}
_{Bind Time}	_{1.31s (± 1.15%)}	_{1.32s (± 0.89%)}	_~	_1.31s	_1.34s	_{p=0.357 n=6}
_{Check Time}	_{18.97s (± 0.53%)}	_{18.91s (± 0.42%)}	_~	_18.79s	_19.01s	_{p=0.521 n=6}
_{Emit Time}	_{1.53s (± 0.68%)}	_{1.52s (± 0.83%)}	_~	_1.50s	_1.53s	_{p=0.391 n=6}
_{Total Time}	_{25.34s (± 0.41%)}	_{25.29s (± 0.36%)}	_~	_25.13s	_25.38s	_{p=0.748 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,674k (± 0.05%)}	_{371,681k (± 0.04%)}	_~	_371,574k	_371,984k	_{p=0.936 n=6}
_{Parse Time}	_{2.91s (± 1.27%)}	_{2.90s (± 0.81%)}	_~	_2.87s	_2.93s	_{p=0.685 n=6}
_{Bind Time}	_{1.61s (± 1.21%)}	_{1.60s (± 1.18%)}	_~	_1.58s	_1.63s	_{p=0.507 n=6}
_{Check Time}	_{16.52s (± 0.50%)}	_{16.50s (± 0.22%)}	_~	_16.46s	_16.55s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.03s (± 0.47%)}	_{21.00s (± 0.23%)}	_~	_20.94s	_21.05s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,179,730	_3,179,730	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,093,537	_1,093,537	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,254,683k (± 0.01%)}	_{3,254,641k (± 0.02%)}	_~	_3,254,267k	_3,255,487k	_{p=0.575 n=6}
_{Parse Time}	_{14.07s (± 0.36%)}	_{14.08s (± 0.35%)}	_~	_14.03s	_14.16s	_{p=0.572 n=6}
_{Bind Time}	_{4.50s (± 0.23%)}	_{4.56s (± 1.97%)}	_{+0.06s (+ 1.30%)}	_4.50s	_4.74s	_{p=0.049 n=6}
_{Check Time}	_{86.72s (± 1.25%)}	_{87.33s (± 2.02%)}	_~	_85.83s	_89.63s	_{p=0.810 n=6}
_{Emit Time}	_{28.21s (± 2.55%)}	_{28.27s (± 2.23%)}	_~	_27.34s	_28.79s	_{p=1.000 n=6}
_{Total Time}	_{133.51s (± 0.82%)}	_{134.24s (± 1.32%)}	_~	_131.96s	_136.81s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,684	_288,684	_~	_~	_~	_{p=1.000 n=6}
_Types	_117,136	_117,136	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,859k (± 0.02%)}	_{440,917k (± 0.02%)}	_~	_440,800k	_441,064k	_{p=0.378 n=6}
_{Parse Time}	_{4.11s (± 0.77%)}	_{4.05s (± 1.26%)}	_{-0.06s (- 1.42%)}	_3.98s	_4.11s	_{p=0.036 n=6}
_{Bind Time}	_{1.76s (± 2.06%)}	_{1.73s (± 1.52%)}	_~	_1.71s	_1.77s	_{p=0.334 n=6}
_{Check Time}	_{18.84s (± 0.36%)}	_{18.90s (± 0.21%)}	_~	_18.85s	_18.96s	_{p=0.171 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.71s (± 0.36%)}	_{24.68s (± 0.31%)}	_~	_24.54s	_24.76s	_{p=0.295 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₈	₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_551,583	_551,583	_~	_~	_~	_{p=1.000 n=6}
_Types	_184,808	_184,808	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{491,914k (± 0.00%)}	_{491,885k (± 0.02%)}	_~	_491,680k	_491,965k	_{p=0.810 n=6}
_{Parse Time}	_{3.41s (± 0.58%)}	_{3.42s (± 0.35%)}	_~	_3.41s	_3.44s	_{p=0.410 n=6}
_{Bind Time}	_{1.17s (± 1.03%)}	_{1.17s (± 1.16%)}	_~	_1.16s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{19.61s (± 0.58%)}	_{19.67s (± 1.32%)}	_~	_19.42s	_20.16s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.20s (± 0.48%)}	_{24.27s (± 1.02%)}	_~	_24.05s	_24.74s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) · 2024-11-26T21:08:37Z

Isabel Duan (@iisaduan) Here are the results of running the user tests with tsc comparing main and refs/pull/60615/merge:

Everything looks good!

Jake Bailey (jakebailey) · 2024-11-26T21:47:23Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.7

TypeScript Bot (typescript-bot) · 2024-11-26T21:47:28Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.7`	✅ Started	✅ Results

TypeScript Bot (typescript-bot) · 2024-11-26T21:49:06Z

Hey, Jake Bailey (@jakebailey)! I've created #60618 for you.

TypeScript Bot (typescript-bot) · 2024-11-26T22:16:27Z

Isabel Duan (@iisaduan) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60615/merge:

Everything looks good!

Daniel Rosenwasser (DanielRosenwasser) · 2024-11-26T22:38:25Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.7

TypeScript Bot (typescript-bot) · 2024-11-26T22:38:29Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.7`	✅ Started	✅ Results

Daniel Rosenwasser (DanielRosenwasser) · 2024-11-26T22:38:30Z

oops

Daniel Rosenwasser (DanielRosenwasser) · 2024-11-26T22:38:42Z

stop it robot

…e-5.7 (#60618) Co-authored-by: Isabel Duan <isabelduan@microsoft.com>

TypeScript Bot (typescript-bot) · 2024-11-26T22:40:08Z

Hey, Daniel Rosenwasser (@DanielRosenwasser)! I've created #60620 for you.

Jake Bailey (jakebailey) · 2024-11-27T01:17:46Z

the bot should not have been able to make two PRs, but I guess it did because the first got merged?

Isabel Duan (iisaduan) added 2 commits November 26, 2024 12:02

test cases

793cc2b

fix

861c718

Isabel Duan (iisaduan) requested review from Andrew Branch (andrewbranch) and Wesley Wigham (weswigham) November 26, 2024 20:19

TypeScript Bot (typescript-bot) assigned Isabel Duan (iisaduan) Nov 26, 2024

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 26, 2024

Andrew Branch (andrewbranch) approved these changes Nov 26, 2024

View reviewed changes

Isabel Duan (iisaduan) merged commit 96410eb into microsoft:main Nov 26, 2024

TypeScript Bot (typescript-bot) pushed a commit that referenced this pull request Nov 26, 2024

fix missing react error with fragments in react-native (#60615)

842fa99

TypeScript Bot (typescript-bot) mentioned this pull request Nov 26, 2024

🤖 Pick PR #60615 (fix missing react error with fragme...) into release-5.7 #60618

Merged

Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Nov 26, 2024

🤖 Pick PR #60615 (fix missing react error with fragme...) into releas…

5d77da6

…e-5.7 (#60618) Co-authored-by: Isabel Duan <isabelduan@microsoft.com>

TypeScript Bot (typescript-bot) pushed a commit that referenced this pull request Nov 26, 2024

fix missing react error with fragments in react-native (#60615)

67874b9

TypeScript Bot (typescript-bot) mentioned this pull request Nov 26, 2024

🤖 Pick PR #60615 (fix missing react error with fragme...) into release-5.7 #60620

Closed

Isabel Duan (iisaduan) mentioned this pull request Dec 30, 2024

'React' refers to a UMD global, but the current file is a module. Consider adding an import instead. #60132

Closed

Nathan Shively-Sanders (sandersn) removed this from PR Backlog Apr 22, 2025

Mateusz Burzyński (Andarist) mentioned this pull request Jun 4, 2025

Port JSX fragment checking changes microsoft/typescript-go#1053

Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 15, 2025

Uh oh!

Conversation

Isabel Duan (iisaduan) commented Nov 26, 2024

Uh oh!

Isabel Duan (iisaduan) commented Nov 26, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 26, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 26, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 26, 2024

Uh oh!

Jake Bailey (jakebailey) commented Nov 26, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 26, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 26, 2024

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Nov 26, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Nov 26, 2024

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Nov 26, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 26, 2024

Uh oh!

Jake Bailey (jakebailey) commented Nov 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TypeScript Bot (typescript-bot) commented Nov 26, 2024 •

edited

Loading

TypeScript Bot (typescript-bot) commented Nov 26, 2024 •

edited

Loading

TypeScript Bot (typescript-bot) commented Nov 26, 2024 •

edited

Loading