Use a literal string for ArrayBuffer's toStringTag - #60227
Closed
Ron Buckton (rbuckton) wants to merge 1 commit into
Closed
Use a literal string for ArrayBuffer's toStringTag#60227Ron Buckton (rbuckton) wants to merge 1 commit into
Ron Buckton (rbuckton) wants to merge 1 commit into
Conversation
Ron Buckton (rbuckton)
requested review from
Gabriela Araujo Britto (gabritto) and
Jake Bailey (jakebailey)
October 14, 2024 22:07
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Contributor
Author
|
TypeScript Bot (@typescript-bot) run dt |
Contributor
Member
|
I think this is a dupe of #60150? |
Contributor
Author
|
Ah, missed that, thanks |
Contributor
|
Ron Buckton (@rbuckton) Here are the results of running the user tests with tsserver comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
Contributor
|
Hey Ron Buckton (@rbuckton), the results of running the DT tests are ready. There were interesting changes: Changes are too big to display here, please check the log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that all of the typed arrays are generic over
buffer, we should be able to use a more specific type forArrayBuffer's[Symbol.toStringTag]property.Fixes #60149