Disable #57896 (Respect package.json "type" and module-format-specific file extensions in more module modes) - #58831
Merged
Andrew Branch (andrewbranch) merged 6 commits intoJun 12, 2024
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Andrew Branch (andrewbranch)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
June 11, 2024 22:58
Sheetal Nandi (sheetalkamat)
approved these changes
Jun 12, 2024
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick to release-5.5 |
Contributor
Contributor
|
Hey, Andrew Branch (@andrewbranch)! I've created #58848 for you. This involved updating baselines; please check the diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables the behavior changes introduced in #57896, based on feedback in #58663 and #58523 and feedback from Benjamin Pasero (@bpasero) about effects on VS Code’s file watchers. The hope is to merge this for 5.5 stable, then merge #58825 (pending review), which will reintroduce the behavior in the original PR in a more limited way, at the beginning of the 5.6 period.