Use better context scope for class constructor implementation signatures - #58168
Merged
Wesley Wigham (weswigham) merged 2 commits intoApr 12, 2024
Merged
Conversation
Wesley Wigham (weswigham)
requested review from
Jake Bailey (jakebailey) and
Nathan Shively-Sanders (sandersn)
April 12, 2024 16:43
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Apr 12, 2024
Jake Bailey (jakebailey)
approved these changes
Apr 12, 2024
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
TypeScript Bot (@typescript-bot) test it
Contributor
Contributor
|
Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready. Everything looks the same! |
Contributor
|
Hm, the repro I provided in #58158 is fixed now, but I'm still seeing the issue in our codebase. I'll have to update the repro to more closely resemble our actual code. |
Contributor
|
Jake Bailey (@jakebailey) Here are the results of running the user tests comparing Everything looks good! |
Contributor
|
Jake Bailey (@jakebailey) Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
Wesley Wigham (@weswigham) here's another regressed case that doesn't yet pass type Assign<T, U> = Omit<T, keyof U> & U;
class Base<T> {
constructor(public t: T) {}
}
export class Foo<T > extends Base<T> {
update(): Foo<Assign<T, {x: number}>> {
const v: Assign<T, {x: number}> = Object.assign(this.t, {x: 1});
return new Foo(v);
}
} |
Member
Author
|
michaelm (@MichaelMitchell-at) handled~ TypeScript Bot (@typescript-bot) test it |
Contributor
Contributor
|
Nice, that did the trick, thank you |
Jake Bailey (jakebailey)
approved these changes
Apr 12, 2024
Contributor
|
Hey Wesley Wigham (@weswigham), the results of running the DT tests are ready. Everything looks the same! |
Contributor
|
Wesley Wigham (@weswigham) Here are the results of running the user tests comparing Everything looks good! |
Contributor
|
Wesley Wigham (@weswigham) Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
Wesley Wigham (@weswigham) Here are the results of running the top 400 repos comparing Everything looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since those type parameters are reachable anywhere in the body of the class, not just the constructor itself.
Honestly, we could always do the
getImplementationSignaturecall, it doesn't have to be conditional, but we like trying to cut down on the type parameter copying we do, where possible. And certainly, as long as you only ever use the signature externally to the scope within which its' type parameters are internally reachable, you don't need to copy it.Fixes #58074