Require exactly 'true' for truthy reference directive prop - #57782
Merged
Jake Bailey (jakebailey) merged 1 commit intoMar 15, 2024
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Member
Author
|
TypeScript Bot (@typescript-bot) test top200 |
Contributor
Contributor
|
Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready. |
Contributor
|
Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
Contributor
|
Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing Everything looks good! |
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #57681; noticed that we just say "if it's present it's true" rather than actually requiring the string true. Seems a little weird. No breaks locally, and didn't see much in https://github.com/search?q=%2Fno-default-lib%3D%22%2F+language%3Atypescript&type=code either.