Skip to content

DO NOT MERGE: Show preserved triple slash references in diagnostics for top200 analysis - #57656

Closed
Andrew Branch (andrewbranch) wants to merge 3 commits into
microsoft:mainfrom
andrewbranch:expirment/how-many-triple-slashes-2
Closed

DO NOT MERGE: Show preserved triple slash references in diagnostics for top200 analysis #57656
Andrew Branch (andrewbranch) wants to merge 3 commits into
microsoft:mainfrom
andrewbranch:expirment/how-many-triple-slashes-2

Conversation

@andrewbranch

Copy link
Copy Markdown
Member

Counterpart of #57569

@andrewbranch

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test top200

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top200 ✅ Started 👀 Results

@typescript-bot

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch) Here are the results of running the top-repos suite comparing main and refs/pull/57656/merge:

Something interesting changed - please have a look.

Details

FuelLabs/fuels-ts

12 of 49 projects failed to build with the old tsc and were ignored

packages/abi-typegen/tsconfig.dts.json

packages/abi-typegen/tsconfig.json

packages/fuels/tsconfig.dts.json

@jakebailey

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test top400
TypeScript Bot (@typescript-bot) user test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started 👀 Results

@typescript-bot

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/57656/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

@typescript-bot

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/57656/merge:

Something interesting changed - please have a look.

Details

FuelLabs/fuels-ts

12 of 49 projects failed to build with the old tsc and were ignored

packages/abi-typegen/tsconfig.dts.json

packages/abi-typegen/tsconfig.json

packages/fuels/tsconfig.dts.json

jupyterlab/jupyterlab

48 of 59 projects failed to build with the old tsc and were ignored

packages/services/examples/browser/tsconfig.json

packages/services/examples/typescript-browser-with-output/tsconfig.json

packages/ui-components/examples/simple-windowed-list/tsconfig.json

galata/extension/tsconfig.json

galata/tsconfig.json

@jakebailey

Copy link
Copy Markdown
Member

The fuels-ts one emits a directive into the published package which doesn't actually exist. https://unpkg.com/browse/@fuel-ts/abi-typegen@0.76.0/dist/index.d.ts

@jakebailey

Copy link
Copy Markdown
Member

The jupyterlab one doesn't seem intentional, in that the package only dev deps on jest and there's a comment that says it's there for another reason. (I think normally such a reference would be elided if it were actually used elsewhere?)

In any case, these results are very good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants