Use destructured names as fallback labels when expanding parameters - #57619
Closed
Mateusz Burzyński (Andarist) wants to merge 13 commits into
Closed
Use destructured names as fallback labels when expanding parameters#57619Mateusz Burzyński (Andarist) wants to merge 13 commits into
Mateusz Burzyński (Andarist) wants to merge 13 commits into
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
Mateusz Burzyński (Andarist)
force-pushed
the
fallback-expanded-labels
branch
from
March 3, 2024 10:04
d5daf4a to
6a10bd1
Compare
Nathan Shively-Sanders (sandersn)
requested review from
Isabel Duan (iisaduan) and
Jake Bailey (jakebailey)
March 20, 2024 20:44
|
|
||
| if (isTupleType(restType)) { | ||
| return [expandSignatureParametersWithTupleMembers(restType, restIndex, restName)]; | ||
| return [expandSignatureParametersWithTupleMembers(restType, restIndex, restName, getFallbackExpandedLabels(restType, restDeclaration))]; |
There was a problem hiding this comment.
Another thing I realized is that we're going to be calculating this fallback list every time we do this, even though it's not always used. But, I'm not sure how to make that lazy either.
Contributor
Author
There was a problem hiding this comment.
ye, this is somewhat unfortunate but I don't think it's a particularly costly operation to create this so I just don't mind having this eager here
Member
|
TypeScript Bot (@typescript-bot) test it |
Contributor
Contributor
|
Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready. Everything looks the same! |
Contributor
|
Jake Bailey (@jakebailey) Here are the results of running the user tests comparing Everything looks good! |
Contributor
|
Jake Bailey (@jakebailey) Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
Jake Bailey (@jakebailey) Here are the results of running the top 400 repos comparing Everything looks good! |
Member
|
Hm, hard to say if that vscode result is just noise or not. TypeScript Bot (@typescript-bot) perf test this faster |
Contributor
Contributor
|
Jake Bailey (@jakebailey) Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
|
Retesting with new benchmarks TypeScript Bot (@typescript-bot) perf test this faster |
Contributor
Contributor
|
Jake Bailey (@jakebailey) Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
|
TypeScript Bot (@typescript-bot) pack this |
Contributor
Contributor
|
Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
Member
|
for function foo(first: string, ...args: [first: number, second: number]) {
}are we okay with this behavior?
|
Jake Bailey (jakebailey)
requested changes
Apr 19, 2024
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
Also, on second thought, I think that this should actually be first, second, not first, named; after all, the type could be coming from far far away, but the names from the rest are actually what's relavent for the function call...
Member
I'd say no; now that we have two sources of truth, we should probably try and remember which names we've already used 🙁 |
Contributor
Author
It's not perfect but it's nothing new (TS playground) type T0 = [first: string];
type T1 = [first: number, ...T0];
// ^? type T1 = [first: number, first: string]I'd prefer to fix this separately. Unless you feel it's crucial for this to land and that if I'd do this work here this PR would move further swiftly~.
I pushed out a commit to PR the local "labels" in those scenarios. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #56289