Adopt code action ranges for refactorings - #57608
Conversation
…and move to new file
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Matt Bierner (@mjbvz), Kat Marchán (@zkat), and Joaquin Jares (@joj) for you. Feel free to loop in other consumers/maintainers if necessary. |
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up. |
| description, | ||
| name: `function_scope_${i}`, | ||
| kind: extractFunctionAction.kind, | ||
| range: { start: { line: getLineAndCharacterOfPosition(context.file, affectedTextRange.pos).line, offset: getLineAndCharacterOfPosition(context.file, affectedTextRange.pos).character }, end: { line: getLineAndCharacterOfPosition(context.file, affectedTextRange.end).line, offset: getLineAndCharacterOfPosition(context.file, affectedTextRange.end).character } }, |
There was a problem hiding this comment.
These lines look super long 😅
5 participants
This pr fixes #57264 by getting ranges of text that will be affected for extract type, extract symbol, move to file and move to new file refactorings.