No number constraint to mapped type with as clause

[Gabriela Araujo Britto (gabritto)]

Fixes #57007.

[Gabriela Araujo Britto (gabritto)]

TypeScript Bot (@typescript-bot) run DT
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) perf test this faster

[TypeScript Bot (typescript-bot)]

Heya Gabriela Araujo Britto (@gabritto), I've started to run the faster perf test suite on this PR at 4804914. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at 4804914. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at 4804914. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at 4804914. You can monitor the build here.

Update: The results are in!

[Gabriela Araujo Britto (gabritto)]

TypeScript Bot (@typescript-bot) user test this

[TypeScript Bot (typescript-bot)]

Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at 4804914. You can monitor the build here.

Update: The results are in!

[TypeScript Bot (typescript-bot)]

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/57093/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

• [MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
  • packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

[TypeScript Bot (typescript-bot)]

Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/57093/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

• [MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
  • packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

[TypeScript Bot (typescript-bot)]

Gabriela Araujo Britto (@gabritto)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

Metric	baseline	pr	Delta	Best	Worst	p-value
Angular - node (v18.15.0, x64)
Memory used	295,642k (± 0.01%)	295,625k (± 0.00%)	~	295,599k	295,639k	p=0.199 n=6
Parse Time	2.65s (± 0.31%)	2.66s (± 0.21%)	~	2.65s	2.66s	p=0.441 n=6
Bind Time	0.83s (± 0.62%)	0.83s (± 0.99%)	~	0.81s	0.83s	p=0.752 n=6
Check Time	8.15s (± 0.24%)	8.16s (± 0.17%)	~	8.14s	8.17s	p=0.804 n=6
Emit Time	7.08s (± 0.33%)	7.09s (± 0.35%)	~	7.07s	7.14s	p=0.513 n=6
Total Time	18.71s (± 0.11%)	18.73s (± 0.18%)	~	18.70s	18.79s	p=0.627 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used	193,473k (± 1.56%)	193,468k (± 1.54%)	~	191,513k	197,372k	p=0.936 n=6
Parse Time	1.37s (± 1.20%)	1.36s (± 1.39%)	~	1.33s	1.38s	p=0.804 n=6
Bind Time	0.72s (± 0.00%)	0.72s (± 0.00%)	~	0.72s	0.72s	p=1.000 n=6
Check Time	9.39s (± 0.47%)	9.37s (± 0.46%)	~	9.29s	9.42s	p=0.469 n=6
Emit Time	2.62s (± 0.66%)	2.61s (± 0.20%)	~	2.61s	2.62s	p=0.352 n=6
Total Time	14.10s (± 0.47%)	14.06s (± 0.46%)	~	13.95s	14.14s	p=0.298 n=6
Monaco - node (v18.15.0, x64)
Memory used	347,400k (± 0.01%)	347,376k (± 0.01%)	-24k (- 0.01%)	347,336k	347,390k	p=0.045 n=6
Parse Time	2.46s (± 0.49%)	2.46s (± 0.34%)	~	2.46s	2.48s	p=0.276 n=6
Bind Time	0.93s (± 0.56%)	0.93s (± 0.56%)	~	0.92s	0.93s	p=1.000 n=6
Check Time	6.88s (± 0.60%)	6.86s (± 0.32%)	~	6.83s	6.89s	p=0.744 n=6
Emit Time	4.03s (± 0.45%)	4.05s (± 0.40%)	~	4.04s	4.08s	p=0.145 n=6
Total Time	14.29s (± 0.34%)	14.30s (± 0.18%)	~	14.26s	14.33s	p=0.293 n=6
TFS - node (v18.15.0, x64)
Memory used	302,793k (± 0.01%)	302,785k (± 0.01%)	~	302,763k	302,801k	p=0.468 n=6
Parse Time	2.01s (± 0.41%)	2.02s (± 0.73%)	~	2.00s	2.04s	p=0.084 n=6
Bind Time	1.00s (± 0.83%)	1.00s (± 1.85%)	~	0.99s	1.04s	p=0.325 n=6
Check Time	6.31s (± 0.34%)	6.30s (± 0.27%)	~	6.27s	6.32s	p=0.140 n=6
Emit Time	3.58s (± 0.33%)	3.59s (± 0.58%)	~	3.55s	3.61s	p=0.460 n=6
Total Time	12.90s (± 0.12%)	12.91s (± 0.14%)	~	12.89s	12.94s	p=0.676 n=6
material-ui - node (v18.15.0, x64)
Memory used	511,167k (± 0.00%)	511,169k (± 0.00%)	~	511,131k	511,193k	p=0.689 n=6
Parse Time	2.63s (± 0.56%)	2.64s (± 0.37%)	~	2.63s	2.66s	p=0.081 n=6
Bind Time	1.00s (± 0.82%)	0.99s (± 1.64%)	~	0.97s	1.01s	p=0.869 n=6
Check Time	17.15s (± 0.33%)	17.16s (± 0.37%)	~	17.06s	17.22s	p=0.747 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	20.78s (± 0.31%)	20.80s (± 0.30%)	~	20.69s	20.86s	p=0.378 n=6
mui-docs - node (v18.15.0, x64)
Memory used	1,695,486k (± 0.00%)	1,695,477k (± 0.00%)	~	1,695,452k	1,695,495k	p=0.936 n=6
Parse Time	6.51s (± 0.08%)	6.52s (± 0.37%)	~	6.50s	6.56s	p=0.934 n=6
Bind Time	2.35s (± 0.35%)	2.35s (± 0.51%)	~	2.34s	2.37s	p=1.000 n=6
Check Time	55.38s (± 0.34%)	55.39s (± 0.35%)	~	55.08s	55.62s	p=0.872 n=6
Emit Time	0.16s (± 0.00%)	0.16s (± 0.00%)	~	0.16s	0.16s	p=1.000 n=6
Total Time	64.40s (± 0.30%)	64.42s (± 0.29%)	~	64.10s	64.64s	p=0.873 n=6
self-build-src - node (v18.15.0, x64)
Memory used	2,411,464k (± 0.03%)	2,411,805k (± 0.02%)	~	2,411,245k	2,412,438k	p=0.471 n=6
Parse Time	4.91s (± 1.22%)	4.92s (± 0.85%)	~	4.86s	4.97s	p=1.000 n=6
Bind Time	1.90s (± 0.80%)	1.89s (± 1.80%)	~	1.86s	1.95s	p=0.195 n=6
Check Time	33.14s (± 0.22%)	33.15s (± 0.18%)	~	33.04s	33.21s	p=0.378 n=6
Emit Time	2.77s (± 1.63%)	2.76s (± 1.29%)	~	2.71s	2.81s	p=0.873 n=6
Total Time	42.74s (± 0.26%)	42.74s (± 0.13%)	~	42.66s	42.81s	p=0.748 n=6
self-compiler - node (v18.15.0, x64)
Memory used	419,610k (± 0.00%)	419,613k (± 0.02%)	~	419,542k	419,765k	p=0.229 n=6
Parse Time	2.79s (± 2.67%)	2.73s (± 2.70%)	~	2.67s	2.82s	p=0.222 n=6
Bind Time	1.10s (± 5.59%)	1.17s (± 6.20%)	~	1.07s	1.22s	p=0.084 n=6
Check Time	15.05s (± 0.30%)	15.05s (± 0.24%)	~	14.99s	15.09s	p=1.000 n=6
Emit Time	1.16s (± 1.71%)	1.15s (± 0.45%)	~	1.14s	1.15s	p=0.325 n=6
Total Time	20.09s (± 0.28%)	20.08s (± 0.15%)	~	20.04s	20.12s	p=0.687 n=6
vscode - node (v18.15.0, x64)
Memory used	2,806,643k (± 0.00%)	2,806,646k (± 0.00%)	~	2,806,567k	2,806,678k	p=0.689 n=6
Parse Time	10.60s (± 0.26%)	10.60s (± 0.22%)	~	10.57s	10.63s	p=0.936 n=6
Bind Time	3.38s (± 0.22%)	3.38s (± 0.35%)	~	3.36s	3.39s	p=0.734 n=6
Check Time	59.21s (± 0.17%)	59.27s (± 0.38%)	~	59.06s	59.67s	p=1.000 n=6
Emit Time	16.05s (± 0.50%)	16.11s (± 0.52%)	~	16.01s	16.25s	p=0.297 n=6
Total Time	89.24s (± 0.16%)	89.36s (± 0.22%)	~	89.20s	89.71s	p=0.296 n=6
webpack - node (v18.15.0, x64)
Memory used	392,337k (± 0.02%)	392,352k (± 0.01%)	~	392,328k	392,405k	p=0.471 n=6
Parse Time	3.07s (± 0.52%)	3.05s (± 0.96%)	~	3.01s	3.08s	p=0.359 n=6
Bind Time	1.42s (± 0.53%)	1.41s (± 0.29%)	-0.01s (- 0.70%)	1.41s	1.42s	p=0.029 n=6
Check Time	13.94s (± 0.21%)	13.93s (± 0.22%)	~	13.90s	13.98s	p=0.871 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	18.43s (± 0.17%)	18.39s (± 0.24%)	~	18.34s	18.47s	p=0.087 n=6
xstate - node (v18.15.0, x64)
Memory used	513,383k (± 0.01%)	513,356k (± 0.01%)	~	513,297k	513,398k	p=0.471 n=6
Parse Time	3.29s (± 0.19%)	3.28s (± 0.30%)	~	3.27s	3.30s	p=0.090 n=6
Bind Time	1.54s (± 0.41%)	1.54s (± 0.41%)	~	1.53s	1.55s	p=1.000 n=6
Check Time	2.84s (± 0.77%)	2.83s (± 0.35%)	~	2.82s	2.84s	p=0.513 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=1.000 n=6
Total Time	7.75s (± 0.27%)	7.73s (± 0.13%)	~	7.72s	7.74s	p=0.145 n=6

System info unknown

Hosts

• node (v18.15.0, x64)

Scenarios

• Angular - node (v18.15.0, x64)
• Compiler-Unions - node (v18.15.0, x64)
• Monaco - node (v18.15.0, x64)
• TFS - node (v18.15.0, x64)
• material-ui - node (v18.15.0, x64)
• mui-docs - node (v18.15.0, x64)
• self-build-src - node (v18.15.0, x64)
• self-compiler - node (v18.15.0, x64)
• vscode - node (v18.15.0, x64)
• webpack - node (v18.15.0, x64)
• xstate - node (v18.15.0, x64)

Benchmark	Name	Iterations
Current	pr	6
Baseline	baseline	6

Developer Information:

Download Benchmarks

[TypeScript Bot (typescript-bot)]

Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[TypeScript Bot (typescript-bot)]

Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/57093/merge:

Something interesting changed - please have a look.

Details

chakra-ui/chakra-ui

4 of 28 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.build.json

• error TS5056: Cannot write file '/mnt/ts_downloads/chakra-ui/packages/components/dist/types/menu/menu.stories.d.ts' because it would be overwritten by multiple input files.
  • Project Scope