Less template literal and string literal reduction - #56165
Closed
Pranav Senthilnathan (PranavSenthilnathan) wants to merge 3 commits into
Closed
Less template literal and string literal reduction#56165Pranav Senthilnathan (PranavSenthilnathan) wants to merge 3 commits into
Pranav Senthilnathan (PranavSenthilnathan) wants to merge 3 commits into
Conversation
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Member
Author
|
TypeScript Bot (@typescript-bot) test this |
Member
|
TypeScript Bot (@typescript-bot) test this I don't think you're on the author list so that doesn't work, though maybe it's some other list that does it. |
Contributor
|
Heya Jake Bailey (@jakebailey), I've started to run the regular perf test suite on this PR at 8e76d16. You can monitor the build here. Update: The results are in! |
Contributor
|
Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at 8e76d16. You can monitor the build here. Update: The results are in! |
Member
|
What test case are you looking at for this? #52345? |
TypeScript Bot (typescript-bot)
added
For Milestone Bug
Member
Author
|
Updated comment. It's #56081 |
Contributor
|
Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
Contributor
|
Jake Bailey (@jakebailey) Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
StartupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…ranas/template-literal-reduction
Member
Author
|
So this is not the solution since this was an intentional feature introduced in #41276. But I think there should probably be some middle ground between reducing eagerly during union creation and lazily when subtype reduction is performed. Maybe just doing subtype reduction when checking variable declaration nodes? |
Member
|
The main problem is that if we don't always reduce, then two unions that are actually the same thing can be present at once, which means you can't fast check for equality and such (maybe some other invariants). |
Contributor
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking perf impact of the naive change.
Fixes #56081