Fix issue with trailing directory separator not present if symlink wasnt detected by program - #55865
Merged
Merged
Conversation
Sheetal Nandi (sheetalkamat)
marked this pull request as ready for review
September 25, 2023 20:55
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Sheetal Nandi (sheetalkamat)
requested review from
Andrew Branch (andrewbranch) and
Jake Bailey (jakebailey)
September 25, 2023 20:55
…sing wrong symlink casing
Andrew Branch (andrewbranch)
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing path replacements we expect realpaths to be ending with directory separator so before this change, the real path that was manipulated resulted in wrong directory.
Fixes #55135