Fixed a string completions regression when requested directly in argument position - #55552
Merged
Andrew Branch (andrewbranch) merged 1 commit intoAug 28, 2023
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
Andrew Branch (andrewbranch)
approved these changes
Aug 28, 2023
Andrew Branch (andrewbranch)
left a comment
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
Thank you!
Mateusz Burzyński (Andarist)
deleted the
fix/string-completion-regression
branch
August 28, 2023 22:06
Contributor
Author
|
Andrew Branch (@andrewbranch) technically, this was a regression from 5.1. It's not rly critical but perhaps it's worth cherry-picking to 5.2? |
Member
|
That’s fine with me. Daniel Rosenwasser (@DanielRosenwasser)? |
Marcus Ording (snovader)
pushed a commit
to EG-A-S/TypeScript
that referenced
this pull request
Sep 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #55545 (a regression from #53996 )
it turns out that reusing
wildcardTypefor this wasn't ideal 😉 cc Andrew Branch (@andrewbranch)