Skip to content

Interactive type inlay hints - #55141

Merged
Maria Solano (MariaSolOs) merged 4 commits into
microsoft:mainfrom
MariaSolOs:type-hints
Sep 20, 2023
Merged

Interactive type inlay hints#55141
Maria Solano (MariaSolOs) merged 4 commits into
microsoft:mainfrom
MariaSolOs:type-hints

Conversation

@MariaSolOs

@MariaSolOs Maria Solano (MariaSolOs) commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

Second iteration of #47693

@typescript-bot

TypeScript Bot (typescript-bot) commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 24, 2023
@MariaSolOs
Maria Solano (MariaSolOs) marked this pull request as draft July 24, 2023 21:12
@MariaSolOs
Maria Solano (MariaSolOs) force-pushed the type-hints branch 3 times, most recently from 91c2844 to dec7b99 Compare August 4, 2023 01:49
@MariaSolOs
Maria Solano (MariaSolOs) force-pushed the type-hints branch 2 times, most recently from fb19ede to 420610a Compare August 4, 2023 22:21
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Aug 5, 2023
View reviewed changes
Comment thread src/services/inlayHints.ts Outdated
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Aug 5, 2023
View reviewed changes
Comment thread src/services/inlayHints.ts Outdated
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Aug 5, 2023
View reviewed changes
Comment thread src/services/inlayHints.ts Outdated

const parts: InlayHintDisplayPart[] = [];
visitDisplayPart(typeNode);
function visitDisplayPart(node: Node) {

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Aug 5, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you're not visiting display parts, you're visiting nodes to aggregate display parts

@MariaSolOs Maria Solano (MariaSolOs) Aug 5, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I just didn't want to call it visitor to differentiate it from the one at the top of provideInlayHints. Suggestions of a better name?

@jakebailey Jake Bailey (jakebailey) Sep 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visitForDisplayParts?

DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Aug 5, 2023
View reviewed changes
Comment thread src/services/inlayHints.ts
parts.push({ text: ">" });
}
// TODO: Parameters.
parts.push({ text: " => " });

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Aug 5, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating objects on the fly, I'm pretty sure we have display part functions that construct these. They have the benefit that they can include a display part kind as well if I recall correctly.

On that note, I think spaces are typically their own display part.

@MariaSolOs Maria Solano (MariaSolOs) Aug 5, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but those are for SymbolDisplayParts, and I have InlayHintDisplayParts here.

@MariaSolOs
Maria Solano (MariaSolOs) force-pushed the type-hints branch 5 times, most recently from 6980ff3 to 82fb813 Compare August 10, 2023 02:48
@MariaSolOs Maria Solano (MariaSolOs) mentioned this pull request Aug 10, 2023
Merged
@MariaSolOs
Maria Solano (MariaSolOs) force-pushed the type-hints branch 3 times, most recently from 169dd7f to 3fdba53 Compare August 17, 2023 01:53
@MariaSolOs

Maria Solano (MariaSolOs) commented Aug 17, 2023

Copy link
Copy Markdown
Contributor Author

Jake Bailey (@jakebailey) should I rebase this PR to include the new formatting setup?

@MariaSolOs
Maria Solano (MariaSolOs) force-pushed the type-hints branch 3 times, most recently from 1442daa to 6ae5fc0 Compare August 17, 2023 21:46
@MariaSolOs Maria Solano (MariaSolOs) mentioned this pull request Aug 17, 2023
Merged
@MariaSolOs Maria Solano (MariaSolOs) mentioned this pull request Sep 1, 2023
Open
jakebailey
Jake Bailey (jakebailey) reviewed Sep 18, 2023
View reviewed changes
Comment thread src/services/inlayHints.ts
jakebailey
Jake Bailey (jakebailey) reviewed Sep 18, 2023
View reviewed changes
Comment thread src/services/inlayHints.ts
jakebailey
Jake Bailey (jakebailey) reviewed Sep 18, 2023
View reviewed changes
Comment thread src/services/inlayHints.ts Outdated
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Sep 19, 2023

Copy link
Copy Markdown
Member

Jake Bailey (@jakebailey) can you review the latest commit? Thanks!

@jakebailey

Jake Bailey (jakebailey) commented Sep 19, 2023

Copy link
Copy Markdown
Member

The changes look good, I was just waiting on #55141 (comment) as that was in my review comments from the last batch.

jakebailey
Jake Bailey (jakebailey) approved these changes Sep 20, 2023
View reviewed changes

@jakebailey Jake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course I don't really mind the name either way.

@MariaSolOs
Maria Solano (MariaSolOs) merged commit 0b82e1a into microsoft:main Sep 20, 2023
@MariaSolOs
Maria Solano (MariaSolOs) deleted the type-hints branch September 20, 2023 05:50
Marcus Ording (snovader) pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023
@MariaSolOs @snovader
Interactive type inlay hints (microsoft#55141)
7f455f5
@ha1fstack halfstack (ha1fstack) mentioned this pull request Nov 26, 2023
Open
@luabud Luciana Abud (luabud) mentioned this pull request Dec 4, 2023
Closed
@Gawd71730

Gawd71730 commented Jan 17, 2024

Copy link
Copy Markdown

Hints

@MariaSolOs Maria Solano (MariaSolOs) mentioned this pull request Apr 14, 2024
Open
@bgenia bgenia mentioned this pull request Oct 16, 2024
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser left review comments
@jakebailey Jake Bailey (jakebailey) jakebailey approved these changes
@zkat Kat Marchán (zkat) Awaiting requested review from zkat
@joj Joaquin Jares (joj) Awaiting requested review from joj
@andrewbranch Andrew Branch (andrewbranch) Awaiting requested review from andrewbranch
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh
@gabritto Gabriela Araujo Britto (gabritto) Awaiting requested review from gabritto
@sheetalkamat Sheetal Nandi (sheetalkamat) Awaiting requested review from sheetalkamat

Assignees

@MariaSolOs Maria Solano (MariaSolOs)

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MariaSolOs @typescript-bot @jakebailey @RyanCavanaugh @Gawd71730 @DanielRosenwasser @sandersn