Skip to content

Add depth limiter to isConstTypeVariable function - #54624

Merged
Anders Hejlsberg (ahejlsberg) merged 5 commits into
mainfrom
fix54610
Jun 16, 2023
Merged

Add depth limiter to isConstTypeVariable function#54624
Anders Hejlsberg (ahejlsberg) merged 5 commits into
mainfrom
fix54610

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Jun 12, 2023

Copy link
Copy Markdown
Member

Fixes #54610.

@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 12, 2023
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jun 12, 2023

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster
TypeScript Bot (@typescript-bot) test top100

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 5609292. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at 5609292. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at 5609292. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based top-repos suite on this PR at 5609292. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 5609292. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54624

Metric main 54624 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 365,542k (± 0.01%) 365,524k (± 0.01%) ~ 365,496k 365,575k p=0.470 n=6
Parse Time 3.58s (± 0.60%) 3.57s (± 0.42%) ~ 3.54s 3.58s p=0.515 n=6
Bind Time 1.18s (± 0.93%) 1.18s (± 0.71%) ~ 1.18s 1.20s p=0.503 n=6
Check Time 9.55s (± 0.30%) 9.60s (± 0.40%) +0.05s (+ 0.58%) 9.55s 9.66s p=0.030 n=6
Emit Time 7.92s (± 0.55%) 7.94s (± 0.84%) ~ 7.84s 8.02s p=0.574 n=6
Total Time 22.22s (± 0.35%) 22.30s (± 0.44%) ~ 22.13s 22.42s p=0.229 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,888k (± 0.01%) 192,953k (± 0.02%) +65k (+ 0.03%) 192,913k 192,990k p=0.005 n=6
Parse Time 1.60s (± 1.50%) 1.59s (± 0.86%) ~ 1.58s 1.61s p=0.625 n=6
Bind Time 0.83s (± 0.99%) 0.83s (± 0.49%) ~ 0.82s 0.83s p=0.584 n=6
Check Time 10.23s (± 0.64%) 10.23s (± 0.38%) ~ 10.19s 10.30s p=0.688 n=6
Emit Time 3.00s (± 0.94%) 3.03s (± 1.17%) ~ 2.99s 3.07s p=0.124 n=6
Total Time 15.65s (± 0.54%) 15.68s (± 0.48%) ~ 15.62s 15.80s p=0.747 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,895k (± 0.00%) 345,888k (± 0.01%) ~ 345,857k 345,912k p=1.000 n=6
Parse Time 2.72s (± 0.19%) 2.74s (± 0.56%) ~ 2.71s 2.75s p=0.058 n=6
Bind Time 1.08s (± 0.70%) 1.08s (± 0.50%) ~ 1.08s 1.09s p=0.137 n=6
Check Time 7.85s (± 0.60%) 7.86s (± 0.60%) ~ 7.81s 7.92s p=1.000 n=6
Emit Time 4.44s (± 0.56%) 4.46s (± 0.69%) ~ 4.42s 4.49s p=0.145 n=6
Total Time 16.09s (± 0.35%) 16.14s (± 0.50%) ~ 16.04s 16.23s p=0.332 n=6
TFS - node (v16.17.1, x64)
Memory used 299,972k (± 0.00%) 299,959k (± 0.00%) ~ 299,937k 299,976k p=0.172 n=6
Parse Time 2.17s (± 0.70%) 2.17s (± 0.74%) ~ 2.15s 2.19s p=0.568 n=6
Bind Time 1.24s (± 0.79%) 1.23s (± 0.84%) ~ 1.22s 1.25s p=0.203 n=6
Check Time 7.29s (± 0.55%) 7.27s (± 0.47%) ~ 7.22s 7.31s p=0.808 n=6
Emit Time 4.35s (± 0.74%) 4.35s (± 0.66%) ~ 4.31s 4.38s p=0.808 n=6
Total Time 15.05s (± 0.44%) 15.03s (± 0.20%) ~ 15.00s 15.07s p=1.000 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,023k (± 0.00%) 480,993k (± 0.01%) ~ 480,973k 481,046k p=0.065 n=6
Parse Time 3.27s (± 0.50%) 3.26s (± 0.64%) ~ 3.23s 3.29s p=0.329 n=6
Bind Time 0.94s (± 0.80%) 0.95s (± 1.04%) ~ 0.94s 0.96s p=0.102 n=6
Check Time 17.99s (± 0.53%) 17.92s (± 0.79%) ~ 17.75s 18.12s p=0.471 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.19s (± 0.49%) 22.12s (± 0.75%) ~ 21.94s 22.37s p=0.471 n=6
xstate - node (v16.17.1, x64)
Memory used 560,726k (± 0.02%) 560,662k (± 0.02%) ~ 560,516k 560,807k p=0.378 n=6
Parse Time 4.00s (± 0.59%) 3.99s (± 0.43%) ~ 3.97s 4.02s p=0.465 n=6
Bind Time 1.76s (± 0.59%) 1.76s (± 0.43%) ~ 1.75s 1.77s p=0.931 n=6
Check Time 3.06s (± 0.68%) 3.06s (± 0.45%) ~ 3.04s 3.07s p=0.460 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.91s (± 0.41%) 8.90s (± 0.23%) ~ 8.87s 8.93s p=0.280 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 54624 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/54624/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

@typescript-bot TypeScript Bot (typescript-bot) added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 12, 2023
@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top-repos suite comparing main and refs/pull/54624/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: three
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/three/examples/jsm/nodes/shadernode/ShaderNode.d.ts:130:40
ERROR: 130:40  expect  TypeScript@local compile error: 
Type 'GetConstructorsByScope<T, S>' does not satisfy the constraint 'readonly unknown[]'.
  Type 'Exclude<S extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined, undefined>' is not assignable to type 'readonly unknown[]'.
    Type 'S extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
      Type 'OverloadedConstructorsOf<T>["a"] | undefined' is not assignable to type 'readonly unknown[]'.
        Type 'undefined' is not assignable to type 'readonly unknown[]'.
          Type '((OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined) | ((OverloadedConstructorsOf<...>["b"][0] extends string ? OverloadedConstructorsOf<...>["b"][0] : never) extends Overloa...' is not assignable to type 'readonly unknown[]'.
            Type '(OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
              Type 'Exclude<(OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined, undefined> | Exclude<...> | Exclude<...> | Exclude<...>' is not assignable to type 'readonly unknown[]'.
                Type 'Exclude<(OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined, undefined>' is not assignable to type 'readonly unknown[]'.
                  Type '(OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                    Type 'OverloadedConstructorsOf<T>["a"] | undefined' is not assignable to type 'readonly unknown[]'.
                      Type 'undefined' is not assignable to type 'readonly unknown[]'.
                        Type 'OverloadedConstructorsOf<T>["a"][0] extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                          Type 'Exclude<OverloadedConstructorsOf<T>["a"][0] extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined, undefined>' is not assignable to type 'readonly unknown[]'.
                            Type 'OverloadedConstructorsOf<T>["a"][0] extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                              Type 'OverloadedConstructorsOf<T>["a"] | undefined' is not assignable to type 'readonly unknown[]'.
                                Type 'undefined' is not assignable to type 'readonly unknown[]'.
                                  Type 'string extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                                    Type 'Exclude<string extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined, undefined>' is not assignable to type 'readonly unknown[]'.
                                      Type 'string extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                                        Type 'OverloadedConstructorsOf<T>["a"] | undefined' is not assignable to type 'readonly unknown[]'.
                                          Type 'undefined' is not assignable to type 'readonly unknown[]'.
                                            Type 'Exclude<OverloadedConstructorsOf<T>["a"], undefined>' is not assignable to type 'readonly unknown[]'.
                                              Type 'OverloadedConstructorsOf<T>["a"]' is not assignable to type 'readonly unknown[]'.
                                                Type 'unknown[] | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? ...' is not assignable to type 'readonly unknown[]'.
                                                  Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Construtors<...' is not assignable to type 'readonly unknown[]'.
                                                    Type 'Exclude<(Construtors<unknown[], unknown[], unknown[], unknown[]> | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { ...; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Construt...' is not assignable to type 'readonly unknown[]'.
                                                      Type 'unknown[] | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? ...' is not assignable to type 'readonly unknown[]'.
                                                        Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Construtors<...' is not assignable to type 'readonly unknown[]'.
                                                          Type 'unknown[] | Exclude<(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => un...' is not assignable to type 'readonly unknown[]'.
                                                            Type 'Exclude<(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Cons...' is not assignable to type 'readonly unknown[]'.
                                                              Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Construtors<...' is not assignable to type 'readonly unknown[]'.
                                                                Type 'unknown[] | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                  Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                    Type 'Exclude<(Construtors<unknown[], unknown[], unknown[], undefined> | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<...> : Construtors<...>))["a"], undefined>' is not assignable to type 'readonly unknown[]'.
                                                                      Type 'unknown[] | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                        Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                          Type 'unknown[] | Exclude<(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<...> : Construtors<...>)["a"], undefined>' is not assignable to type 'readonly unknown[]'.
                                                                            Type 'Exclude<(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"], undefined>' is not assignable to type 'readonly unknown[]'.
                                                                              Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                                Type 'unknown[] | (T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<undefined, undefined, undefined, undefined>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                                  Type '(T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<undefined, undefined, undefined, undefined>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                                    Type 'unknown[] | undefined' is not assignable to type 'readonly unknown[]'.
                                                                                      Type 'undefined' is not assignable to type 'readonly unknown[]'.
ERROR: 136:47  expect  TypeScript@local compile error: 
Type 'GetConstructorsByScope<T, S>' does not satisfy the constraint 'readonly unknown[]'.
  Type 'Exclude<S extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined, undefined>' is not assignable to type 'readonly unknown[]'.
    Type 'S extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
      Type 'OverloadedConstructorsOf<T>["a"] | undefined' is not assignable to type 'readonly unknown[]'.
        Type 'undefined' is not assignable to type 'readonly unknown[]'.
          Type '((OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined) | ((OverloadedConstructorsOf<...>["b"][0] extends string ? OverloadedConstructorsOf<...>["b"][0] : never) extends Overloa...' is not assignable to type 'readonly unknown[]'.
            Type '(OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
              Type 'Exclude<(OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined, undefined> | Exclude<...> | Exclude<...> | Exclude<...>' is not assignable to type 'readonly unknown[]'.
                Type 'Exclude<(OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined, undefined>' is not assignable to type 'readonly unknown[]'.
                  Type '(OverloadedConstructorsOf<T>["a"][0] extends string ? OverloadedConstructorsOf<T>["a"][0] : never) extends OverloadedConstructorsOf<...>["a"][0] ? OverloadedConstructorsOf<...>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                    Type 'OverloadedConstructorsOf<T>["a"] | undefined' is not assignable to type 'readonly unknown[]'.
                      Type 'undefined' is not assignable to type 'readonly unknown[]'.
                        Type 'OverloadedConstructorsOf<T>["a"][0] extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                          Type 'Exclude<OverloadedConstructorsOf<T>["a"][0] extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined, undefined>' is not assignable to type 'readonly unknown[]'.
                            Type 'OverloadedConstructorsOf<T>["a"][0] extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                              Type 'OverloadedConstructorsOf<T>["a"] | undefined' is not assignable to type 'readonly unknown[]'.
                                Type 'undefined' is not assignable to type 'readonly unknown[]'.
                                  Type 'string extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                                    Type 'Exclude<string extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined, undefined>' is not assignable to type 'readonly unknown[]'.
                                      Type 'string extends OverloadedConstructorsOf<T>["a"][0] ? OverloadedConstructorsOf<T>["a"] : undefined' is not assignable to type 'readonly unknown[]'.
                                        Type 'OverloadedConstructorsOf<T>["a"] | undefined' is not assignable to type 'readonly unknown[]'.
                                          Type 'undefined' is not assignable to type 'readonly unknown[]'.
                                            Type 'Exclude<OverloadedConstructorsOf<T>["a"], undefined>' is not assignable to type 'readonly unknown[]'.
                                              Type 'OverloadedConstructorsOf<T>["a"]' is not assignable to type 'readonly unknown[]'.
                                                Type 'unknown[] | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? ...' is not assignable to type 'readonly unknown[]'.
                                                  Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Construtors<...' is not assignable to type 'readonly unknown[]'.
                                                    Type 'Exclude<(Construtors<unknown[], unknown[], unknown[], unknown[]> | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { ...; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Construt...' is not assignable to type 'readonly unknown[]'.
                                                      Type 'unknown[] | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? ...' is not assignable to type 'readonly unknown[]'.
                                                        Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Construtors<...' is not assignable to type 'readonly unknown[]'.
                                                          Type 'unknown[] | Exclude<(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => un...' is not assignable to type 'readonly unknown[]'.
                                                            Type 'Exclude<(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Cons...' is not assignable to type 'readonly unknown[]'.
                                                              Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; new (...args: infer A3): unknown; } ? Construtors<A1, A2, A3, undefined> : T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<...> : T extends new (...args: infer A) => unknown ? Construtors<...' is not assignable to type 'readonly unknown[]'.
                                                                Type 'unknown[] | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                  Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                    Type 'Exclude<(Construtors<unknown[], unknown[], unknown[], undefined> | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<...> : Construtors<...>))["a"], undefined>' is not assignable to type 'readonly unknown[]'.
                                                                      Type 'unknown[] | (T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                        Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                          Type 'unknown[] | Exclude<(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<...> : Construtors<...>)["a"], undefined>' is not assignable to type 'readonly unknown[]'.
                                                                            Type 'Exclude<(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"], undefined>' is not assignable to type 'readonly unknown[]'.
                                                                              Type '(T extends { new (...args: infer A1): unknown; new (...args: infer A2): unknown; } ? Construtors<A1, A2, undefined, undefined> : T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<...>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                                Type 'unknown[] | (T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<undefined, undefined, undefined, undefined>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                                  Type '(T extends new (...args: infer A) => unknown ? Construtors<A, undefined, undefined, undefined> : Construtors<undefined, undefined, undefined, undefined>)["a"]' is not assignable to type 'readonly unknown[]'.
                                                                                    Type 'unknown[] | undefined' is not assignable to type 'readonly unknown[]'.
                                                                                      Type 'undefined' is not assignable to type 'readonly unknown[]'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

@ahejlsberg Anders Hejlsberg (ahejlsberg) changed the title Mark base constraints as circular upon reaching depth limit Add depth limiter to isConstTypeVariable function Jun 13, 2023
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jun 13, 2023

Copy link
Copy Markdown
Member Author

Latest commit removes the first fix and instead adds a depth limiter to isConstTypeVariable. After more careful analysis I realized that was the source of the infinite recursion.

@ahejlsberg

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@ahejlsberg

This comment was marked as outdated.

Sign in to view
@ahejlsberg

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@jakebailey

Jake Bailey (jakebailey) commented Jun 15, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster
TypeScript Bot (@typescript-bot) test top100

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at 3dda751. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at 3dda751. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at 3dda751. You can monitor the build here.

Update: The results are in!

Update: The results are in!

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the abridged perf test suite on this PR at 3dda751. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at 3dda751. You can monitor the build here.

Update: The results are in!

@jakebailey

Jake Bailey (jakebailey) commented Jun 15, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at 3dda751. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/54624/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-54624/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..54624

Metric main 54624 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 365,530k (± 0.01%) 365,540k (± 0.02%) ~ 365,452k 365,659k p=1.000 n=6
Parse Time 3.56s (± 0.49%) 3.56s (± 0.64%) ~ 3.53s 3.59s p=0.935 n=6
Bind Time 1.18s (± 0.44%) 1.18s (± 0.44%) ~ 1.18s 1.19s p=0.069 n=6
Check Time 9.62s (± 0.40%) 9.63s (± 0.31%) ~ 9.59s 9.67s p=0.871 n=6
Emit Time 7.95s (± 0.86%) 7.89s (± 0.41%) ~ 7.85s 7.95s p=0.106 n=6
Total Time 22.30s (± 0.47%) 22.26s (± 0.24%) ~ 22.17s 22.31s p=0.688 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,572k (± 0.03%) 192,587k (± 0.04%) ~ 192,499k 192,666k p=0.810 n=6
Parse Time 1.59s (± 0.76%) 1.60s (± 0.73%) ~ 1.59s 1.62s p=0.438 n=6
Bind Time 0.83s (± 1.01%) 0.83s (± 1.01%) ~ 0.82s 0.84s p=0.796 n=6
Check Time 10.15s (± 0.93%) 10.19s (± 0.76%) ~ 10.05s 10.25s p=0.422 n=6
Emit Time 3.00s (± 1.02%) 3.00s (± 0.25%) ~ 2.99s 3.01s p=1.000 n=6
Total Time 15.58s (± 0.62%) 15.62s (± 0.47%) ~ 15.48s 15.68s p=0.230 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,877k (± 0.00%) 345,871k (± 0.01%) ~ 345,849k 345,913k p=0.229 n=6
Parse Time 2.73s (± 0.67%) 2.73s (± 0.52%) ~ 2.71s 2.75s p=0.870 n=6
Bind Time 1.09s (± 0.47%) 1.08s (± 0.48%) ~ 1.08s 1.09s p=0.311 n=6
Check Time 7.84s (± 0.49%) 7.87s (± 0.41%) ~ 7.83s 7.92s p=0.332 n=6
Emit Time 4.44s (± 0.54%) 4.44s (± 0.61%) ~ 4.42s 4.48s p=1.000 n=6
Total Time 16.10s (± 0.41%) 16.13s (± 0.29%) ~ 16.05s 16.18s p=0.629 n=6
TFS - node (v16.17.1, x64)
Memory used 299,992k (± 0.01%) 299,994k (± 0.01%) ~ 299,964k 300,035k p=1.000 n=6
Parse Time 2.16s (± 0.59%) 2.17s (± 0.71%) ~ 2.15s 2.19s p=0.247 n=6
Bind Time 1.24s (± 0.61%) 1.23s (± 0.66%) ~ 1.22s 1.24s p=0.383 n=6
Check Time 7.30s (± 0.27%) 7.28s (± 0.38%) ~ 7.24s 7.31s p=0.254 n=6
Emit Time 4.31s (± 0.46%) 4.33s (± 0.49%) ~ 4.30s 4.36s p=0.140 n=6
Total Time 15.01s (± 0.24%) 15.02s (± 0.25%) ~ 14.99s 15.07s p=0.413 n=6
material-ui - node (v16.17.1, x64)
Memory used 480,361k (± 0.01%) 480,333k (± 0.01%) ~ 480,275k 480,423k p=0.336 n=6
Parse Time 3.26s (± 0.39%) 3.26s (± 0.45%) ~ 3.24s 3.28s p=0.869 n=6
Bind Time 0.93s (± 0.59%) 0.94s (± 0.55%) ~ 0.93s 0.94s p=0.640 n=6
Check Time 17.90s (± 0.91%) 17.89s (± 0.33%) ~ 17.78s 17.94s p=0.295 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.10s (± 0.77%) 22.09s (± 0.28%) ~ 21.97s 22.14s p=0.229 n=6
xstate - node (v16.17.1, x64)
Memory used 560,644k (± 0.02%) 560,617k (± 0.02%) ~ 560,486k 560,796k p=0.748 n=6
Parse Time 3.99s (± 0.49%) 3.99s (± 0.51%) ~ 3.96s 4.02s p=0.570 n=6
Bind Time 1.76s (± 0.43%) 1.76s (± 0.59%) ~ 1.75s 1.78s p=0.273 n=6
Check Time 3.06s (± 0.64%) 3.06s (± 0.34%) ~ 3.04s 3.07s p=0.685 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.90s (± 0.37%) 8.90s (± 0.31%) ~ 8.86s 8.93s p=0.872 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 54624 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/54624/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

2 similar comments
@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

@jakebailey

Jake Bailey (jakebailey) commented Jun 16, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) run dt

But this time don't time out on npm

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at 3dda751. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jun 16, 2023

Copy link
Copy Markdown
Member Author

Ok, I think we finally have a clean test and perf run. This one is ready to merge.

sandersn
Nathan Shively-Sanders (sandersn) approved these changes Jun 16, 2023
View reviewed changes
Comment thread src/compiler/checker.ts
type.flags & TypeFlags.Union && some((type as UnionType).types, t => isConstTypeVariable(t, depth)) ||
type.flags & TypeFlags.IndexedAccess && isConstTypeVariable((type as IndexedAccessType).objectType, depth + 1) ||
type.flags & TypeFlags.Conditional && isConstTypeVariable(getConstraintOfConditionalType(type as ConditionalType), depth + 1) ||
type.flags & TypeFlags.Substitution && isConstTypeVariable((type as SubstitutionType).baseType, depth) ||

@sandersn Nathan Shively-Sanders (sandersn) Jun 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't substitution types increase the depth? I guess that indexed access and conditional types are the only paths that might create new types and then loop back into isConstTypeVariable?

@ahejlsberg Anders Hejlsberg (ahejlsberg) Jun 16, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly!

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) RyanCavanaugh approved these changes

Assignees

@ahejlsberg Anders Hejlsberg (ahejlsberg)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

isConstTypeVariable stack overflow

5 participants

@ahejlsberg @typescript-bot @jakebailey @sandersn @RyanCavanaugh