Instantiate generic ElementType declarations by weswigham · Pull Request #53943 · microsoft/TypeScript

Wesley Wigham (weswigham) · 2023-04-20T23:20:26Z

Jake Bailey (jakebailey) · 2023-04-20T23:31:11Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster
TypeScript Bot (@typescript-bot) pack this

TypeScript Bot (typescript-bot) · 2023-04-20T23:31:14Z

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at cfd2ae2. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-04-20T23:31:14Z

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at cfd2ae2. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-04-20T23:31:14Z

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at cfd2ae2. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2023-04-20T23:31:14Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at cfd2ae2. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-04-20T23:31:14Z

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at cfd2ae2. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-04-20T23:31:14Z

Heya Jake Bailey (@jakebailey), I've started to run the abridged perf test suite on this PR at cfd2ae2. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-04-20T23:33:16Z

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/153017/artifacts?artifactName=tgz&fileId=6DC910FB0B486002CE35F1EC7E6D6BE718BDA922A291A8C02DC82747EFA8132302&fileName=/typescript-5.1.0-insiders.20230420.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-53943-7".;

TypeScript Bot (typescript-bot) · 2023-04-20T23:42:28Z

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/53943/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-04-21T01:29:37Z

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/53943/merge:

Everything looks good!

TypeScript Bot (typescript-bot) · 2023-04-21T01:39:20Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.
There were interesting changes:

Main only errors:

Package: preact-i18n
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/preact-i18n/preact-i18n-tests.tsx:12:14
ERROR: 12:14  expect  TypeScript@local compile error: 
'IntlProvider' cannot be used as a JSX component.
  Its type '(props: IntlProviderProps) => Element' is not a valid JSX element type.
    Type '(props: IntlProviderProps) => Element' is not assignable to type 'FunctionComponent<P>'.
      Types of parameters 'props' and 'props' are incompatible.
        Type 'RenderableProps<P, any>' is not assignable to type 'IntlProviderProps'.
          Types of property 'children' are incompatible.
            Type 'ComponentChildren' is not assignable to type 'Element | Element[]'.
              Type 'undefined' is not assignable to type 'Element | Element[]'.
ERROR: 13:18  expect  TypeScript@local compile error: 
'p' cannot be used as a JSX component.
  Its type '"p"' is not a valid JSX element type.
ERROR: 14:22  expect  TypeScript@local compile error: 
'Text' cannot be used as a JSX component.
  Its type '(props: TextProps) => Element' is not a valid JSX element type.
ERROR: 15:22  expect  TypeScript@local compile error: 
'MarkupText' cannot be used as a JSX component.
  Its type '(props: TextProps) => Element' is not a valid JSX element type.
    Type '(props: TextProps) => Element' is not assignable to type 'FunctionComponent<P>'.
      Types of parameters 'props' and 'props' are incompatible.
        Type 'RenderableProps<P, any>' is not assignable to type 'TextProps'.
ERROR: 22:9   expect  TypeScript@local compile error: 
'Example' cannot be used as a JSX component.
  Its type 'typeof Example' is not a valid JSX element type.
    Type 'typeof Example' is not assignable to type 'ComponentClass<P, {}>'.
      Types of parameters 'props' and 'props' are incompatible.
        Type 'P' is not assignable to type 'P | undefined'.
ERROR: 25:31  expect  TypeScript@local compile error: 
'Text' cannot be used as a JSX component.
  Its type '(props: TextProps) => Element' is not a valid JSX element type.
    Type '(props: TextProps) => Element' is not assignable to type 'FunctionComponent<P>'.
      Types of parameters 'props' and 'props' are incompatible.
        Property 'id' is missing in type 'Readonly<Attributes & { children?: ComponentChildren; ref?: Ref<any> | undefined; }>' but required in type 'TextProps'.
ERROR: 26:13  expect  TypeScript@local compile error: 
'span' cannot be used as a JSX component.
  Its type '"span"' is not a valid JSX element type.
ERROR: 30:6   expect  TypeScript@local compile error: 
'IntlProvider' cannot be used as a JSX component.
  Its type '(props: IntlProviderProps) => Element' is not a valid JSX element type.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: preact-virtual-list
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/preact-virtual-list/preact-virtual-list-tests.tsx:10:14
ERROR: 10:14  expect  TypeScript@local compile error: 
'div' cannot be used as a JSX component.
  Its type '"div"' is not a valid JSX element type.
ERROR: 11:18  expect  TypeScript@local compile error: 
'VirtualList' cannot be used as a JSX component.
  Its type 'typeof VirtualList' is not a valid JSX element type.
    Type 'typeof VirtualList' is not assignable to type 'ComponentClass<P, {}>'.
      Types of parameters 'props' and 'props' are incompatible.
        Type 'P' is not assignable to type 'Props'.
ERROR: 13:47  expect  TypeScript@local compile error: 
'div' cannot be used as a JSX component.
  Its type '"div"' is not a valid JSX element type.
ERROR: 24:10  expect  TypeScript@local compile error: 
'div' cannot be used as a JSX component.
  Its type '"div"' is not a valid JSX element type.
ERROR: 25:14  expect  TypeScript@local compile error: 
'VirtualList' cannot be used as a JSX component.
  Its type 'typeof VirtualList' is not a valid JSX element type.
ERROR: 27:43  expect  TypeScript@local compile error: 
'div' cannot be used as a JSX component.
  Its type '"div"' is not a valid JSX element type.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: preact-custom-element
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/preact-custom-element/preact-custom-element-tests.tsx:5:13
ERROR: 5:13   expect  TypeScript@local compile error: 
'div' cannot be used as a JSX component.
  Its type '"div"' is not a valid JSX element type.
ERROR: 14:17  expect  TypeScript@local compile error: 
'div' cannot be used as a JSX component.
  Its type '"div"' is not a valid JSX element type.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

TypeScript Bot (typescript-bot) · 2023-04-21T02:41:49Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53943

_Metric	_main	₅₃₉₄₃	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,206k (± 0.01%)}	_{365,173k (± 0.00%)}	_~	_365,149k	_365,195k	_{p=0.423 n=6}
_{Parse Time}	_{3.56s (± 0.67%)}	_{3.53s (± 0.34%)}	_~	_3.52s	_3.55s	_{p=0.050 n=6}
_{Bind Time}	_{1.18s (± 0.54%)}	_{1.18s (± 0.64%)}	_~	_1.17s	_1.19s	_{p=0.718 n=6}
_{Check Time}	_{9.56s (± 0.49%)}	_{9.51s (± 0.69%)}	_~	_9.43s	_9.61s	_{p=0.173 n=6}
_{Emit Time}	_{7.94s (± 0.70%)}	_{7.90s (± 0.50%)}	_~	_7.84s	_7.94s	_{p=0.199 n=6}
_{Total Time}	_{22.24s (± 0.49%)}	_{22.13s (± 0.44%)}	_~	_22.00s	_22.25s	_{p=0.128 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,618k (± 0.03%)}	_{192,647k (± 0.04%)}	_~	_192,526k	_192,714k	_{p=0.470 n=6}
_{Parse Time}	_{1.60s (± 0.25%)}	_{1.60s (± 1.47%)}	_~	_1.55s	_1.61s	_{p=0.930 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.83s (± 0.49%)}	_~	_0.82s	_0.83s	_{p=0.282 n=6}
_{Check Time}	_{10.26s (± 0.52%)}	_{10.22s (± 0.39%)}	_~	_10.17s	_10.27s	_{p=0.259 n=6}
_{Emit Time}	_{2.98s (± 0.69%)}	_{2.99s (± 0.96%)}	_~	_2.95s	_3.03s	_{p=0.870 n=6}
_{Total Time}	_{15.67s (± 0.44%)}	_{15.63s (± 0.50%)}	_~	_15.54s	_15.72s	_{p=0.688 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,788k (± 0.01%)}	_{345,773k (± 0.00%)}	_~	_345,763k	_345,785k	_{p=0.297 n=6}
_{Parse Time}	_{2.72s (± 0.31%)}	_{2.72s (± 0.30%)}	_~	_2.71s	_2.73s	_{p=0.125 n=6}
_{Bind Time}	_{1.09s (± 0.97%)}	_{1.09s (± 0.47%)}	_~	_1.08s	_1.09s	_{p=0.794 n=6}
_{Check Time}	_{7.85s (± 0.51%)}	_{7.84s (± 0.78%)}	_~	_7.75s	_7.91s	_{p=0.936 n=6}
_{Emit Time}	_{4.45s (± 0.97%)}	_{4.43s (± 0.80%)}	_~	_4.38s	_4.48s	_{p=0.747 n=6}
_{Total Time}	_{16.09s (± 0.50%)}	_{16.08s (± 0.52%)}	_~	_15.95s	_16.18s	_{p=0.810 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,073k (± 0.01%)}	_{300,077k (± 0.01%)}	_~	_300,036k	_300,118k	_{p=0.873 n=6}
_{Parse Time}	_{2.15s (± 1.00%)}	_{2.15s (± 0.46%)}	_~	_2.14s	_2.16s	_{p=0.805 n=6}
_{Bind Time}	_{1.23s (± 0.84%)}	_{1.24s (± 0.94%)}	_~	_1.22s	_1.25s	_{p=0.456 n=6}
_{Check Time}	_{7.20s (± 0.48%)}	_{7.21s (± 0.32%)}	_~	_7.18s	_7.23s	_{p=0.746 n=6}
_{Emit Time}	_{4.36s (± 0.55%)}	_{4.35s (± 0.49%)}	_~	_4.32s	_4.38s	_{p=0.292 n=6}
_{Total Time}	_{14.95s (± 0.40%)}	_{14.95s (± 0.26%)}	_~	_14.90s	_15.00s	_{p=0.810 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,596k (± 0.01%)}	_{481,569k (± 0.01%)}	_~	_481,539k	_481,609k	_{p=0.128 n=6}
_{Parse Time}	_{3.24s (± 0.42%)}	_{3.25s (± 0.13%)}	_~	_3.24s	_3.25s	_{p=0.528 n=6}
_{Bind Time}	_{0.94s (± 1.24%)}	_{0.94s (± 0.86%)}	_~	_0.93s	_0.95s	_{p=0.315 n=6}
_{Check Time}	_{17.89s (± 0.69%)}	_{17.78s (± 0.61%)}	_~	_17.69s	_17.98s	_{p=0.092 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.07s (± 0.62%)}	_{21.97s (± 0.51%)}	_~	_21.89s	_22.19s	_{p=0.126 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,515k (± 0.01%)}	_{560,529k (± 0.01%)}	_~	_560,488k	_560,618k	_{p=0.378 n=6}
_{Parse Time}	_{4.00s (± 0.26%)}	_{4.01s (± 0.69%)}	_~	_3.97s	_4.05s	_{p=0.371 n=6}
_{Bind Time}	_{1.77s (± 0.42%)}	_{1.78s (± 0.29%)}	_~	_1.77s	_1.78s	_{p=0.247 n=6}
_{Check Time}	_{3.03s (± 0.61%)}	_{3.04s (± 0.77%)}	_~	_3.03s	_3.09s	_{p=0.223 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.89s (± 0.19%)}	_{8.92s (± 0.43%)}	_~	_8.88s	_8.98s	_{p=0.121 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₉₄₃	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

Nathan Shively-Sanders (sandersn)

Some questions about when the retrieved type is undefined.

Instantiate generic ElementType declarations

cfd2ae2

Wesley Wigham (weswigham) requested review from Daniel Rosenwasser (DanielRosenwasser) and Nathan Shively-Sanders (sandersn) April 20, 2023 23:20

TypeScript Bot (typescript-bot) assigned Wesley Wigham (weswigham) Apr 20, 2023

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Apr 20, 2023

Ryan Cavanaugh (RyanCavanaugh) approved these changes Apr 20, 2023

View reviewed changes

Nathan Shively-Sanders (sandersn) requested changes Apr 21, 2023

View reviewed changes

Comment thread src/compiler/checker.ts

Comment thread src/compiler/checker.ts

Comment thread src/compiler/checker.ts

Comment thread src/compiler/checker.ts

Nathan Shively-Sanders (sandersn) approved these changes Apr 24, 2023

View reviewed changes

Comment thread src/compiler/checker.ts

Wesley Wigham (weswigham) merged commit a177af1 into microsoft:main Apr 24, 2023

Wesley Wigham (weswigham) deleted the generic-element-type branch April 24, 2023 20:25

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Uh oh!

Conversation

Wesley Wigham (weswigham) commented Apr 20, 2023

Uh oh!

Jake Bailey (jakebailey) commented Apr 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 20, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 21, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 21, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 21, 2023

Uh oh!

Nathan Shively-Sanders (sandersn) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TypeScript Bot (typescript-bot) commented Apr 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 20, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 20, 2023 •

edited

Loading