Fix 53482 : Preserve newline/space behavior by iinicole · Pull Request #53732 · microsoft/TypeScript

Nicole (iinicole) · 2023-04-11T06:58:30Z

Nicole (iinicole) · 2023-04-11T07:00:18Z

Nicole (@iinicole) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree

Nicole (iinicole) · 2023-04-11T07:08:41Z

Andrew Branch (@andrewbranch) Hi! Could you please help review my pull request? I might also need some help in determining whether my changes provide the current behavior and modifying the old test cases to fit such behaviors. Thanks!

Nicole (iinicole) · 2023-04-12T02:50:19Z

Andrew Branch (@andrewbranch) Thanks for your advice! I have changed my code accordingly and added the test case in fourslash. Let me know if I got the idea correct this time.

Andrew Branch (andrewbranch) · 2023-04-12T16:12:46Z

Nicole (@iinicole) this looks great! Let’s just run the perf and language server tests:

TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) test tsserver top100

TypeScript Bot (typescript-bot) · 2023-04-12T16:12:50Z

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at 4d6ad11. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-04-12T16:12:50Z

Heya Andrew Branch (@andrewbranch), I've started to run the diff-based top-repos suite (tsserver) on this PR at 4d6ad11. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2023-04-12T17:08:53Z

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53732

_Metric	_main	₅₃₇₃₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{365,323k (± 0.01%)}	_{365,339k (± 0.01%)}	_~	_365,273k	_365,415k	_{p=0.521 n=6}
_{Parse Time}	_{3.40s (± 0.64%)}	_{3.40s (± 0.24%)}	_~	_3.39s	_3.41s	_{p=0.357 n=6}
_{Bind Time}	_{1.12s (± 0.00%)}	_{1.12s (± 0.36%)}	_~	_1.12s	_1.13s	_{p=0.405 n=6}
_{Check Time}	_{8.77s (± 0.25%)}	_{8.74s (± 0.57%)}	_~	_8.67s	_8.80s	_{p=0.418 n=6}
_{Emit Time}	_{7.49s (± 0.80%)}	_{7.48s (± 0.39%)}	_~	_7.45s	_7.53s	_{p=0.872 n=6}
_{Total Time}	_{20.79s (± 0.23%)}	_{20.75s (± 0.36%)}	_~	_20.65s	_20.84s	_{p=0.335 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{191,763k (± 1.18%)}	_{191,776k (± 1.17%)}	_~	_190,826k	_196,350k	_{p=0.689 n=6}
_{Parse Time}	_{1.50s (± 0.42%)}	_{1.50s (± 0.70%)}	_~	_1.49s	_1.52s	_{p=0.388 n=6}
_{Bind Time}	_{0.77s (± 0.00%)}	_{0.77s (± 0.98%)}	_~	_0.76s	_0.78s	_{p=0.598 n=6}
_{Check Time}	_{9.58s (± 0.71%)}	_{9.62s (± 0.59%)}	_~	_9.56s	_9.72s	_{p=0.422 n=6}
_{Emit Time}	_{2.72s (± 1.24%)}	_{2.75s (± 0.70%)}	_~	_2.72s	_2.77s	_{p=0.168 n=6}
_{Total Time}	_{14.57s (± 0.54%)}	_{14.64s (± 0.53%)}	_~	_14.54s	_14.77s	_{p=0.148 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,508k (± 0.01%)}	_{346,514k (± 0.01%)}	_~	_346,473k	_346,566k	_{p=0.810 n=6}
_{Parse Time}	_{2.60s (± 0.97%)}	_{2.60s (± 1.01%)}	_~	_2.58s	_2.65s	_{p=0.686 n=6}
_{Bind Time}	_{1.00s (± 0.81%)}	_{1.01s (± 0.81%)}	_~	_1.00s	_1.02s	_{p=0.389 n=6}
_{Check Time}	_{7.13s (± 0.64%)}	_{7.12s (± 0.64%)}	_~	_7.08s	_7.19s	_{p=0.872 n=6}
_{Emit Time}	_{4.28s (± 1.71%)}	_{4.26s (± 0.89%)}	_~	_4.22s	_4.32s	_{p=0.936 n=6}
_{Total Time}	_{15.01s (± 0.65%)}	_{14.99s (± 0.36%)}	_~	_14.93s	_15.08s	_{p=0.936 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,724k (± 0.01%)}	_{300,709k (± 0.01%)}	_~	_300,688k	_300,742k	_{p=0.471 n=6}
_{Parse Time}	_{2.07s (± 1.01%)}	_{2.06s (± 0.66%)}	_~	_2.04s	_2.08s	_{p=0.934 n=6}
_{Bind Time}	_{1.14s (± 0.45%)}	_{1.14s (± 1.20%)}	_~	_1.12s	_1.16s	_{p=0.198 n=6}
_{Check Time}	_{6.58s (± 0.60%)}	_{6.57s (± 0.40%)}	_~	_6.55s	_6.62s	_{p=0.746 n=6}
_{Emit Time}	_{3.85s (± 1.03%)}	_{3.85s (± 0.51%)}	_~	_3.82s	_3.88s	_{p=0.331 n=6}
_{Total Time}	_{13.65s (± 0.50%)}	_{13.62s (± 0.43%)}	_~	_13.56s	_13.73s	_{p=0.468 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{480,178k (± 0.01%)}	_{480,175k (± 0.01%)}	_~	_480,062k	_480,236k	_{p=0.810 n=6}
_{Parse Time}	_{3.04s (± 0.45%)}	_{3.04s (± 0.87%)}	_~	_3.02s	_3.09s	_{p=0.934 n=6}
_{Bind Time}	_{0.92s (± 2.10%)}	_{0.92s (± 2.53%)}	_~	_0.91s	_0.97s	_{p=1.000 n=6}
_{Check Time}	_{16.92s (± 0.33%)}	_{16.96s (± 0.20%)}	_~	_16.90s	_17.00s	_{p=0.091 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.88s (± 0.29%)}	_{20.93s (± 0.26%)}	_~	_20.84s	_21.00s	_{p=0.260 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{562,182k (± 0.02%)}	_{562,187k (± 0.02%)}	_~	_562,065k	_562,349k	_{p=0.810 n=6}
_{Parse Time}	_{3.82s (± 0.42%)}	_{3.83s (± 0.77%)}	_~	_3.80s	_3.86s	_{p=0.868 n=6}
_{Bind Time}	_{1.65s (± 0.31%)}	_{1.64s (± 0.46%)}	_~	_1.63s	_1.65s	_{p=0.107 n=6}
_{Check Time}	_{2.86s (± 0.62%)}	_{2.83s (± 0.47%)}	_{-0.03s (- 0.99%)}	_2.82s	_2.85s	_{p=0.023 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.41s (± 0.30%)}	_{8.38s (± 0.29%)}	_~	_8.34s	_8.41s	_{p=0.053 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{364,717k (± 0.01%)}	_{364,721k (± 0.01%)}	_~	_364,676k	_364,778k	_{p=0.936 n=6}
_{Parse Time}	_{3.55s (± 1.00%)}	_{3.55s (± 0.78%)}	_~	_3.51s	_3.58s	_{p=0.871 n=6}
_{Bind Time}	_{1.18s (± 1.13%)}	_{1.18s (± 1.07%)}	_~	_1.16s	_1.19s	_{p=0.931 n=6}
_{Check Time}	_{9.53s (± 0.67%)}	_{9.54s (± 0.25%)}	_~	_9.50s	_9.57s	_{p=0.574 n=6}
_{Emit Time}	_{7.99s (± 0.64%)}	_{7.97s (± 0.69%)}	_~	_7.90s	_8.04s	_{p=0.506 n=6}
_{Total Time}	_{22.25s (± 0.51%)}	_{22.24s (± 0.30%)}	_~	_22.16s	_22.35s	_{p=0.936 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,527k (± 0.03%)}	_{192,532k (± 0.03%)}	_~	_192,484k	_192,614k	_{p=1.000 n=6}
_{Parse Time}	_{1.59s (± 0.95%)}	_{1.60s (± 1.30%)}	_~	_1.56s	_1.62s	_{p=0.871 n=6}
_{Bind Time}	_{0.83s (± 0.99%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.859 n=6}
_{Check Time}	_{10.36s (± 0.72%)}	_{10.30s (± 0.15%)}	_~	_10.28s	_10.32s	_{p=0.195 n=6}
_{Emit Time}	_{3.02s (± 1.18%)}	_{2.98s (± 0.72%)}	_~	_2.95s	_3.00s	_{p=0.102 n=6}
_{Total Time}	_{15.80s (± 0.69%)}	_{15.70s (± 0.32%)}	_~	_15.65s	_15.77s	_{p=0.089 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,788k (± 0.00%)}	_{345,771k (± 0.00%)}	_{-17k (- 0.00%)}	_345,760k	_345,790k	_{p=0.031 n=6}
_{Parse Time}	_{2.72s (± 0.60%)}	_{2.73s (± 0.51%)}	_~	_2.71s	_2.75s	_{p=1.000 n=6}
_{Bind Time}	_{1.08s (± 0.48%)}	_{1.08s (± 0.50%)}	_~	_1.08s	_1.09s	_{p=0.640 n=6}
_{Check Time}	_{7.82s (± 0.54%)}	_{7.80s (± 0.31%)}	_~	_7.76s	_7.83s	_{p=0.169 n=6}
_{Emit Time}	_{4.50s (± 0.76%)}	_{4.47s (± 0.52%)}	_~	_4.44s	_4.50s	_{p=0.142 n=6}
_{Total Time}	_{16.13s (± 0.44%)}	_{16.08s (± 0.15%)}	_~	_16.04s	_16.11s	_{p=0.090 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,053k (± 0.01%)}	_{300,063k (± 0.01%)}	_~	_300,043k	_300,093k	_{p=0.810 n=6}
_{Parse Time}	_{2.16s (± 0.35%)}	_{2.16s (± 0.63%)}	_~	_2.15s	_2.18s	_{p=0.672 n=6}
_{Bind Time}	_{1.24s (± 0.88%)}	_{1.23s (± 1.11%)}	_~	_1.22s	_1.25s	_{p=0.456 n=6}
_{Check Time}	_{7.22s (± 0.62%)}	_{7.22s (± 0.39%)}	_~	_7.18s	_7.25s	_{p=1.000 n=6}
_{Emit Time}	_{4.33s (± 0.66%)}	_{4.35s (± 0.69%)}	_~	_4.32s	_4.41s	_{p=0.145 n=6}
_{Total Time}	_{14.96s (± 0.37%)}	_{14.97s (± 0.36%)}	_~	_14.90s	_15.03s	_{p=0.517 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,490k (± 0.01%)}	_{479,502k (± 0.01%)}	_~	_479,427k	_479,561k	_{p=0.936 n=6}
_{Parse Time}	_{3.24s (± 0.23%)}	_{3.24s (± 0.39%)}	_~	_3.22s	_3.25s	_{p=0.676 n=6}
_{Bind Time}	_{0.96s (± 0.57%)}	_{0.95s (± 1.23%)}	_~	_0.93s	_0.96s	_{p=0.859 n=6}
_{Check Time}	_{18.03s (± 0.86%)}	_{17.97s (± 0.53%)}	_~	_17.85s	_18.10s	_{p=0.748 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.22s (± 0.73%)}	_{22.16s (± 0.48%)}	_~	_22.03s	_22.30s	_{p=0.688 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{559,769k (± 0.02%)}	_{559,692k (± 0.02%)}	_~	_559,589k	_559,844k	_{p=0.378 n=6}
_{Parse Time}	_{3.98s (± 0.30%)}	_{3.99s (± 0.44%)}	_~	_3.97s	_4.02s	_{p=0.217 n=6}
_{Bind Time}	_{1.75s (± 0.56%)}	_{1.74s (± 0.47%)}	_~	_1.73s	_1.75s	_{p=0.062 n=6}
_{Check Time}	_{3.06s (± 0.40%)}	_{3.06s (± 0.45%)}	_~	_3.05s	_3.08s	_{p=0.177 n=6}
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.09s (± 4.45%)}	_~	_0.09s	_0.10s	_{p=0.595 n=6}
_{Total Time}	_{8.88s (± 0.09%)}	_{8.89s (± 0.19%)}	_~	_8.87s	_8.92s	_{p=0.452 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{358,504k (± 0.00%)}	_{358,502k (± 0.00%)}	_~	_358,489k	_358,525k	_{p=0.689 n=6}
_{Parse Time}	_{3.64s (± 0.36%)}	_{3.64s (± 0.51%)}	_~	_3.62s	_3.67s	_{p=0.560 n=6}
_{Bind Time}	_{1.21s (± 0.43%)}	_{1.22s (± 0.62%)}	_~	_1.21s	_1.23s	_{p=0.069 n=6}
_{Check Time}	_{9.94s (± 0.66%)}	_{9.93s (± 0.49%)}	_~	_9.86s	_9.99s	_{p=0.575 n=6}
_{Emit Time}	_{8.36s (± 1.47%)}	_{8.29s (± 0.29%)}	_~	_8.27s	_8.34s	_{p=0.468 n=6}
_{Total Time}	_{23.16s (± 0.75%)}	_{23.09s (± 0.37%)}	_~	_23.00s	_23.20s	_{p=0.688 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{187,818k (± 0.01%)}	_{187,821k (± 0.01%)}	_~	_187,792k	_187,841k	_{p=0.575 n=6}
_{Parse Time}	_{1.60s (± 0.47%)}	_{1.60s (± 0.92%)}	_~	_1.58s	_1.62s	_{p=0.620 n=6}
_{Bind Time}	_{0.86s (± 1.55%)}	_{0.85s (± 1.05%)}	_~	_0.84s	_0.86s	_{p=0.345 n=6}
_{Check Time}	_{10.43s (± 0.20%)}	_{10.44s (± 0.83%)}	_~	_10.28s	_10.54s	_{p=0.172 n=6}
_{Emit Time}	_{3.17s (± 1.31%)}	_{3.13s (± 0.62%)}	_~	_3.10s	_3.15s	_{p=0.145 n=6}
_{Total Time}	_{16.06s (± 0.36%)}	_{16.02s (± 0.63%)}	_~	_15.84s	_16.14s	_{p=0.747 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{340,670k (± 0.00%)}	_{340,668k (± 0.01%)}	_~	_340,638k	_340,695k	_{p=0.873 n=6}
_{Parse Time}	_{2.83s (± 0.62%)}	_{2.83s (± 1.14%)}	_~	_2.79s	_2.87s	_{p=0.935 n=6}
_{Bind Time}	_{1.11s (± 0.95%)}	_{1.10s (± 0.68%)}	_~	_1.09s	_1.11s	_{p=0.273 n=6}
_{Check Time}	_{8.14s (± 0.32%)}	_{8.13s (± 0.65%)}	_~	_8.05s	_8.19s	_{p=0.747 n=6}
_{Emit Time}	_{4.71s (± 0.95%)}	_{4.69s (± 0.69%)}	_~	_4.65s	_4.72s	_{p=0.418 n=6}
_{Total Time}	_{16.79s (± 0.36%)}	_{16.75s (± 0.43%)}	_~	_16.66s	_16.87s	_{p=0.466 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{295,145k (± 0.01%)}	_{295,142k (± 0.00%)}	_~	_295,130k	_295,149k	_{p=0.810 n=6}
_{Parse Time}	_{2.41s (± 0.90%)}	_{2.39s (± 0.31%)}	_~	_2.38s	_2.40s	_{p=0.217 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.06s (± 0.49%)}	_~	_1.06s	_1.07s	_{p=0.311 n=6}
_{Check Time}	_{7.57s (± 0.39%)}	_{7.56s (± 0.30%)}	_~	_7.53s	_7.58s	_{p=0.333 n=6}
_{Emit Time}	_{4.30s (± 1.22%)}	_{4.28s (± 0.83%)}	_~	_4.23s	_4.33s	_{p=1.000 n=6}
_{Total Time}	_{15.34s (± 0.35%)}	_{15.30s (± 0.30%)}	_~	_15.22s	_15.35s	_{p=0.295 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{474,886k (± 0.01%)}	_{474,908k (± 0.00%)}	_~	_474,888k	_474,922k	_{p=0.149 n=6}
_{Parse Time}	_{3.37s (± 0.66%)}	_{3.36s (± 0.72%)}	_~	_3.35s	_3.41s	_{p=0.558 n=6}
_{Bind Time}	_{1.00s (± 0.75%)}	_{1.00s (± 0.98%)}	_~	_0.99s	_1.01s	_{p=1.000 n=6}
_{Check Time}	_{18.97s (± 0.91%)}	_{18.86s (± 0.50%)}	_~	_18.74s	_18.97s	_{p=0.261 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.35s (± 0.80%)}	_{23.23s (± 0.39%)}	_~	_23.09s	_23.33s	_{p=0.335 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{548,273k (± 0.00%)}	_{548,282k (± 0.00%)}	_~	_548,267k	_548,304k	_{p=0.521 n=6}
_{Parse Time}	_{4.33s (± 1.79%)}	_{4.35s (± 1.69%)}	_~	_4.25s	_4.41s	_{p=0.807 n=6}
_{Bind Time}	_{1.60s (± 4.57%)}	_{1.57s (± 4.69%)}	_~	_1.52s	_1.67s	_{p=0.190 n=6}
_{Check Time}	_{3.19s (± 0.90%)}	_{3.21s (± 0.68%)}	_~	_3.18s	_3.24s	_{p=0.573 n=6}
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.09s (± 5.53%)}	_~	_0.09s	_0.10s	_{p=1.000 n=6}
_{Total Time}	_{9.22s (± 0.28%)}	_{9.22s (± 0.20%)}	_~	_9.21s	_9.26s	_{p=0.744 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₇₃₂	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..53732

_Metric	_main	₅₃₇₃₂	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,402ms (± 0.67%)}	_{2,411ms (± 0.64%)}	_~	_2,385ms	_2,431ms	_{p=0.376 n=6}
_{Req 2 - geterr}	_{5,704ms (± 0.83%)}	_{5,715ms (± 1.05%)}	_~	_5,628ms	_5,812ms	_{p=0.810 n=6}
_{Req 3 - references}	_{337ms (± 1.21%)}	_{335ms (± 0.81%)}	_~	_333ms	_340ms	_{p=0.571 n=6}
_{Req 4 - navto}	_{281ms (± 0.99%)}	_{281ms (± 0.85%)}	_~	_278ms	_285ms	_{p=0.935 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 3.04%)}	_{85ms (± 1.24%)}	_~	_83ms	_86ms	_{p=0.241 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,499ms (± 1.90%)}	_{2,509ms (± 1.25%)}	_~	_2,474ms	_2,561ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{4,262ms (± 0.54%)}	_{4,259ms (± 0.40%)}	_~	_4,230ms	_4,280ms	_{p=0.810 n=6}
_{Req 3 - references}	_{343ms (± 0.75%)}	_{347ms (± 0.34%)}	_{+4ms (+ 1.07%)}	_346ms	_349ms	_{p=0.042 n=6}
_{Req 4 - navto}	_{292ms (± 0.71%)}	_{291ms (± 0.60%)}	_~	_289ms	_294ms	_{p=0.683 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{64ms (± 4.73%)}	_{68ms (± 5.73%)}	_~	_63ms	_71ms	_{p=0.084 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,023ms (± 0.50%)}	_{3,010ms (± 0.36%)}	_~	_2,996ms	_3,023ms	_{p=0.127 n=6}
_{Req 2 - geterr}	_{1,618ms (± 0.87%)}	_{1,614ms (± 0.56%)}	_~	_1,601ms	_1,629ms	_{p=0.630 n=6}
_{Req 3 - references}	_{106ms (± 1.44%)}	_{106ms (± 1.39%)}	_~	_104ms	_108ms	_{p=0.462 n=6}
_{Req 4 - navto}	_{363ms (± 0.88%)}	_{364ms (± 0.32%)}	_~	_363ms	_366ms	_{p=0.627 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{369ms (± 1.63%)}	_{367ms (± 1.89%)}	_~	_357ms	_375ms	_{p=0.810 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,519ms (± 0.64%)}	_{2,525ms (± 0.84%)}	_~	_2,505ms	_2,554ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{6,101ms (± 1.15%)}	_{6,141ms (± 0.93%)}	_~	_6,066ms	_6,218ms	_{p=0.423 n=6}
_{Req 3 - references}	_{346ms (± 0.70%)}	_{345ms (± 0.41%)}	_~	_343ms	_347ms	_{p=0.808 n=6}
_{Req 4 - navto}	_{280ms (± 1.07%)}	_{279ms (± 0.27%)}	_~	_278ms	_280ms	_{p=0.454 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 5.57%)}	_{80ms (± 0.79%)}	_{🟩-6ms (- 6.43%)}	_79ms	_81ms	_{p=0.006 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,658ms (± 1.05%)}	_{2,668ms (± 0.75%)}	_~	_2,649ms	_2,699ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{4,634ms (± 0.43%)}	_{4,634ms (± 0.33%)}	_~	_4,616ms	_4,654ms	_{p=1.000 n=6}
_{Req 3 - references}	_{358ms (± 0.35%)}	_{358ms (± 0.41%)}	_~	_356ms	_360ms	_{p=0.867 n=6}
_{Req 4 - navto}	_{285ms (± 0.98%)}	_{288ms (± 0.99%)}	_~	_283ms	_291ms	_{p=0.126 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{68ms (± 0.81%)}	_{68ms (± 1.79%)}	_~	_67ms	_70ms	_{p=0.855 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,178ms (± 0.45%)}	_{3,182ms (± 0.22%)}	_~	_3,172ms	_3,191ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{1,761ms (± 0.90%)}	_{1,758ms (± 0.33%)}	_~	_1,751ms	_1,764ms	_{p=0.470 n=6}
_{Req 3 - references}	_{115ms (± 2.49%)}	_{117ms (± 3.38%)}	_~	_112ms	_121ms	_{p=0.520 n=6}
_{Req 4 - navto}	_{348ms (± 1.22%)}	_{345ms (± 1.86%)}	_~	_338ms	_353ms	_{p=0.630 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{387ms (± 1.08%)}	_{391ms (± 0.74%)}	_~	_387ms	_395ms	_{p=0.226 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,608ms (± 0.41%)}	_{2,602ms (± 0.60%)}	_~	_2,580ms	_2,616ms	_{p=0.572 n=6}
_{Req 2 - geterr}	_{6,441ms (± 1.12%)}	_{6,410ms (± 0.96%)}	_~	_6,349ms	_6,505ms	_{p=0.471 n=6}
_{Req 3 - references}	_{360ms (± 0.98%)}	_{361ms (± 0.65%)}	_~	_358ms	_364ms	_{p=0.292 n=6}
_{Req 4 - navto}	_{285ms (± 0.72%)}	_{285ms (± 0.70%)}	_~	_282ms	_287ms	_{p=0.681 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{91ms (± 5.30%)}	_{93ms (± 6.79%)}	_~	_89ms	_102ms	_{p=0.530 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,832ms (± 0.18%)}	_{2,825ms (± 0.52%)}	_~	_2,802ms	_2,842ms	_{p=0.377 n=6}
_{Req 2 - geterr}	_{4,730ms (± 0.45%)}	_{4,733ms (± 0.53%)}	_~	_4,701ms	_4,763ms	_{p=1.000 n=6}
_{Req 3 - references}	_{375ms (± 0.82%)}	_{375ms (± 0.82%)}	_~	_371ms	_379ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{291ms (± 0.35%)}	_{292ms (± 0.75%)}	_~	_289ms	_295ms	_{p=0.568 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 5.95%)}	_{79ms (± 5.12%)}	_~	_73ms	_82ms	_{p=0.562 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,396ms (± 0.61%)}	_{3,420ms (± 0.08%)}	_~	_3,417ms	_3,424ms	_{p=0.065 n=6}
_{Req 2 - geterr}	_{1,866ms (± 0.99%)}	_{1,851ms (± 0.79%)}	_~	_1,829ms	_1,871ms	_{p=0.173 n=6}
_{Req 3 - references}	_{125ms (± 0.93%)}	_{125ms (± 1.09%)}	_~	_123ms	_127ms	_{p=0.506 n=6}
_{Req 4 - navto}	_{378ms (± 1.15%)}	_{378ms (± 1.03%)}	_~	_371ms	_381ms	_{p=0.739 n=6}
_{Req 5 - completionInfo count}	_{2,862 (± 0.00%)}	_{2,862 (± 0.00%)}	_~	_2,862	_2,862	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{411ms (± 1.45%)}	_{409ms (± 0.98%)}	_~	_404ms	_415ms	_{p=0.936 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₇₃₂	₆
_Baseline	_main	₆

Startup

Comparison Report - main..53732

_Metric	_main	₅₃₇₃₂	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{141.67ms (± 0.17%)}	_{142.54ms (± 0.23%)}	_{+0.87ms (+ 0.61%)}	_141.55ms	_150.42ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{220.31ms (± 0.22%)}	_{223.98ms (± 0.54%)}	_{+3.67ms (+ 1.66%)}	_219.96ms	_233.85ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{222.39ms (± 0.33%)}	_{226.21ms (± 0.21%)}	_{+3.82ms (+ 1.72%)}	_221.88ms	_232.28ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{204.10ms (± 0.31%)}	_{206.85ms (± 0.37%)}	_{+2.75ms (+ 1.35%)}	_203.61ms	_215.94ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₇₃₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

TypeScript Bot (typescript-bot) · 2023-04-12T18:20:59Z

Andrew Branch (@andrewbranch) Here are the results of running the top-repos suite comparing main and refs/pull/53732/merge:

Everything looks good!

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>

Andrew Branch (andrewbranch) · 2023-04-18T16:58:13Z

Thanks Nicole (@iinicole)!

Nicole (iinicole) added 3 commits April 10, 2023 18:44

Change emitter to preserve newline in if statement

6da4326

temp fix for preserve newline behavior

709493c

Create test case for preserve behavior

426e93f

TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Apr 11, 2023

Nicole (iinicole) commented Apr 11, 2023

View reviewed changes

Comment thread src/compiler/emitter.ts Outdated

Comment thread src/compiler/emitter.ts Outdated

Comment thread src/compiler/emitter.ts Outdated

change emitter behavior

53a40b9

Create preserveSpace.ts

4d6ad11

Andrew Branch (andrewbranch) approved these changes Apr 12, 2023

View reviewed changes

Andrew Branch (andrewbranch) requested a review from Ron Buckton (rbuckton) April 12, 2023 18:48

Andrew Branch (andrewbranch) reviewed Apr 18, 2023

View reviewed changes

Comment thread src/compiler/emitter.ts Outdated

short circuit getLineTerminatorCount

8e21431

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>

Andrew Branch (andrewbranch) merged commit 178198b into microsoft:main Apr 18, 2023

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025

Navigation Menu

Uh oh!

Fix 53482 : Preserve newline/space behavior - #53732

Fix 53482 : Preserve newline/space behavior#53732
Andrew Branch (andrewbranch) merged 6 commits into
microsoft:mainfrom
iinicole:fix-53482

Nicole (iinicole) commented Apr 11, 2023

Uh oh!

Nicole (iinicole) commented Apr 11, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nicole (iinicole) commented Apr 11, 2023

Uh oh!

Nicole (iinicole) commented Apr 12, 2023 •

edited

Loading

Uh oh!

Andrew Branch (andrewbranch) commented Apr 12, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 12, 2023 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 12, 2023 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 12, 2023

Compiler

TSServer

Startup

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 12, 2023

Uh oh!

Uh oh!

Andrew Branch (andrewbranch) commented Apr 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Nicole (iinicole) commented Apr 11, 2023

Uh oh!

Nicole (iinicole) commented Apr 11, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nicole (iinicole) commented Apr 11, 2023

Uh oh!

Nicole (iinicole) commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andrew Branch (andrewbranch) commented Apr 12, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 12, 2023

Compiler

TSServer

Startup

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 12, 2023

Uh oh!

Uh oh!

Andrew Branch (andrewbranch) commented Apr 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Nicole (iinicole) commented Apr 12, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 12, 2023 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 12, 2023 •

edited

Loading