Mark more options as affecting errors/resolution - #53403
Merged
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Jake Bailey (jakebailey)
force-pushed
the
fix-53391
branch
from
May 4, 2023 22:51
73d0d4b to
c1a3afd
Compare
Jake Bailey (jakebailey)
marked this pull request as ready for review
May 4, 2023 22:51
Jake Bailey (jakebailey)
force-pushed
the
fix-53391
branch
from
May 4, 2023 23:25
c1a3afd to
7dc8f01
Compare
Sheetal Nandi (sheetalkamat)
requested changes
May 5, 2023
Sheetal Nandi (sheetalkamat)
requested changes
Sep 12, 2023
Sheetal Nandi (sheetalkamat)
left a comment
Sheetal Nandi (sheetalkamat)
left a comment
Member
There was a problem hiding this comment.
Left responses after looking at the example. It would be good to add the repro giving by daniel as a test and handle "allowJs" correctly.
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Sheetal Nandi (sheetalkamat)
September 18, 2023 23:56
Sheetal Nandi (sheetalkamat)
requested changes
Sep 19, 2023
| @@ -0,0 +1,170 @@ | |||
| currentDirectory:: /user/username/projects/myproject useCaseSensitiveFileNames: false | |||
| Input:: | |||
There was a problem hiding this comment.
Should this baseline be deleted as its outdated?
Member
Author
There was a problem hiding this comment.
Yep, oops. Didn't see CI!
Member
|
Do you mind commenting in "jsx" commandline option why affectsSemanticDIagnostics is needed apart from module resolution affects flag so we dont have to investigate it again. |
Member
Author
|
Updated with a comment. |
Jake Bailey (jakebailey)
requested a review
from Sheetal Nandi (sheetalkamat)
September 19, 2023 21:18
Sheetal Nandi (sheetalkamat)
approved these changes
Sep 19, 2023
Marcus Ording (snovader)
pushed a commit
to EG-A-S/TypeScript
that referenced
this pull request
Sep 23, 2023
Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53391