Skip to content

Exclude completions of binding pattern variable initializers - #52723

Merged
Nathan Shively-Sanders (sandersn) merged 3 commits into
microsoft:mainfrom
zardoy:no-self-completions-from-binding-pattern
Apr 2, 2025
Merged

Exclude completions of binding pattern variable initializers#52723
Nathan Shively-Sanders (sandersn) merged 3 commits into
microsoft:mainfrom
zardoy:no-self-completions-from-binding-pattern

Conversation

@zardoy

@zardoy Vitaly (zardoy) commented Feb 11, 2023

Copy link
Copy Markdown
Contributor

Fixes #53049

const {a1} = a/* should not complete a1 */

Real world case:

let pageToReturn

const { data: pageData } = await octokit.repos.listTags({
    page: page /* pageData is suggested first */
})

Some kind of follow up for #42087

Decided to build on top of #52690 (so there is no conflicts if gets merged)

For now will wait until that PR is merged.

@zardoy
Vitaly (zardoy) force-pushed the no-self-completions-from-binding-pattern branch from af52d4c to c4d73a0 Compare April 20, 2023 12:50
@zardoy
Vitaly (zardoy) marked this pull request as ready for review April 20, 2023 12:50
@sandersn

Nathan Shively-Sanders (sandersn) commented Apr 2, 2025

Copy link
Copy Markdown
Member

New changes require approval from someone other than sandersn because they were the last pusher.

well this is annoying

@sandersn
Nathan Shively-Sanders (sandersn) merged commit ba663f6 into microsoft:main Apr 2, 2025
@zardoy

Copy link
Copy Markdown
Contributor Author

Thank you! You are the best!

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude completions of binding pattern variable initializers

5 participants