fix(52514): overload Tags do not receive noImplicitAny errors on missing return types - #52518
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoJan 31, 2023
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Daniel Rosenwasser (DanielRosenwasser)
requested a review
from Nathan Shively-Sanders (sandersn)
January 30, 2023 20:36
Oleksandr Tarasiuk (a-tarasyuk)
marked this pull request as ready for review
January 30, 2023 21:31
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Jan 30, 2023
Nathan Shively-Sanders (sandersn)
requested changes
Jan 31, 2023
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Looks good but I think the error position can be expressed more succinctly.
Nathan Shively-Sanders (sandersn)
approved these changes
Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52514