Skip to content

[For testing only]: Redirect node to bundler - #51973

Closed
Andrew Branch (andrewbranch) wants to merge 7 commits into
microsoft:mainfrom
andrewbranch:try-bundler
Closed

[For testing only]: Redirect node to bundler#51973
Andrew Branch (andrewbranch) wants to merge 7 commits into
microsoft:mainfrom
andrewbranch:try-bundler

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member

No description provided.

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) run top200

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) run top100

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) run top 200 ?

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) run top 100

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) is this how I find out I’ve been fired?

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test top100

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test top 100

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the diff-based top-repos suite on this PR at ee87f10. You can monitor the build here.

Update: The results are in! Part 1, Part 2, Part 3

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch) Here are the results of running the top-repos suite comparing main and refs/pull/51973/merge:

Something interesting changed - please have a look.

Details

appsmithorg/appsmith

3 of 4 projects failed to build with the old tsc and were ignored

app/shared/ast/tsconfig.json

conwnet/github1s

2 of 4 projects failed to build with the old tsc and were ignored

tests/tsconfig.json

Eugeny/tabby

19 of 29 projects failed to build with the old tsc and were ignored

app/tsconfig.main.json

  • error TS5099: Import assignment is not allowed when 'moduleResolution' is set to 'bundler'. Consider using 'import * as ns from "mod"', 'import {a} from "mod"', 'import d from "mod"', or another module format instead.

lensapp/lens

6 of 8 projects failed to build with the old tsc and were ignored

build/tsconfig.json

integration/tsconfig.json

palantir/blueprint

4 of 27 projects failed to build with the old tsc and were ignored

packages/datetime2/src/tsconfig.json

packages/datetime2/test/tsconfig.json

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch) Here are some more interesting changes from running the top-repos suite

Details

react-bootstrap/react-bootstrap

test/tsconfig.json

tsconfig.json

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch) Here are some more interesting changes from running the top-repos suite

Details

Redocly/redoc

tsconfig.json

  • error TS2345: Argument of type '{ openapi: string; info: { version: string; title: string; }; components: { callbacks: { Test: { "/test": { post: { operationId: string; description: string; requestBody: { content: { "application/json": { schema: { ...; }; }; }; }; parameters: { ...; }[]; responses: { ...; }; }; }; }; }; }; }' is not assignable to parameter of type 'OpenAPISpec'.
  • error TS2345: Argument of type '{ openapi: string; components: { schemas: { Pet: { type: string; required: string[]; discriminator: { propertyName: string; }; properties: { type: { type: string; }; }; }; Dog: { type: string; allOf: { $ref: string; }[]; properties: { ...; }; }; Cat: { ...; }; }; }; }' is not assignable to parameter of type 'OpenAPISpec'.
  • error TS2345: Argument of type '{ openapi: string; info: { title: string; version: string; }; paths: { "/pet": { put: { summary: string; description: string; operationId: string; responses: { "405": { description: string; }; }; security: ({ GitLab_PersonalAccessToken: never[]; GitLab_OpenIdConnect: never[]; basicAuth: never[]; petstore_auth?: unde...' is not assignable to parameter of type 'OpenAPISpec'.

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS7016: Could not find a declaration file for module 'form-data-encoder'. '/mnt/ts_downloads/hyper/node_modules/form-data-encoder/lib/index.js' implicitly has an 'any' type.
    • file:///mnt/ts_downloads/hyper/node_modules/got/dist/source/core/options.d.ts#L22 in tsconfig.json

youzan/vant

4 of 10 projects failed to build with the old tsc and were ignored

packages/vant-cli/site/tsconfig.json

  • error TS7016: Could not find a declaration file for module 'highlight.js'. '/mnt/ts_downloads/vant/node_modules/.pnpm/highlight.js@11.6.0/node_modules/highlight.js/es/index.js' implicitly has an 'any' type.
  • error TS7016: Could not find a declaration file for module 'vite-plugin-md'. '/mnt/ts_downloads/vant/node_modules/.pnpm/vite-plugin-md@0.11.9_vite@3.1.8/node_modules/vite-plugin-md/dist/index.mjs' implicitly has an 'any' type.

packages/vant-cli/tsconfig.json

  • error TS7016: Could not find a declaration file for module 'highlight.js'. '/mnt/ts_downloads/vant/node_modules/.pnpm/highlight.js@11.6.0/node_modules/highlight.js/es/index.js' implicitly has an 'any' type.
  • error TS7016: Could not find a declaration file for module 'vite-plugin-md'. '/mnt/ts_downloads/vant/node_modules/.pnpm/vite-plugin-md@0.11.9_vite@3.1.8/node_modules/vite-plugin-md/dist/index.mjs' implicitly has an 'any' type.

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Dec 20, 2022

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test tsserver top100
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at ee87f10. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite (tsserver) on this PR at ee87f10. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite on this PR at ee87f10. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the abridged perf test suite on this PR at ee87f10. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized Definitely Typed test suite on this PR at ee87f10. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based top-repos suite (tsserver) on this PR at ee87f10. You can monitor the build here.

Update: The results are in!

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Dec 20, 2022

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) perf test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at ee87f10. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the user test suite comparing main and refs/pull/51973/merge:

Everything looks good!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the user test suite comparing main and refs/pull/51973/merge:

Something interesting changed - please have a look.

Details

puppeteer

packages/testserver/tsconfig.json

TypeScript-Node-Starter

tsconfig.json

TypeScript-WeChat-Starter

tsconfig.json

  • [NEW] error TS5099: Import assignment is not allowed when 'moduleResolution' is set to 'bundler'. Consider using 'import * as ns from "mod"', 'import {a} from "mod"', 'import d from "mod"', or another module format instead.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the top-repos suite comparing main and refs/pull/51973/merge:

Something interesting changed - please have a look.

Details

backstage/backstage

⚠️ Note that built also had errors ⚠️ 
Req #4309 - completionInfo
    at hasCovariantVoidArgument (/typescript-main/built/local/tsserver.js:60118:91)
    at relateVariances (/typescript-main/built/local/tsserver.js:59368:64)
    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59037:32)
    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58955:21)
    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58925:19)
    at isRelatedTo (/typescript-main/built/local/tsserver.js:58484:16)
    at checkTypeRelatedTo (/typescript-main/built/local/tsserver.js:58218:20)
    at isTypeRelatedTo (/typescript-main/built/local/tsserver.js:58173:14)
    at isTypeIdenticalTo (/typescript-main/built/local/tsserver.js:57509:12)
    at isTypeOrBaseIdenticalTo (/typescript-main/built/local/tsserver.js:61721:42)
    at inferFromMatchingTypes (/typescript-main/built/local/tsserver.js:61391:15)
    at inferFromTypes (/typescript-main/built/local/tsserver.js:61223:44)
    at inferTypes (/typescript-main/built/local/tsserver.js:61198:5)
    at inferReverseMappedType (/typescript-main/built/local/tsserver.js:61031:5)
    at getTypeOfReverseMappedSymbol (/typescript-main/built/local/tsserver.js:61023:20)
    at getTypeOfSymbol (/typescript-main/built/local/tsserver.js:51670:14)
    at getNonMissingTypeOfSymbol (/typescript-main/built/local/tsserver.js:51690:30)
    at membersRelatedToIndexInfo (/typescript-main/built/local/tsserver.js:59879:28)
    at typeRelatedToIndexInfo (/typescript-main/built/local/tsserver.js:59935:16)
    at indexSignaturesRelatedTo (/typescript-main/built/local/tsserver.js:59921:280)
    at structuredTypeRelatedToWorker (/typescript-main/built/local/tsserver.js:59333:28)
    at structuredTypeRelatedTo (/typescript-main/built/local/tsserver.js:58955:21)
    at recursiveTypeRelatedTo (/typescript-main/built/local/tsserver.js:58925:19)
    at isRelatedTo (/typescript-main/built/local/tsserver.js:58528:122)
    at checkTypeRelatedTo (/typescript-main/built/local/tsserver.js:58218:20)
    at isTypeRelatedTo (/typescript-main/built/local/tsserver.js:58173:14)
    at Object.compareTypesAssignable [as compareTypes] (/typescript-main/built/local/tsserver.js:57515:12)
    at getInferredType (/typescript-main/built/local/tsserver.js:61783:39)
    at getInferredTypes (/typescript-main/built/local/tsserver.js:61796:19)
    at inferTypeArguments (/typescript-main/built/local/tsserver.js:66984:12)
    at chooseOverload (/typescript-main/built/local/tsserver.js:67598:33)
    at resolveCall (/typescript-main/built/local/tsserver.js:67465:16)
    at resolveCallExpression (/typescript-main/built/local/tsserver.js:67796:12)
    at resolveSignature (/typescript-main/built/local/tsserver.js:68141:16)
    at getResolvedSignature (/typescript-main/built/local/tsserver.js:68161:20)
    at getContextualTypeForArgumentAtIndex (/typescript-main/built/local/tsserver.js:64457:112)
    at getContextualTypeForArgument (/typescript-main/built/local/tsserver.js:64451:39)
    at getContextualType2 (/typescript-main/built/local/tsserver.js:64830:16)
    at getApparentTypeOfContextualType (/typescript-main/built/local/tsserver.js:64773:120)
    at getContextualTypeForObjectLiteralElement (/typescript-main/built/local/tsserver.js:64653:18)
    at getContextualType2 (/typescript-main/built/local/tsserver.js:64838:16)
    at Object.getContextualType (/typescript-main/built/local/tsserver.js:44215:14)
    at tryGetObjectLiteralContextualType (/typescript-main/built/local/tsserver.js:137615:28)
    at tryGetObjectLikeCompletionSymbols (/typescript-main/built/local/tsserver.js:136823:32)
    at tryGetGlobalSymbols (/typescript-main/built/local/tsserver.js:136452:80)
    at getCompletionData (/typescript-main/built/local/tsserver.js:136237:10)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:134650:26)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:123134:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:161235:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:159916:43)
    at /typescript-main/built/local/tsserver.js:161945:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:161937:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:161945:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:161973:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:163372:14)

Req #4309 - completionInfo
    at hasCovariantVoidArgument (/typescript-51973/built/local/tsserver.js:60118:91)
    at relateVariances (/typescript-51973/built/local/tsserver.js:59368:64)
    at structuredTypeRelatedToWorker (/typescript-51973/built/local/tsserver.js:59037:32)
    at structuredTypeRelatedTo (/typescript-51973/built/local/tsserver.js:58955:21)
    at recursiveTypeRelatedTo (/typescript-51973/built/local/tsserver.js:58925:19)
    at isRelatedTo (/typescript-51973/built/local/tsserver.js:58484:16)
    at checkTypeRelatedTo (/typescript-51973/built/local/tsserver.js:58218:20)
    at isTypeRelatedTo (/typescript-51973/built/local/tsserver.js:58173:14)
    at isTypeIdenticalTo (/typescript-51973/built/local/tsserver.js:57509:12)
    at isTypeOrBaseIdenticalTo (/typescript-51973/built/local/tsserver.js:61721:42)
    at inferFromMatchingTypes (/typescript-51973/built/local/tsserver.js:61391:15)
    at inferFromTypes (/typescript-51973/built/local/tsserver.js:61223:44)
    at inferTypes (/typescript-51973/built/local/tsserver.js:61198:5)
    at inferReverseMappedType (/typescript-51973/built/local/tsserver.js:61031:5)
    at getTypeOfReverseMappedSymbol (/typescript-51973/built/local/tsserver.js:61023:20)
    at getTypeOfSymbol (/typescript-51973/built/local/tsserver.js:51670:14)
    at getNonMissingTypeOfSymbol (/typescript-51973/built/local/tsserver.js:51690:30)
    at membersRelatedToIndexInfo (/typescript-51973/built/local/tsserver.js:59879:28)
    at typeRelatedToIndexInfo (/typescript-51973/built/local/tsserver.js:59935:16)
    at indexSignaturesRelatedTo (/typescript-51973/built/local/tsserver.js:59921:280)
    at structuredTypeRelatedToWorker (/typescript-51973/built/local/tsserver.js:59333:28)
    at structuredTypeRelatedTo (/typescript-51973/built/local/tsserver.js:58955:21)
    at recursiveTypeRelatedTo (/typescript-51973/built/local/tsserver.js:58925:19)
    at isRelatedTo (/typescript-51973/built/local/tsserver.js:58528:122)
    at checkTypeRelatedTo (/typescript-51973/built/local/tsserver.js:58218:20)
    at isTypeRelatedTo (/typescript-51973/built/local/tsserver.js:58173:14)
    at Object.compareTypesAssignable [as compareTypes] (/typescript-51973/built/local/tsserver.js:57515:12)
    at getInferredType (/typescript-51973/built/local/tsserver.js:61783:39)
    at getInferredTypes (/typescript-51973/built/local/tsserver.js:61796:19)
    at inferTypeArguments (/typescript-51973/built/local/tsserver.js:66984:12)
    at chooseOverload (/typescript-51973/built/local/tsserver.js:67598:33)
    at resolveCall (/typescript-51973/built/local/tsserver.js:67465:16)
    at resolveCallExpression (/typescript-51973/built/local/tsserver.js:67796:12)
    at resolveSignature (/typescript-51973/built/local/tsserver.js:68141:16)
    at getResolvedSignature (/typescript-51973/built/local/tsserver.js:68161:20)
    at getContextualTypeForArgumentAtIndex (/typescript-51973/built/local/tsserver.js:64457:112)
    at getContextualTypeForArgument (/typescript-51973/built/local/tsserver.js:64451:39)
    at getContextualType2 (/typescript-51973/built/local/tsserver.js:64830:16)
    at getApparentTypeOfContextualType (/typescript-51973/built/local/tsserver.js:64773:120)
    at getContextualTypeForObjectLiteralElement (/typescript-51973/built/local/tsserver.js:64653:18)
    at getContextualType2 (/typescript-51973/built/local/tsserver.js:64838:16)
    at Object.getContextualType (/typescript-51973/built/local/tsserver.js:44215:14)
    at tryGetObjectLiteralContextualType (/typescript-51973/built/local/tsserver.js:137615:28)
    at tryGetObjectLikeCompletionSymbols (/typescript-51973/built/local/tsserver.js:136823:32)
    at tryGetGlobalSymbols (/typescript-51973/built/local/tsserver.js:136452:80)
    at getCompletionData (/typescript-51973/built/local/tsserver.js:136237:10)
    at Object.getCompletionsAtPosition (/typescript-51973/built/local/tsserver.js:134650:26)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-51973/built/local/tsserver.js:123134:35)
    at IOSession.getCompletions (/typescript-51973/built/local/tsserver.js:161235:54)
    at completionInfo (/typescript-51973/built/local/tsserver.js:159916:43)
    at /typescript-51973/built/local/tsserver.js:161945:69
    at IOSession.executeWithRequestId (/typescript-51973/built/local/tsserver.js:161937:14)
    at IOSession.executeCommand (/typescript-51973/built/local/tsserver.js:161945:29)
    at IOSession.onMessage (/typescript-51973/built/local/tsserver.js:161973:51)
    at Interface.<anonymous> (/typescript-51973/built/local/tsserver.js:163372:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/backstage.backstage.rawError.txt in the artifact folder

Last few requests

 
{"seq":4306,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend-module-bitbucket-cloud/src/service/BitbucketCloudEntityProviderCatalogModule.ts","line":30,"offset":4}}
{"seq":4307,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend-module-bitbucket-cloud/src/service/BitbucketCloudEntityProviderCatalogModule.ts","line":30,"offset":4,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":4308,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend-module-bitbucket-cloud/src/service/BitbucketCloudEntityProviderCatalogModule.ts","line":30,"offset":4,"entryNames":["@abstract"]}}
{"seq":4309,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/plugins/catalog-backend-module-bitbucket-cloud/src/service/BitbucketCloudEntityProviderCatalogModule.ts","line":38,"offset":1,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}

Repro Steps
  1. git clone https://github.com/backstage/backstage --recurse-submodules
  2. In dir backstage, run git reset --hard ff56bc2c5d4e4f773e933861ddfbc201d4fd1e1e
  3. Install packages (exact steps are below, but it might be easier to follow the repo readme)
    1. In dir backstage/cypress, run yarn install --no-immutable --mode=skip-build
    2. In dir backstage/microsite-next, run yarn install --no-immutable --mode=skip-build
    3. In dir backstage/microsite, run yarn install --no-immutable --mode=skip-build
    4. In dir backstage, run yarn install --no-immutable --mode=skip-build
    5. In dir backstage/storybook, run yarn install --no-immutable --mode=skip-build
  4. Back in the initial folder, download RepoResults4/backstage.backstage.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./backstage ./backstage.backstage.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

felixrieseberg/windows95

⚠️ Note that built also had errors ⚠️ 
Req #317 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:159324:21)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:160331:21)
    at IOSession.send (/typescript-main/built/local/tsserver.js:160328:10)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:160375:10)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:161986:14)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:163372:14)

Req #317 - references
    at formatMessage2 (/typescript-51973/built/local/tsserver.js:159324:21)
    at IOSession.writeMessage (/typescript-51973/built/local/tsserver.js:160331:21)
    at IOSession.send (/typescript-51973/built/local/tsserver.js:160328:10)
    at IOSession.doOutput (/typescript-51973/built/local/tsserver.js:160375:10)
    at IOSession.onMessage (/typescript-51973/built/local/tsserver.js:161986:14)
    at Interface.<anonymous> (/typescript-51973/built/local/tsserver.js:163372:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/felixrieseberg.windows95.rawError.txt in the artifact folder

Last few requests

 
{"seq":314,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":22605,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":315,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":22605,"entryNames":["_"]}}
{"seq":316,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":24309}}
{"seq":317,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":24356}}

Repro Steps
  1. git clone https://github.com/felixrieseberg/windows95 --recurse-submodules
  2. In dir windows95, run git reset --hard 17a81393467e2668eb2eea291ab4b6a749756dad
  3. In dir windows95, run yarn install --ignore-engines --ignore-scripts --silent
  4. Back in the initial folder, download RepoResults4/felixrieseberg.windows95.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./windows95 ./felixrieseberg.windows95.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

palantir/blueprint

⚠️ Note that built also had errors ⚠️ 
Req #12613 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:159324:21)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:160331:21)
    at IOSession.send (/typescript-main/built/local/tsserver.js:160328:10)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:160375:10)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:161986:14)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:163372:14)

Req #12613 - references
    at formatMessage2 (/typescript-51973/built/local/tsserver.js:159324:21)
    at IOSession.writeMessage (/typescript-51973/built/local/tsserver.js:160331:21)
    at IOSession.send (/typescript-51973/built/local/tsserver.js:160328:10)
    at IOSession.doOutput (/typescript-51973/built/local/tsserver.js:160375:10)
    at IOSession.onMessage (/typescript-51973/built/local/tsserver.js:161986:14)
    at Interface.<anonymous> (/typescript-51973/built/local/tsserver.js:163372:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in the artifact folder

Last few requests

 
{"seq":12610,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":492667,"entryNames":["_"]}}
{"seq":12611,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":493435}}
{"seq":12612,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":493729,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":12613,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":494368}}

Repro Steps
  1. git clone https://github.com/palantir/blueprint --recurse-submodules
  2. In dir blueprint, run git reset --hard b6c1518ea2f524accfba8045ce6f22cac7c5b56e
  3. In dir blueprint, run yarn install --ignore-engines --ignore-scripts --silent
  4. Back in the initial folder, download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

vercel/hyper

⚠️ Note that built also had errors ⚠️ 
Req #11613 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:159324:21)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:160331:21)
    at IOSession.send (/typescript-main/built/local/tsserver.js:160328:10)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:160375:10)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:161986:14)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:163372:14)

Req #11613 - references
    at formatMessage2 (/typescript-51973/built/local/tsserver.js:159324:21)
    at IOSession.writeMessage (/typescript-51973/built/local/tsserver.js:160331:21)
    at IOSession.send (/typescript-51973/built/local/tsserver.js:160328:10)
    at IOSession.doOutput (/typescript-51973/built/local/tsserver.js:160375:10)
    at IOSession.onMessage (/typescript-51973/built/local/tsserver.js:161986:14)
    at Interface.<anonymous> (/typescript-51973/built/local/tsserver.js:163372:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults2/vercel.hyper.rawError.txt in the artifact folder

Last few requests

 
{"seq":11610,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":72154,"offset":12,"entryNames":["__err"]}}
{"seq":11611,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":72155,"offset":15,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":11612,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":72178,"offset":8,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":2,"triggerCharacter":" "}}
{"seq":11613,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/bin/yarn-standalone.js","line":72180,"offset":56}}

Repro Steps
  1. git clone https://github.com/vercel/hyper --recurse-submodules
  2. In dir hyper, run git reset --hard 45fe2a6b151f27f6ad976a3819db1425bd6f30e2
  3. Back in the initial folder, download RepoResults2/vercel.hyper.replay.txt from the artifact folder
  4. npm install --no-save @typescript/server-replay
  5. npx tsreplay ./hyper ./vercel.hyper.replay.txt path/to/tsserver.js
  6. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Dec 20, 2022
Merged
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Re: #51973 (comment)

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

I haven’t looked at Puppeteer yet, but I’m looking at react-bootstrap and it turns out there’s a pretty significant bug that has always existed in node16 and nodenext that bundler inherited around nested package.jsons. I’m trying to clean it up, and I think typesVersions has been bizarrely busted forever.

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

The fix is to also specify @types/ws in the respective package instead of relying on the monorepo root.

That doesn’t sound intentional. I intentionally backed out some changes that would have required this when I realized that it negatively impacts monorepos.

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51973
Metric main 51973 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 372,326k (± 0.01%) 374,002k (± 0.01%) +1,677k (+ 0.45%) 373,935k 374,062k
Parse Time 3.97s (± 0.89%) 3.93s (± 1.19%) -0.05s (- 1.20%) 3.87s 3.99s
Bind Time 1.20s (± 0.78%) 1.20s (± 0.64%) +0.00s (+ 0.22%) 1.19s 1.21s
Check Time 8.58s (± 0.35%) 8.54s (± 0.34%) -0.04s (- 0.43%) 8.51s 8.59s
Emit Time 7.56s (± 0.28%) 7.54s (± 0.76%) -0.03s (- 0.33%) 7.44s 7.61s
Total Time 21.31s (± 0.33%) 21.21s (± 0.21%) -0.10s (- 0.49%) 21.18s 21.30s
Compiler-Unions - node (v18.10.0, x64)
Memory used 200,969k (± 1.53%) 199,947k (± 1.46%) -1,022k (- 0.51%) 198,036k 203,725k
Parse Time 1.64s (± 1.25%) 1.63s (± 1.49%) -0.01s (- 0.58%) 1.60s 1.66s
Bind Time 0.79s (± 0.75%) 0.80s (± 0.66%) +0.00s (+ 0.13%) 0.79s 0.80s
Check Time 9.45s (± 0.84%) 9.48s (± 0.48%) +0.03s (+ 0.27%) 9.41s 9.53s
Emit Time 2.76s (± 0.84%) 2.76s (± 0.96%) -0.00s (- 0.05%) 2.72s 2.80s
Total Time 14.65s (± 0.67%) 14.66s (± 0.56%) +0.01s (+ 0.08%) 14.56s 14.75s
Monaco - node (v18.10.0, x64)
Memory used 353,957k (± 0.01%) 353,960k (± 0.01%) +3k (+ 0.00%) 353,926k 354,012k
Parse Time 2.96s (± 1.24%) 2.95s (± 1.31%) -0.01s (- 0.36%) 2.88s 2.99s
Bind Time 1.04s (± 0.88%) 1.04s (± 1.52%) -0.00s (- 0.13%) 1.03s 1.06s
Check Time 7.20s (± 0.26%) 7.21s (± 0.43%) +0.01s (+ 0.08%) 7.16s 7.25s
Emit Time 4.27s (± 0.66%) 4.26s (± 0.85%) -0.00s (- 0.04%) 4.22s 4.33s
Total Time 15.46s (± 0.39%) 15.46s (± 0.47%) -0.01s (- 0.04%) 15.37s 15.57s
TFS - node (v18.10.0, x64)
Memory used 309,851k (± 0.01%) 309,852k (± 0.01%) +1k (+ 0.00%) 309,831k 309,877k
Parse Time 2.24s (± 0.91%) 2.24s (± 0.85%) +0.00s (+ 0.10%) 2.23s 2.28s
Bind Time 1.16s (± 0.67%) 1.16s (± 0.36%) +0.01s (+ 0.53%) 1.16s 1.17s
Check Time 6.82s (± 0.37%) 6.79s (± 0.54%) -0.02s (- 0.31%) 6.75s 6.84s
Emit Time 3.91s (± 0.58%) 3.92s (± 0.75%) +0.00s (+ 0.10%) 3.87s 3.94s
Total Time 14.13s (± 0.37%) 14.11s (± 0.37%) -0.02s (- 0.11%) 14.04s 14.20s
material-ui - node (v18.10.0, x64)
Memory used 485,002k (± 0.01%) 490,347k (± 0.01%) +5,345k (+ 1.10%) 490,270k 490,396k
Parse Time 3.53s (± 0.78%) 3.67s (± 0.30%) +0.14s (+ 4.09%) 3.65s 3.68s
Bind Time 0.96s (± 0.76%) 0.96s (± 0.92%) +0.00s (+ 0.52%) 0.95s 0.98s
Check Time 16.95s (± 0.44%) 16.90s (± 0.49%) -0.04s (- 0.25%) 16.80s 17.04s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.43s (± 0.48%) 21.54s (± 0.37%) +0.11s (+ 0.51%) 21.44s 21.68s
xstate - node (v18.10.0, x64)
Memory used 569,665k (± 0.02%) 571,254k (± 0.02%) +1,589k (+ 0.28%) 571,088k 571,393k
Parse Time 4.44s (± 0.89%) 4.49s (± 0.26%) +0.05s (+ 1.22%) 4.48s 4.51s
Bind Time 1.69s (± 1.25%) 1.68s (± 0.65%) -0.02s (- 1.14%) 1.67s 1.70s
Check Time 2.60s (± 0.88%) 2.59s (± 0.86%) -0.00s (- 0.19%) 2.56s 2.63s
Emit Time 0.08s (± 0.25%) 0.08s (± 0.21%) +0.00s (+ 0.13%) 0.08s 0.08s
Total Time 8.82s (± 0.56%) 8.84s (± 0.28%) +0.02s (+ 0.28%) 8.81s 8.88s
Angular - node (v16.17.1, x64)
Memory used 371,649k (± 0.01%) 373,372k (± 0.00%) +1,723k (+ 0.46%) 373,346k 373,393k
Parse Time 4.15s (± 0.47%) 4.15s (± 0.28%) -0.00s (- 0.05%) 4.14s 4.17s
Bind Time 1.27s (± 0.53%) 1.27s (± 0.30%) +0.00s (+ 0.03%) 1.27s 1.28s
Check Time 9.32s (± 0.64%) 9.25s (± 0.33%) -0.06s (- 0.68%) 9.21s 9.30s
Emit Time 7.99s (± 0.64%) 8.04s (± 0.39%) +0.05s (+ 0.62%) 7.99s 8.08s
Total Time 22.72s (± 0.32%) 22.71s (± 0.23%) -0.01s (- 0.06%) 22.63s 22.76s
Compiler-Unions - node (v16.17.1, x64)
Memory used 200,241k (± 0.62%) 199,798k (± 0.01%) -443k (- 0.22%) 199,775k 199,851k
Parse Time 1.81s (± 0.65%) 1.80s (± 0.78%) -0.01s (- 0.39%) 1.79s 1.83s
Bind Time 0.84s (± 0.58%) 0.84s (± 0.61%) +0.00s (+ 0.26%) 0.84s 0.85s
Check Time 10.12s (± 0.64%) 10.19s (± 0.99%) +0.07s (+ 0.66%) 10.04s 10.35s
Emit Time 3.07s (± 5.53%) 2.96s (± 0.91%) 🟩-0.11s (- 3.56%) 2.94s 3.00s
Total Time 15.85s (± 0.86%) 15.80s (± 0.86%) -0.05s (- 0.31%) 15.61s 16.00s
Monaco - node (v16.17.1, x64)
Memory used 353,241k (± 0.01%) 353,231k (± 0.01%) -10k (- 0.00%) 353,199k 353,249k
Parse Time 3.17s (± 0.61%) 3.14s (± 1.02%) -0.03s (- 0.81%) 3.11s 3.19s
Bind Time 1.12s (± 0.84%) 1.12s (± 0.73%) +0.00s (+ 0.28%) 1.11s 1.13s
Check Time 7.83s (± 0.30%) 7.86s (± 0.38%) +0.03s (+ 0.43%) 7.82s 7.89s
Emit Time 4.47s (± 0.77%) 4.48s (± 0.43%) +0.01s (+ 0.25%) 4.45s 4.51s
Total Time 16.59s (± 0.27%) 16.61s (± 0.17%) +0.02s (+ 0.13%) 16.57s 16.65s
TFS - node (v16.17.1, x64)
Memory used 309,205k (± 0.00%) 309,203k (± 0.01%) -2k (- 0.00%) 309,181k 309,237k
Parse Time 2.62s (± 1.52%) 2.61s (± 1.15%) -0.01s (- 0.51%) 2.57s 2.65s
Bind Time 1.05s (± 1.89%) 1.06s (± 1.45%) +0.00s (+ 0.34%) 1.04s 1.08s
Check Time 7.38s (± 0.55%) 7.40s (± 0.47%) +0.02s (+ 0.32%) 7.35s 7.44s
Emit Time 4.21s (± 0.43%) 4.22s (± 0.85%) +0.01s (+ 0.18%) 4.16s 4.25s
Total Time 15.26s (± 0.34%) 15.28s (± 0.48%) +0.03s (+ 0.17%) 15.20s 15.36s
material-ui - node (v16.17.1, x64)
Memory used 484,295k (± 0.00%) 489,652k (± 0.00%) +5,357k (+ 1.11%) 489,634k 489,697k
Parse Time 3.67s (± 0.34%) 3.83s (± 0.46%) +0.16s (+ 4.35%) 3.81s 3.85s
Bind Time 1.01s (± 0.37%) 1.01s (± 0.84%) -0.00s (- 0.42%) 0.99s 1.02s
Check Time 17.83s (± 0.35%) 17.91s (± 0.33%) +0.07s (+ 0.42%) 17.82s 17.98s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.52s (± 0.31%) 22.75s (± 0.31%) +0.24s (+ 1.04%) 22.63s 22.83s
xstate - node (v16.17.1, x64)
Memory used 567,234k (± 0.01%) 568,777k (± 0.02%) +1,543k (+ 0.27%) 568,704k 569,035k
Parse Time 4.74s (± 0.43%) 4.77s (± 1.51%) +0.03s (+ 0.70%) 4.68s 4.85s
Bind Time 1.65s (± 0.53%) 1.68s (± 2.58%) +0.02s (+ 1.50%) 1.64s 1.75s
Check Time 2.82s (± 0.44%) 2.82s (± 0.47%) -0.00s (- 0.08%) 2.79s 2.83s
Emit Time 0.08s (± 6.40%) 0.09s (± 4.52%) +0.01s (+ 7.96%) 0.09s 0.10s
Total Time 9.30s (± 0.27%) 9.36s (± 0.64%) +0.05s (+ 0.58%) 9.26s 9.43s
Angular - node (v14.15.1, x64)
Memory used 365,247k (± 0.01%) 366,996k (± 0.01%) +1,748k (+ 0.48%) 366,954k 367,042k
Parse Time 4.14s (± 0.49%) 4.21s (± 0.28%) +0.07s (+ 1.69%) 4.20s 4.23s
Bind Time 1.31s (± 1.20%) 1.29s (± 0.71%) -0.01s (- 1.02%) 1.28s 1.30s
Check Time 9.61s (± 0.33%) 9.58s (± 0.53%) -0.03s (- 0.29%) 9.52s 9.65s
Emit Time 8.21s (± 1.34%) 8.22s (± 0.46%) +0.01s (+ 0.10%) 8.15s 8.27s
Total Time 23.27s (± 0.59%) 23.31s (± 0.23%) +0.04s (+ 0.16%) 23.20s 23.36s
Compiler-Unions - node (v14.15.1, x64)
Memory used 194,950k (± 0.02%) 194,941k (± 0.01%) -9k (- 0.00%) 194,903k 194,990k
Parse Time 1.84s (± 0.58%) 1.84s (± 0.43%) +0.01s (+ 0.40%) 1.83s 1.85s
Bind Time 0.87s (± 0.64%) 0.87s (± 0.57%) -0.00s (- 0.16%) 0.87s 0.88s
Check Time 10.09s (± 0.71%) 10.09s (± 0.84%) -0.01s (- 0.05%) 10.00s 10.21s
Emit Time 3.12s (± 0.84%) 3.11s (± 0.92%) -0.01s (- 0.34%) 3.07s 3.16s
Total Time 15.93s (± 0.52%) 15.91s (± 0.68%) -0.01s (- 0.08%) 15.79s 16.05s
Monaco - node (v14.15.1, x64)
Memory used 348,061k (± 0.01%) 348,065k (± 0.01%) +4k (+ 0.00%) 348,046k 348,095k
Parse Time 3.25s (± 1.02%) 3.25s (± 0.61%) -0.00s (- 0.14%) 3.22s 3.27s
Bind Time 1.12s (± 0.58%) 1.12s (± 0.76%) +0.00s (+ 0.17%) 1.11s 1.13s
Check Time 8.13s (± 0.61%) 8.15s (± 0.18%) +0.02s (+ 0.25%) 8.13s 8.17s
Emit Time 4.69s (± 0.61%) 4.70s (± 0.30%) +0.01s (+ 0.13%) 4.68s 4.72s
Total Time 17.19s (± 0.20%) 17.21s (± 0.24%) +0.03s (+ 0.15%) 17.14s 17.25s
TFS - node (v14.15.1, x64)
Memory used 304,124k (± 0.00%) 304,119k (± 0.01%) -5k (- 0.00%) 304,095k 304,153k
Parse Time 2.72s (± 0.50%) 2.71s (± 0.84%) -0.01s (- 0.37%) 2.68s 2.74s
Bind Time 1.08s (± 0.85%) 1.08s (± 0.68%) +0.00s (+ 0.09%) 1.08s 1.09s
Check Time 7.72s (± 0.61%) 7.73s (± 0.66%) +0.01s (+ 0.08%) 7.65s 7.80s
Emit Time 4.53s (± 0.58%) 4.56s (± 0.92%) +0.04s (+ 0.78%) 4.50s 4.62s
Total Time 16.05s (± 0.39%) 16.09s (± 0.37%) +0.04s (+ 0.22%) 15.99s 16.17s
material-ui - node (v14.15.1, x64)
Memory used 479,789k (± 0.00%) 485,010k (± 0.00%) +5,221k (+ 1.09%) 484,980k 485,036k
Parse Time 3.88s (± 0.52%) 3.95s (± 0.55%) +0.07s (+ 1.68%) 3.92s 3.98s
Bind Time 1.05s (± 0.84%) 1.04s (± 1.55%) -0.00s (- 0.37%) 1.03s 1.07s
Check Time 18.90s (± 0.72%) 18.99s (± 0.90%) +0.09s (+ 0.49%) 18.80s 19.30s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 23.83s (± 0.58%) 23.98s (± 0.68%) +0.15s (+ 0.64%) 23.78s 24.26s
xstate - node (v14.15.1, x64)
Memory used 555,585k (± 0.00%) 557,136k (± 0.01%) +1,551k (+ 0.28%) 557,089k 557,166k
Parse Time 5.12s (± 0.92%) 5.20s (± 0.82%) +0.08s (+ 1.56%) 5.15s 5.27s
Bind Time 1.58s (± 0.64%) 1.59s (± 0.71%) +0.01s (+ 0.55%) 1.58s 1.61s
Check Time 2.98s (± 0.86%) 2.98s (± 0.81%) +0.00s (+ 0.02%) 2.95s 3.02s
Emit Time 0.10s (± 0.21%) 0.10s (± 0.16%) +0.00s (+ 0.13%) 0.10s 0.10s
Total Time 9.79s (± 0.54%) 9.88s (± 0.50%) +0.09s (+ 0.90%) 9.81s 9.92s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51973 6
Baseline main 6

TSServer

Comparison Report - main..51973
Metric main 51973 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,540ms (± 1.78%) 2,543ms (± 1.87%) +3ms (+ 0.12%) 2,482ms 2,627ms
Req 2 - geterr 5,626ms (± 0.84%) 5,653ms (± 1.07%) +27ms (+ 0.47%) 5,577ms 5,730ms
Req 3 - references 356ms (± 0.81%) 360ms (± 1.55%) +4ms (+ 1.13%) 356ms 370ms
Req 4 - navto 291ms (± 1.43%) 289ms (± 2.14%) -2ms (- 0.67%) 283ms 300ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 83ms (± 6.96%) 81ms (± 8.32%) -2ms (- 2.03%) 72ms 88ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,748ms (± 0.60%) 2,725ms (± 1.15%) -23ms (- 0.84%) 2,688ms 2,762ms
Req 2 - geterr 4,150ms (± 0.73%) 4,156ms (± 0.56%) +7ms (+ 0.16%) 4,119ms 4,188ms
Req 3 - references 362ms (± 1.50%) 357ms (± 0.81%) -5ms (- 1.33%) 354ms 362ms
Req 4 - navto 293ms (± 1.07%) 293ms (± 0.54%) -0ms (- 0.16%) 291ms 294ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 66ms (± 1.86%) 67ms (± 1.70%) +1ms (+ 1.05%) 65ms 68ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,597ms (± 0.30%) 3,611ms (± 1.13%) +14ms (+ 0.38%) 3,558ms 3,653ms
Req 2 - geterr 1,312ms (± 1.55%) 1,311ms (± 1.24%) -1ms (- 0.07%) 1,298ms 1,342ms
Req 3 - references 103ms (± 3.67%) 106ms (± 2.85%) +3ms (+ 2.95%) 101ms 109ms
Req 4 - navto 356ms (± 2.58%) 354ms (± 1.46%) -2ms (- 0.64%) 347ms 362ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 426ms (± 2.50%) 427ms (± 1.74%) +1ms (+ 0.26%) 417ms 436ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,759ms (± 0.87%) 2,763ms (± 0.56%) +4ms (+ 0.14%) 2,739ms 2,780ms
Req 2 - geterr 6,058ms (± 0.73%) 6,063ms (± 0.36%) +5ms (+ 0.08%) 6,038ms 6,100ms
Req 3 - references 362ms (± 0.67%) 364ms (± 0.98%) +1ms (+ 0.34%) 361ms 370ms
Req 4 - navto 275ms (± 0.74%) 278ms (± 1.14%) +3ms (+ 1.11%) 275ms 284ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 83ms (± 6.69%) 82ms (± 8.55%) -1ms (- 0.63%) 75ms 95ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,896ms (± 0.49%) 2,907ms (± 0.47%) +11ms (+ 0.39%) 2,889ms 2,930ms
Req 2 - geterr 4,493ms (± 0.50%) 4,493ms (± 0.50%) +0ms (+ 0.00%) 4,459ms 4,518ms
Req 3 - references 384ms (± 0.48%) 383ms (± 0.45%) -1ms (- 0.21%) 382ms 386ms
Req 4 - navto 292ms (± 1.04%) 293ms (± 1.75%) +0ms (+ 0.11%) 289ms 300ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 73ms (± 4.63%) 75ms (± 3.55%) +1ms (+ 1.82%) 69ms 76ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,749ms (± 0.24%) 3,721ms (± 0.50%) -28ms (- 0.75%) 3,696ms 3,742ms
Req 2 - geterr 1,430ms (± 1.87%) 1,447ms (± 1.22%) +16ms (+ 1.15%) 1,426ms 1,479ms
Req 3 - references 108ms (± 1.12%) 111ms (± 2.71%) +3ms (+ 2.38%) 106ms 115ms
Req 4 - navto 349ms (± 0.76%) 342ms (± 1.21%) -7ms (- 1.91%) 335ms 347ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 455ms (± 0.66%) 459ms (± 1.97%) +4ms (+ 0.96%) 453ms 471ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,038ms (± 0.59%) 3,048ms (± 0.30%) +10ms (+ 0.32%) 3,038ms 3,063ms
Req 2 - geterr 5,901ms (± 0.71%) 5,906ms (± 0.92%) +5ms (+ 0.09%) 5,852ms 5,980ms
Req 3 - references 389ms (± 0.44%) 390ms (± 0.58%) +1ms (+ 0.20%) 387ms 394ms
Req 4 - navto 288ms (± 0.76%) 287ms (± 1.00%) -0ms (- 0.15%) 285ms 293ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 83ms (± 1.85%) 82ms (± 2.09%) -1ms (- 1.11%) 79ms 83ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,192ms (± 1.00%) 3,181ms (± 0.26%) -11ms (- 0.36%) 3,170ms 3,194ms
Req 2 - geterr 4,411ms (± 0.46%) 4,400ms (± 0.73%) -12ms (- 0.26%) 4,348ms 4,435ms
Req 3 - references 406ms (± 0.70%) 402ms (± 0.59%) -3ms (- 0.80%) 399ms 406ms
Req 4 - navto 307ms (± 1.73%) 307ms (± 1.99%) -0ms (- 0.05%) 294ms 311ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 80ms (± 6.59%) 80ms (± 5.71%) -0ms (- 0.18%) 76ms 87ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,774ms (± 0.46%) 3,801ms (± 0.39%) +27ms (+ 0.72%) 3,790ms 3,827ms
Req 2 - geterr 1,471ms (± 1.47%) 1,465ms (± 1.28%) -5ms (- 0.35%) 1,449ms 1,500ms
Req 3 - references 130ms (± 1.24%) 131ms (± 1.43%) +1ms (+ 0.62%) 129ms 134ms
Req 4 - navto 393ms (± 0.62%) 384ms (± 1.01%) -9ms (- 2.20%) 379ms 389ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 496ms (± 1.21%) 488ms (± 1.94%) -8ms (- 1.58%) 475ms 496ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51973 6
Baseline main 6

Startup

Comparison Report - main..51973
Metric main 51973 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 140.18ms (± 0.50%) 137.80ms (± 0.22%) -2.38ms (- 1.70%) 136.62ms 140.09ms
tsserver-startup - node (v16.17.1, x64)
Execution time 220.90ms (± 0.19%) 221.22ms (± 0.18%) +0.32ms (+ 0.15%) 219.80ms 226.09ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 223.38ms (± 0.23%) 222.59ms (± 0.17%) -0.78ms (- 0.35%) 221.28ms 227.39ms
typescript-startup - node (v16.17.1, x64)
Execution time 206.55ms (± 0.18%) 206.37ms (± 0.19%) -0.18ms (- 0.09%) 205.21ms 214.44ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51973 6
Baseline main 6

Developer Information:

Download Benchmark

@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Dec 22, 2022
Merged
@andrewbranch

Andrew Branch (andrewbranch) commented Dec 22, 2022

Copy link
Copy Markdown
Member Author

Brought in #51995

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 22, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test top 100

@andrewbranch

Andrew Branch (andrewbranch) commented Dec 22, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test top100

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the diff-based top-repos suite on this PR at 6ba17c8. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch) Here are the results of running the top-repos suite comparing main and refs/pull/51973/merge:

Something interesting changed - please have a look.

Details

appsmithorg/appsmith

3 of 4 projects failed to build with the old tsc and were ignored

app/shared/ast/tsconfig.json

conwnet/github1s

2 of 4 projects failed to build with the old tsc and were ignored

tests/tsconfig.json

Eugeny/tabby

19 of 29 projects failed to build with the old tsc and were ignored

app/tsconfig.main.json

  • error TS5099: Import assignment is not allowed when 'moduleResolution' is set to 'bundler'. Consider using 'import * as ns from "mod"', 'import {a} from "mod"', 'import d from "mod"', or another module format instead.

excalidraw/excalidraw

2 of 5 projects failed to build with the old tsc and were ignored

tsconfig-types.json

tsconfig.json

lensapp/lens

2 of 4 projects failed to build with the old tsc and were ignored

build/tsconfig.json

integration/tsconfig.json

palantir/blueprint

4 of 27 projects failed to build with the old tsc and were ignored

packages/datetime2/src/tsconfig.json

packages/datetime2/test/tsconfig.json

Redocly/redoc

tsconfig.json

  • error TS2345: Argument of type '{ openapi: string; info: { version: string; title: string; }; components: { callbacks: { Test: { "/test": { post: { operationId: string; description: string; requestBody: { content: { "application/json": { schema: { ...; }; }; }; }; parameters: { ...; }[]; responses: { ...; }; }; }; }; }; }; }' is not assignable to parameter of type 'OpenAPISpec'.
  • error TS2345: Argument of type '{ openapi: string; components: { schemas: { Pet: { type: string; required: string[]; discriminator: { propertyName: string; }; properties: { type: { type: string; }; }; }; Dog: { type: string; allOf: { $ref: string; }[]; properties: { ...; }; }; Cat: { ...; }; }; }; }' is not assignable to parameter of type 'OpenAPISpec'.
  • error TS2345: Argument of type '{ openapi: string; info: { title: string; version: string; }; paths: { "/pet": { put: { summary: string; description: string; operationId: string; responses: { "405": { description: string; }; }; security: ({ GitLab_PersonalAccessToken: never[]; GitLab_OpenIdConnect: never[]; basicAuth: never[]; petstore_auth?: unde...' is not assignable to parameter of type 'OpenAPISpec'.

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS7016: Could not find a declaration file for module 'form-data-encoder'. '/mnt/ts_downloads/hyper/node_modules/form-data-encoder/lib/index.js' implicitly has an 'any' type.
    • file:///mnt/ts_downloads/hyper/node_modules/got/dist/source/core/options.d.ts#L22 in tsconfig.json

youzan/vant

4 of 10 projects failed to build with the old tsc and were ignored

packages/vant-cli/site/tsconfig.json

  • error TS7016: Could not find a declaration file for module 'highlight.js'. '/mnt/ts_downloads/vant/node_modules/.pnpm/highlight.js@11.6.0/node_modules/highlight.js/es/index.js' implicitly has an 'any' type.
  • error TS7016: Could not find a declaration file for module 'vite-plugin-md'. '/mnt/ts_downloads/vant/node_modules/.pnpm/vite-plugin-md@0.11.9_vite@3.1.8/node_modules/vite-plugin-md/dist/index.mjs' implicitly has an 'any' type.

packages/vant-cli/tsconfig.json

  • error TS7016: Could not find a declaration file for module 'highlight.js'. '/mnt/ts_downloads/vant/node_modules/.pnpm/highlight.js@11.6.0/node_modules/highlight.js/es/index.js' implicitly has an 'any' type.
  • error TS7016: Could not find a declaration file for module 'vite-plugin-md'. '/mnt/ts_downloads/vant/node_modules/.pnpm/vite-plugin-md@0.11.9_vite@3.1.8/node_modules/vite-plugin-md/dist/index.mjs' implicitly has an 'any' type.

@andrewbranch

Andrew Branch (andrewbranch) commented Jan 9, 2023

Copy link
Copy Markdown
Member Author

Ok, so the rest of these errors all have a common cause, and they are strictly correct, though I didn’t foresee this problem being so pervasive. Each of these errors is caused by an incorrectly configured npm dependency that would also occur under --module nodenext in a "type": "module" context. They all list an "import" entrypoint for ESM consumers that is untyped (probably expecting that their single .d.ts file applies both to their .js and their .mjs entrypoint).

Essentially, this is just an extension of the problem we knew we’d face with nodenext of getting npm libraries ready for TypeScript support, but the rate that we will find offenders under bundler is greater than under nodenext, because bundler does not require a "type": "module" package.json context or a .mts file extension in order to try to load "import" entrypoints.

I’m not sure there’s much to do here other than:

  1. Resume our efforts to fix popular dependencies as we find them (the ones listed above make a good start)
  2. Improve error messages for this case (something we’ve talked about doing in nodenext but had not gotten around to)

@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Jan 9, 2023
Merged
@andrewbranch

Andrew Branch (andrewbranch) commented Jan 10, 2023

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test top100

@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the diff-based top-repos suite on this PR at 6b1da23. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch) Here are the results of running the top-repos suite comparing main and refs/pull/51973/merge:

Something interesting changed - please have a look.

Details

appsmithorg/appsmith

3 of 4 projects failed to build with the old tsc and were ignored

app/shared/ast/tsconfig.json

conwnet/github1s

2 of 4 projects failed to build with the old tsc and were ignored

tests/tsconfig.json

Eugeny/tabby

19 of 29 projects failed to build with the old tsc and were ignored

app/tsconfig.main.json

  • error TS5099: Import assignment is not allowed when 'moduleResolution' is set to 'bundler'. Consider using 'import * as ns from "mod"', 'import {a} from "mod"', 'import d from "mod"', or another module format instead.

excalidraw/excalidraw

2 of 5 projects failed to build with the old tsc and were ignored

tsconfig-types.json

tsconfig.json

lensapp/lens

2 of 4 projects failed to build with the old tsc and were ignored

build/tsconfig.json

integration/tsconfig.json

microsoft/vscode

4 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

palantir/blueprint

4 of 27 projects failed to build with the old tsc and were ignored

packages/datetime2/src/tsconfig.json

packages/datetime2/test/tsconfig.json

Redocly/redoc

tsconfig.json

  • error TS2345: Argument of type '{ openapi: string; info: { version: string; title: string; }; components: { callbacks: { Test: { "/test": { post: { operationId: string; description: string; requestBody: { content: { "application/json": { schema: { ...; }; }; }; }; parameters: { ...; }[]; responses: { ...; }; }; }; }; }; }; }' is not assignable to parameter of type 'OpenAPISpec'.
  • error TS2345: Argument of type '{ openapi: string; components: { schemas: { Pet: { type: string; required: string[]; discriminator: { propertyName: string; }; properties: { type: { type: string; }; }; }; Dog: { type: string; allOf: { $ref: string; }[]; properties: { ...; }; }; Cat: { ...; }; }; }; }' is not assignable to parameter of type 'OpenAPISpec'.
  • error TS2345: Argument of type '{ openapi: string; info: { title: string; version: string; }; paths: { "/pet": { put: { summary: string; description: string; operationId: string; responses: { "405": { description: string; }; }; security: ({ GitLab_PersonalAccessToken: never[]; GitLab_OpenIdConnect: never[]; basicAuth: never[]; petstore_auth?: unde...' is not assignable to parameter of type 'OpenAPISpec'.

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS7016: Could not find a declaration file for module '../lib'. '/mnt/ts_downloads/hyper/node_modules/@react-icons/all-files/lib/cjs/index.js' implicitly has an 'any' type.
    • file:///mnt/ts_downloads/hyper/node_modules/@react-icons/all-files/vsc/VscArrowUp.d.ts#L2 in tsconfig.json
    • file:///mnt/ts_downloads/hyper/node_modules/@react-icons/all-files/vsc/VscArrowDown.d.ts#L2 in tsconfig.json
    • file:///mnt/ts_downloads/hyper/node_modules/@react-icons/all-files/vsc/VscClose.d.ts#L2 in tsconfig.json
    • file:///mnt/ts_downloads/hyper/node_modules/@react-icons/all-files/vsc/VscCaseSensitive.d.ts#L2 in tsconfig.json
    • file:///mnt/ts_downloads/hyper/node_modules/@react-icons/all-files/vsc/VscRegex.d.ts#L2 in tsconfig.json
    • file:///mnt/ts_downloads/hyper/node_modules/@react-icons/all-files/vsc/VscWholeWord.d.ts#L2 in tsconfig.json
  • error TS7016: Could not find a declaration file for module 'form-data-encoder'. '/mnt/ts_downloads/hyper/node_modules/form-data-encoder/lib/index.js' implicitly has an 'any' type.
    • file:///mnt/ts_downloads/hyper/node_modules/got/dist/source/core/options.d.ts#L22 in tsconfig.json

youzan/vant

4 of 10 projects failed to build with the old tsc and were ignored

packages/vant-cli/site/tsconfig.json

  • error TS7016: Could not find a declaration file for module 'highlight.js'. '/mnt/ts_downloads/vant/node_modules/.pnpm/highlight.js@11.6.0/node_modules/highlight.js/es/index.js' implicitly has an 'any' type.
  • error TS7016: Could not find a declaration file for module 'vite-plugin-md'. '/mnt/ts_downloads/vant/node_modules/.pnpm/vite-plugin-md@0.11.9_vite@4.0.3/node_modules/vite-plugin-md/dist/index.mjs' implicitly has an 'any' type.

packages/vant-cli/tsconfig.json

  • error TS7016: Could not find a declaration file for module 'highlight.js'. '/mnt/ts_downloads/vant/node_modules/.pnpm/highlight.js@11.6.0/node_modules/highlight.js/es/index.js' implicitly has an 'any' type.
  • error TS7016: Could not find a declaration file for module 'vite-plugin-md'. '/mnt/ts_downloads/vant/node_modules/.pnpm/vite-plugin-md@0.11.9_vite@4.0.3/node_modules/vite-plugin-md/dist/index.mjs' implicitly has an 'any' type.

@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Jan 10, 2023
Merged
@Jack-Works

Jack Works (Jack-Works) commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Ok, so the rest of these errors all have a common cause, and they are strictly correct, though I didn’t foresee this problem being so pervasive. Each of these errors is caused by an incorrectly configured npm dependency that would also occur under --module nodenext in a "type": "module" context. They all list an "import" entrypoint for ESM consumers that is untyped (probably expecting that their single .d.ts file applies both to their .js and their .mjs entrypoint).

I have pointed out this problem in #50466

Closed
@andrewbranch
Andrew Branch (andrewbranch) deleted the try-bundler branch January 23, 2023 18:13
@shadowspawn John Gee (shadowspawn) mentioned this pull request May 11, 2023
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewbranch @typescript-bot @DanielRosenwasser @Jack-Works