Skip to content

Set impliedNodeFormat on sourceFile we get from host to ensure the field is set correctly - #50977

Merged
Sheetal Nandi (sheetalkamat) merged 8 commits into
mainfrom
tsBuildImpliedNodeFormat
Oct 31, 2022
Merged

Set impliedNodeFormat on sourceFile we get from host to ensure the field is set correctly#50977
Sheetal Nandi (sheetalkamat) merged 8 commits into
mainfrom
tsBuildImpliedNodeFormat

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Sep 27, 2022

Copy link
Copy Markdown
Member

This fixes issue with using same source file between two programs when impliedNodeFormat was different in tsbuild mode.
Fixes #50872

@typescript-bot TypeScript Bot (typescript-bot) added the For Milestone Bug PRs that fix a bug with a specific milestone label Sep 27, 2022
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes Sep 28, 2022
View reviewed changes
Comment thread src/harness/virtualFileSystemWithWatch.ts
Comment thread src/testRunner/unittests/tsbuild/moduleResolution.ts
@sheetalkamat Sheetal Nandi (sheetalkamat) changed the title Use impliedNodeFormat as key during caching sourceFiles Set impliedNodeFormat on sourceFile we get from host to ensure the field is set correctly Sep 28, 2022
weswigham
Wesley Wigham (weswigham) reviewed Sep 28, 2022
View reviewed changes
Comment thread src/compiler/program.ts Outdated
weswigham
Wesley Wigham (weswigham) reviewed Sep 28, 2022
View reviewed changes
Comment thread src/compiler/program.ts Outdated
amcasey
Andrew Casey (amcasey) approved these changes Oct 31, 2022
View reviewed changes
Comment thread src/compiler/program.ts Outdated
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the tsBuildImpliedNodeFormat branch October 31, 2022 18:26
@DanielRosenwasser

ghost commented Oct 31, 2022

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) cherry-pick this to release-4.9

@typescript-bot

ghost commented Oct 31, 2022 •
edited by typescript-bot
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-4.9 on this PR at 4bd8b9b. You can monitor the build here.

@typescript-bot

ghost commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #51363 for you.

Merged
@DanielRosenwasser

ghost commented Oct 31, 2022

Copy link
Copy Markdown
Member

I don't know if this will work after-the-fact but

TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test tsserver top100

@typescript-bot

ghost commented Oct 31, 2022 •
edited by typescript-bot
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite (tsserver) on this PR at 4bd8b9b. You can monitor the build here.

@typescript-bot

ghost commented Oct 31, 2022 •
edited by typescript-bot
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based top-repos suite (tsserver) on this PR at 4bd8b9b. You can monitor the build here.

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
@weswigham Wesley Wigham (weswigham) Awaiting requested review from weswigham
+1 more reviewer
@amcasey Andrew Casey (amcasey) amcasey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sheetalkamat Sheetal Nandi (sheetalkamat)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect tsc --build compilation that is dependent on project references (using NPM workspaces)

6 participants

@sheetalkamat @DanielRosenwasser @typescript-bot @weswigham @amcasey @sandersn