Defer distributing index over generic object types - #50540
Merged
Anders Hejlsberg (ahejlsberg) merged 3 commits intoSep 1, 2022
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
This was referenced Aug 30, 2022
Member
|
TypeScript Bot (@typescript-bot) test this |
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite on this PR at 00e3926. You can monitor the build here. Update: The results are in! |
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at 00e3926. You can monitor the build here. |
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at 00e3926. You can monitor the build here. Update: The results are in! |
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized Definitely Typed test suite on this PR at 00e3926. You can monitor the build here. |
Contributor
|
Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the user test suite comparing Everything looks good! |
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
Contributor
|
Daniel Rosenwasser (@DanielRosenwasser) Here they are:
CompilerComparison Report - main..50540
System
Hosts
Scenarios
TSServerComparison Report - main..50540
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
|
TypeScript Bot (@typescript-bot) test top100 |
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite on this PR at 00e3926. You can monitor the build here. |
Member
|
Daniel Rosenwasser (@DanielRosenwasser) Nathan Shively-Sanders (@sandersn) Looks like the top100 test is bombing out in one of the processes. Same issue over in #50535. |
Anders Hejlsberg (ahejlsberg)
left a comment
Anders Hejlsberg (ahejlsberg)
left a comment
Member
There was a problem hiding this comment.
This change makes sense, but I'd prefer reducing the scope a bit as suggested here.
Comment on lines
+15906
to
+15908
| if (shouldDeferIndexType(objectType)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Remove this.
| } | ||
| // (T | U)[K] -> T[K] | U[K] (reading) | ||
| // (T | U)[K] -> T[K] & U[K] (writing) | ||
| // (T & U)[K] -> T[K] & U[K] |
There was a problem hiding this comment.
Change the following line to:
if (objectType.flags & TypeFlags.Union || objectType.Flags & TypeFlags.Intersection && !shouldDeferIndexType(objectType)) ...There was a problem hiding this comment.
I'm concerned that shouldDeferIndexType will also do (possibly expensive) work for union types, so I'd prefer only deferring for intersection types.
Mateusz Burzyński (Andarist)
requested a review
from Anders Hejlsberg (ahejlsberg)
August 31, 2022 05:51
TypeScript Bot (typescript-bot)
added
For Milestone Bug
Contributor
Author
|
Anders Hejlsberg (@ahejlsberg) I've applied the suggested change and rerun the test suite locally - everything looks OK on this front, somebody from the TS team has to start new perf tests though. |
Member
|
TypeScript Bot (@typescript-bot) perf test this my liege |
Contributor
|
Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 2ba9ff1. You can monitor the build here. Update: The results are in! |
Contributor
|
Jake Bailey (@jakebailey) Here they are:
CompilerComparison Report - main..50540
System
Hosts
Scenarios
TSServerComparison Report - main..50540
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
|
TypeScript Bot (@typescript-bot) test this |
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at 2ba9ff1. You can monitor the build here. |
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 2ba9ff1. You can monitor the build here. |
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at 2ba9ff1. You can monitor the build here. Update: The results are in! |
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 2ba9ff1. You can monitor the build here. |
Contributor
|
Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing Everything looks good! |
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
Mateusz Burzyński (Andarist)
force-pushed
the
defer-distribution-index-over-object-type
branch
from
September 1, 2022 10:55
ae87342 to
873dfea
Compare
Anders Hejlsberg (ahejlsberg)
approved these changes
Sep 1, 2022
Mateusz Burzyński (Andarist)
deleted the
defer-distribution-index-over-object-type
branch
September 1, 2022 14:30
Contributor
Author
|
Anders Hejlsberg (@ahejlsberg) should this perhaps be cherry-picked into the 4.8 release? |
Member
|
Mateusz Burzyński (@Andarist) Yup, it's already on the list. |
Member
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-4.8 |
Contributor
|
Heya Andrew Branch (@andrewbranch), I've started to run the task to cherry-pick this into |
Contributor
|
Hey Andrew Branch (@andrewbranch), I've opened #50588 for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50539
cc Anders Hejlsberg (@ahejlsberg) , the
shouldDeferIndexTypecheck has been introduced based on the changes in this PR: https://github.com/microsoft/TypeScript/pull/49696/files