Skip to content

Properly re-scan > token in type argument list determination logic - #49560

Merged
Anders Hejlsberg (ahejlsberg) merged 2 commits into
mainfrom
fix49551
Jun 15, 2022
Merged

Properly re-scan > token in type argument list determination logic#49560
Anders Hejlsberg (ahejlsberg) merged 2 commits into
mainfrom
fix49551

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Jun 15, 2022

Copy link
Copy Markdown
Member

Fixes #49551.

@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 15, 2022
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jun 15, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at f1f6af8. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at f1f6af8. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at f1f6af8. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

Anders Hejlsberg (@ahejlsberg)
Great news! no new errors were found between main..refs/pull/49560/merge

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jun 15, 2022

Copy link
Copy Markdown
Member

Should we cherry-pick this? Feels bad to have in 4.7.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jun 15, 2022

Copy link
Copy Markdown
Member Author

Should we cherry-pick this? Feels bad to have in 4.7.

Yeah, I'd be in favor of cherry-picking.

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jun 15, 2022

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) cherry-pick this to release-4.7

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-4.7 on this PR at f1f6af8. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.7 manually.

Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Jun 15, 2022
@DanielRosenwasser
Properly re-scan > token in type argument list determination logic (#…
67058d9 
…49560)

* Properly re-scan '>' token in type argument list determination logic

* Add regression test
Merged
Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Jun 16, 2022
@DanielRosenwasser
Properly re-scan > token in type argument list determination logic (#…
dfe885b 
…49560) (#49570)

* Properly re-scan '>' token in type argument list determination logic

* Add regression test
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) RyanCavanaugh approved these changes

Assignees

@ahejlsberg Anders Hejlsberg (ahejlsberg)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

TypeScript 4.7.4

Development

Successfully merging this pull request may close these issues.

Unexpected syntax errors of a < (b >= c ...) in TS 4.7

5 participants

@ahejlsberg @typescript-bot @DanielRosenwasser @RyanCavanaugh @andrewbranch