Handle the case where the FAR results map is empty - #49254
Merged
Conversation
Searching exactly one project does not imply the presence of exactly one references list. Fixes microsoft#49217
Andrew Casey (amcasey)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
May 26, 2022 01:24
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Member
Author
|
Daniel Rosenwasser (@DanielRosenwasser) I'm wondering if my previous repro attempts had multiple projects open and, therefore, bypassed the fast path. |
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
May 26, 2022
Member
|
To be honest, I wonder if this is actually that much faster/simpler for the caller (I didn't look), but the fix here is small and reasonable |
Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
Sheetal Nandi (sheetalkamat)
approved these changes
May 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching exactly one project does not imply the presence of exactly one references list.
Fixes #49217