Tidy up navto and find-file-references - #48106
Merged
Merged
Conversation
They were using the same helpers as FAR and rename, but they actually behave differently. Decoupling them helps avoid some unnecessary work and will make it easier to clean up FAR in the future. Scoping NavTo results to a single project (rather than, e.g. all loaded projects) makes the behavior more logical and the implementation simpler.
Andrew Casey (amcasey)
requested review from
Andrew Branch (andrewbranch) and
Nathan Shively-Sanders (sandersn)
March 3, 2022 18:13
TypeScript Bot (typescript-bot)
assigned
Andrew Casey (amcasey) and unassigned
Andrew Casey (amcasey)
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Andrew Branch (andrewbranch)
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were using the same helpers as FAR and rename, but they actually behave differently. Decoupling them helps avoid some unnecessary work and will make it easier to clean up FAR in the future.
Scoping NavTo results to a single project (rather than, e.g. all loaded projects) makes the behavior more logical and the implementation simpler.