fix(47794): Fix incorrect substitution on index access on generic mapped type with key remapping - #47837
Closed
Gabrielle Langer (LANGERGabrielle) wants to merge 1 commit into
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
|
|
Gabrielle Langer (LANGERGabrielle)
force-pushed
the
fixed-generic-access-index-on-generic-mapped-type-with-key-remapping
branch
from
February 10, 2022 21:29
f37e783 to
49024cb
Compare
…ith key remapping
Gabrielle Langer (LANGERGabrielle)
force-pushed
the
fixed-generic-access-index-on-generic-mapped-type-with-key-remapping
branch
from
February 10, 2022 21:32
49024cb to
481882c
Compare
Ryan Cavanaugh (RyanCavanaugh)
requested review from
Anders Hejlsberg (ahejlsberg) and
Wesley Wigham (weswigham)
February 10, 2022 21:36
Anders Hejlsberg (ahejlsberg)
left a comment
Anders Hejlsberg (ahejlsberg)
left a comment
Member
There was a problem hiding this comment.
Unfortunately, this fix isn't correct. We shouldn't be calling substituteIndexedMappedType for mapped types with as clauses (see explanation here), and the proper fix is to ensure that doesn't happen. I can put up a PR to that effect.
Gabrielle Langer (LANGERGabrielle)
requested a review
from Anders Hejlsberg (ahejlsberg)
February 21, 2022 10:18
TypeScript Bot (typescript-bot)
added
For Milestone Bug
Member
|
See also #47889 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47794