Add Intl.Locale parameter type to toLocale[X]String signatures. - #47811
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoFeb 28, 2022
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
jihndai (jihndai)
force-pushed
the
issue/47802
branch
from
February 9, 2022 17:50
9eab5a0 to
ee4a412
Compare
Nathan Shively-Sanders (sandersn)
requested review from
Jake Bailey (jakebailey) and
Nathan Shively-Sanders (sandersn)
February 24, 2022 18:57
jihndai (jihndai)
force-pushed
the
issue/47802
branch
from
February 28, 2022 04:55
ee4a412 to
d6e4408
Compare
Jake Bailey (jakebailey)
left a comment
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
This seems correct to me, though I think this is the first time the Intl types are being used outside of the intl file itself (besides those defined in es5).
Nathan Shively-Sanders (sandersn)
approved these changes
Feb 28, 2022
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
This file structure looks to me like it will work. Let's try it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47802