Fix inference for generic-typed constructor parameter when no explicit constructor is present - #47750
Merged
Merged
Conversation
|
|
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
jihndai (jihndai)
force-pushed
the
issue/47340
branch
from
February 8, 2022 01:29
f196a42 to
0d5b019
Compare
Nathan Shively-Sanders (sandersn)
requested review from
Gabriela Araujo Britto (gabritto) and
Wesley Wigham (weswigham)
February 15, 2022 21:19
Member
|
TypeScript Bot (@typescript-bot) user test this inline |
Contributor
|
Heya Wesley Wigham (@weswigham), I've started to run the diff-based community code test suite on this PR at 0d5b019. You can monitor the build here. Update: The results are in! |
Contributor
|
Wesley Wigham (@weswigham) |
Member
|
Hm, happy to take this as the fix, I guess. I feel like somehow fixing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class doesn't have an explicitly defined constructor, the class's default construct signature will have an undefined value in its
declarationproperty. The issue then lies in the functiongetOrCreateTypeFromSignature: when the signature'sdeclarationproperty is undefined, it would assume that it is a call signature instead of a construct signature.For the fix, I think it would be safer to assume that the signature is a construct signature whenever
declarationis undefined, as I couldn't find a scenario where a call signature would get passed togetOrCreateTypeFromSignaturewith an undefined value indeclaration.Fixes #47340