Fix Awaited<T> for onfulfilled callbacks with more than one argument by rbuckton · Pull Request #46951 · microsoft/TypeScript

Ron Buckton (rbuckton) · 2021-11-30T05:48:43Z

This adds a rest argument to the inference for the onfulfilled callback to support Promise subtypes that provide more than one argument.

Fixes #46934

Daniel Rosenwasser (DanielRosenwasser) · 2021-11-30T18:21:44Z

TypeScript Bot (@typescript-bot) pack this
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2021-11-30T18:21:48Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized community code test suite on this PR at e19aed3. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-11-30T18:21:48Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at e19aed3. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-11-30T18:21:48Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at e19aed3. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-11-30T18:21:48Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at e19aed3. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-11-30T18:21:48Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized Definitely Typed test suite on this PR at e19aed3. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-11-30T18:45:06Z

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/115574/artifacts?artifactName=tgz&fileId=6551FFFB71A718253B428FD346F7C727EDCCF647F8F015F222FC8F831145536A02&fileName=/typescript-4.6.0-insiders.20211130.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.6.0-pr-46951-6".;

Ron Buckton (rbuckton) · 2021-12-01T20:27:56Z

TypeScript Bot (@typescript-bot) perf test

TypeScript Bot (typescript-bot) · 2021-12-01T20:27:58Z

Heya Ron Buckton (@rbuckton), I've started to run the perf test suite on this PR at e19aed3. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2021-12-01T21:06:23Z

Ron Buckton (@rbuckton)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..46951

_Metric	_main	₄₆₉₅₁	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{354,508k (± 0.02%)}	_{354,937k (± 0.03%)}	_{+430k (+ 0.12%)}	_354,674k	_355,142k
_{Parse Time}	_{1.95s (± 0.32%)}	_{1.95s (± 0.42%)}	_{-0.00s (- 0.15%)}	_1.93s	_1.96s
_{Bind Time}	_{0.84s (± 0.89%)}	_{0.84s (± 0.70%)}	_{+0.00s (+ 0.12%)}	_0.83s	_0.86s
_{Check Time}	_{5.47s (± 0.45%)}	_{5.49s (± 0.36%)}	_{+0.02s (+ 0.38%)}	_5.45s	_5.54s
_{Emit Time}	_{5.86s (± 0.33%)}	_{5.89s (± 0.42%)}	_{+0.04s (+ 0.60%)}	_5.85s	_5.96s
_{Total Time}	_{14.12s (± 0.26%)}	_{14.18s (± 0.34%)}	_{+0.06s (+ 0.41%)}	_14.10s	_14.31s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{204,059k (± 0.03%)}	_{204,006k (± 0.02%)}	_{-53k (- 0.03%)}	_203,867k	_204,078k
_{Parse Time}	_{0.78s (± 0.87%)}	_{0.78s (± 0.87%)}	_{0.00s ( 0.00%)}	_0.77s	_0.80s
_{Bind Time}	_{0.52s (± 1.11%)}	_{0.52s (± 1.39%)}	_{+0.00s (+ 0.38%)}	_0.51s	_0.54s
_{Check Time}	_{7.81s (± 0.50%)}	_{7.83s (± 0.65%)}	_{+0.03s (+ 0.37%)}	_7.73s	_7.96s
_{Emit Time}	_{2.46s (± 0.78%)}	_{2.48s (± 0.86%)}	_{+0.03s (+ 1.06%)}	_2.42s	_2.53s
_{Total Time}	_{11.56s (± 0.33%)}	_{11.62s (± 0.54%)}	_{+0.06s (+ 0.48%)}	_11.49s	_11.76s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{342,426k (± 0.02%)}	_{342,435k (± 0.02%)}	_{+9k (+ 0.00%)}	_342,243k	_342,561k
_{Parse Time}	_{1.48s (± 0.44%)}	_{1.48s (± 0.71%)}	_{+0.00s (+ 0.14%)}	_1.46s	_1.51s
_{Bind Time}	_{0.74s (± 0.66%)}	_{0.75s (± 0.82%)}	_{+0.01s (+ 0.67%)}	_0.74s	_0.76s
_{Check Time}	_{5.47s (± 0.70%)}	_{5.49s (± 0.70%)}	_{+0.01s (+ 0.24%)}	_5.43s	_5.59s
_{Emit Time}	_{3.19s (± 0.69%)}	_{3.20s (± 0.79%)}	_{+0.02s (+ 0.47%)}	_3.17s	_3.29s
_{Total Time}	_{10.88s (± 0.22%)}	_{10.91s (± 0.34%)}	_{+0.03s (+ 0.28%)}	_10.85s	_11.00s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{305,439k (± 0.03%)}	_{305,526k (± 0.01%)}	_{+87k (+ 0.03%)}	_305,466k	_305,618k
_{Parse Time}	_{1.20s (± 0.46%)}	_{1.20s (± 0.48%)}	_{-0.00s (- 0.08%)}	_1.18s	_1.21s
_{Bind Time}	_{0.71s (± 0.66%)}	_{0.71s (± 0.73%)}	_{-0.00s (- 0.14%)}	_0.70s	_0.72s
_{Check Time}	_{5.03s (± 0.43%)}	_{5.01s (± 0.38%)}	_{-0.02s (- 0.38%)}	_4.97s	_5.05s
_{Emit Time}	_{3.34s (± 0.93%)}	_{3.34s (± 0.96%)}	_{+0.00s (+ 0.09%)}	_3.28s	_3.43s
_{Total Time}	_{10.28s (± 0.35%)}	_{10.26s (± 0.31%)}	_{-0.02s (- 0.18%)}	_10.22s	_10.35s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{471,310k (± 0.01%)}	_{471,277k (± 0.01%)}	_{-34k (- 0.01%)}	_471,145k	_471,348k
_{Parse Time}	_{1.77s (± 0.40%)}	_{1.78s (± 0.33%)}	_{+0.01s (+ 0.28%)}	_1.76s	_1.79s
_{Bind Time}	_{0.65s (± 0.52%)}	_{0.66s (± 0.79%)}	_{+0.01s (+ 0.92%)}	_0.65s	_0.67s
_{Check Time}	_{14.17s (± 0.38%)}	_{14.18s (± 0.33%)}	_{+0.01s (+ 0.11%)}	_14.10s	_14.35s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.59s (± 0.34%)}	_{16.61s (± 0.29%)}	_{+0.02s (+ 0.13%)}	_16.54s	_16.79s
_{xstate - node (v10.16.3, x64)}
_{Memory used}	_{568,998k (± 0.02%)}	_{569,024k (± 0.01%)}	_{+26k (+ 0.00%)}	_568,795k	_569,146k
_{Parse Time}	_{2.55s (± 0.30%)}	_{2.55s (± 0.29%)}	_{+0.01s (+ 0.24%)}	_2.53s	_2.56s
_{Bind Time}	_{1.00s (± 0.55%)}	_{1.01s (± 0.74%)}	_{+0.01s (+ 0.50%)}	_0.99s	_1.02s
_{Check Time}	_{1.49s (± 0.50%)}	_{1.50s (± 0.39%)}	_{+0.00s (+ 0.27%)}	_1.48s	_1.51s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 3.14%)}	_{+0.00s (+ 1.43%)}	_0.07s	_0.08s
_{Total Time}	_{5.11s (± 0.19%)}	_{5.12s (± 0.24%)}	_{+0.02s (+ 0.35%)}	_5.10s	_5.15s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{332,458k (± 0.02%)}	_{332,812k (± 0.02%)}	_{+354k (+ 0.11%)}	_332,690k	_332,930k
_{Parse Time}	_{1.94s (± 0.56%)}	_{1.94s (± 0.71%)}	_{+0.00s (+ 0.10%)}	_1.90s	_1.96s
_{Bind Time}	_{0.82s (± 0.91%)}	_{0.82s (± 0.60%)}	_{-0.00s (- 0.49%)}	_0.81s	_0.83s
_{Check Time}	_{5.30s (± 0.30%)}	_{5.29s (± 0.29%)}	_{-0.01s (- 0.28%)}	_5.26s	_5.33s
_{Emit Time}	_{6.15s (± 0.96%)}	_{6.12s (± 0.44%)}	_{-0.03s (- 0.41%)}	_6.05s	_6.19s
_{Total Time}	_{14.21s (± 0.47%)}	_{14.17s (± 0.25%)}	_{-0.04s (- 0.30%)}	_14.08s	_14.26s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{191,602k (± 0.03%)}	_{191,564k (± 0.03%)}	_{-38k (- 0.02%)}	_191,465k	_191,687k
_{Parse Time}	_{0.78s (± 0.61%)}	_{0.78s (± 0.77%)}	_{-0.01s (- 0.89%)}	_0.76s	_0.79s
_{Bind Time}	_{0.53s (± 0.89%)}	_{0.53s (± 1.13%)}	_{-0.01s (- 1.31%)}	_0.51s	_0.54s
_{Check Time}	_{7.28s (± 0.39%)}	_{7.29s (± 0.61%)}	_{+0.01s (+ 0.19%)}	_7.20s	_7.39s
_{Emit Time}	_{2.47s (± 0.81%)}	_{2.49s (± 1.11%)}	_{+0.02s (+ 0.61%)}	_2.43s	_2.55s
_{Total Time}	_{11.07s (± 0.38%)}	_{11.08s (± 0.50%)}	_{+0.01s (+ 0.14%)}	_10.95s	_11.19s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{325,493k (± 0.04%)}	_{325,446k (± 0.07%)}	_{-48k (- 0.01%)}	_324,527k	_325,742k
_{Parse Time}	_{1.46s (± 0.72%)}	_{1.47s (± 0.94%)}	_{+0.01s (+ 0.62%)}	_1.44s	_1.50s
_{Bind Time}	_{0.73s (± 0.61%)}	_{0.73s (± 0.76%)}	_{+0.00s (+ 0.00%)}	_0.72s	_0.74s
_{Check Time}	_{5.34s (± 0.48%)}	_{5.36s (± 0.42%)}	_{+0.02s (+ 0.37%)}	_5.32s	_5.42s
_{Emit Time}	_{3.21s (± 0.55%)}	_{3.23s (± 1.04%)}	_{+0.02s (+ 0.65%)}	_3.19s	_3.35s
_{Total Time}	_{10.74s (± 0.36%)}	_{10.79s (± 0.54%)}	_{+0.05s (+ 0.48%)}	_10.71s	_10.99s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{290,301k (± 0.03%)}	_{290,243k (± 0.01%)}	_{-58k (- 0.02%)}	_290,147k	_290,330k
_{Parse Time}	_{1.21s (± 0.48%)}	_{1.21s (± 0.68%)}	_{+0.00s (+ 0.08%)}	_1.20s	_1.23s
_{Bind Time}	_{0.68s (± 0.54%)}	_{0.69s (± 0.84%)}	_{+0.01s (+ 1.17%)}	_0.68s	_0.70s
_{Check Time}	_{4.94s (± 0.47%)}	_{4.95s (± 0.59%)}	_{+0.01s (+ 0.24%)}	_4.87s	_4.99s
_{Emit Time}	_{3.40s (± 1.27%)}	_{3.38s (± 0.70%)}	_{-0.02s (- 0.44%)}	_3.33s	_3.42s
_{Total Time}	_{10.23s (± 0.63%)}	_{10.23s (± 0.38%)}	_{+0.00s (+ 0.04%)}	_10.14s	_10.30s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{450,083k (± 0.02%)}	_{450,067k (± 0.01%)}	_{-17k (- 0.00%)}	_449,958k	_450,220k
_{Parse Time}	_{1.78s (± 0.33%)}	_{1.78s (± 0.42%)}	_{+0.00s (+ 0.06%)}	_1.76s	_1.79s
_{Bind Time}	_{0.64s (± 1.14%)}	_{0.64s (± 0.78%)}	_{-0.00s (- 0.47%)}	_0.63s	_0.65s
_{Check Time}	_{12.69s (± 0.40%)}	_{12.64s (± 0.30%)}	_{-0.04s (- 0.34%)}	_12.55s	_12.74s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.10s (± 0.33%)}	_{15.05s (± 0.28%)}	_{-0.05s (- 0.32%)}	_14.96s	_15.18s
_{xstate - node (v12.1.0, x64)}
_{Memory used}	_{535,055k (± 0.02%)}	_{535,031k (± 0.01%)}	_{-24k (- 0.00%)}	_534,893k	_535,235k
_{Parse Time}	_{2.48s (± 0.47%)}	_{2.48s (± 0.30%)}	_{+0.01s (+ 0.24%)}	_2.47s	_2.50s
_{Bind Time}	_{1.04s (± 0.75%)}	_{1.04s (± 0.74%)}	_{-0.00s (- 0.38%)}	_1.02s	_1.05s
_{Check Time}	_{1.43s (± 0.56%)}	_{1.43s (± 0.71%)}	_{+0.00s (+ 0.21%)}	_1.40s	_1.45s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.02s (± 0.27%)}	_{5.02s (± 0.33%)}	_{+0.00s (+ 0.08%)}	_4.97s	_5.05s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{330,820k (± 0.01%)}	_{331,218k (± 0.01%)}	_{+398k (+ 0.12%)}	_331,154k	_331,278k
_{Parse Time}	_{1.94s (± 0.53%)}	_{1.94s (± 0.48%)}	_{+0.00s (+ 0.15%)}	_1.92s	_1.96s
_{Bind Time}	_{0.86s (± 0.55%)}	_{0.86s (± 0.64%)}	_{+0.00s (+ 0.23%)}	_0.85s	_0.87s
_{Check Time}	_{5.38s (± 0.48%)}	_{5.39s (± 0.64%)}	_{+0.01s (+ 0.24%)}	_5.29s	_5.46s
_{Emit Time}	_{6.15s (± 0.33%)}	_{6.19s (± 0.51%)}	_{+0.05s (+ 0.78%)}	_6.13s	_6.27s
_{Total Time}	_{14.32s (± 0.26%)}	_{14.39s (± 0.35%)}	_{+0.07s (+ 0.50%)}	_14.24s	_14.49s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{192,757k (± 0.49%)}	_{192,044k (± 0.59%)}	_{-713k (- 0.37%)}	_190,169k	_193,486k
_{Parse Time}	_{0.81s (± 1.01%)}	_{0.81s (± 0.87%)}	_{+0.00s (+ 0.25%)}	_0.80s	_0.83s
_{Bind Time}	_{0.55s (± 0.73%)}	_{0.55s (± 0.40%)}	_{0.00s ( 0.00%)}	_0.55s	_0.56s
_{Check Time}	_{7.34s (± 0.34%)}	_{7.35s (± 0.54%)}	_{+0.01s (+ 0.10%)}	_7.27s	_7.47s
_{Emit Time}	_{2.48s (± 0.90%)}	_{2.48s (± 1.55%)}	_{+0.00s (+ 0.12%)}	_2.43s	_2.62s
_{Total Time}	_{11.18s (± 0.30%)}	_{11.19s (± 0.53%)}	_{+0.01s (+ 0.10%)}	_11.11s	_11.36s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{324,294k (± 0.00%)}	_{324,308k (± 0.00%)}	_{+15k (+ 0.00%)}	_324,267k	_324,331k
_{Parse Time}	_{1.50s (± 0.56%)}	_{1.50s (± 0.35%)}	_{0.00s ( 0.00%)}	_1.49s	_1.51s
_{Bind Time}	_{0.76s (± 0.59%)}	_{0.75s (± 0.40%)}	_{-0.01s (- 0.79%)}	_0.75s	_0.76s
_{Check Time}	_{5.29s (± 0.43%)}	_{5.25s (± 0.29%)}	_{-0.04s (- 0.78%)}	_5.22s	_5.28s
_{Emit Time}	_{3.25s (± 0.78%)}	_{3.26s (± 0.78%)}	_{+0.01s (+ 0.31%)}	_3.20s	_3.32s
_{Total Time}	_{10.80s (± 0.35%)}	_{10.76s (± 0.34%)}	_{-0.04s (- 0.33%)}	_10.70s	_10.86s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,141k (± 0.00%)}	_{289,174k (± 0.01%)}	_{+33k (+ 0.01%)}	_289,138k	_289,206k
_{Parse Time}	_{1.22s (± 0.82%)}	_{1.24s (± 1.15%)}	_{+0.01s (+ 0.98%)}	_1.22s	_1.28s
_{Bind Time}	_{0.73s (± 0.55%)}	_{0.73s (± 0.71%)}	_{-0.00s (- 0.00%)}	_0.72s	_0.74s
_{Check Time}	_{4.91s (± 0.33%)}	_{4.90s (± 0.40%)}	_{-0.01s (- 0.24%)}	_4.84s	_4.94s
_{Emit Time}	_{3.51s (± 0.53%)}	_{3.47s (± 1.27%)}	_{-0.04s (- 1.08%)}	_3.31s	_3.55s
_{Total Time}	_{10.38s (± 0.26%)}	_{10.33s (± 0.40%)}	_{-0.04s (- 0.43%)}	_10.20s	_10.39s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{448,276k (± 0.01%)}	_{448,315k (± 0.01%)}	_{+39k (+ 0.01%)}	_448,269k	_448,383k
_{Parse Time}	_{1.82s (± 0.34%)}	_{1.83s (± 0.28%)}	_{+0.01s (+ 0.55%)}	_1.82s	_1.84s
_{Bind Time}	_{0.67s (± 0.54%)}	_{0.68s (± 0.55%)}	_{+0.00s (+ 0.15%)}	_0.67s	_0.68s
_{Check Time}	_{12.77s (± 0.39%)}	_{12.74s (± 0.46%)}	_{-0.02s (- 0.19%)}	_12.59s	_12.87s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.26s (± 0.33%)}	_{15.25s (± 0.39%)}	_{-0.01s (- 0.10%)}	_15.08s	_15.37s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{532,756k (± 0.01%)}	_{532,817k (± 0.01%)}	_{+62k (+ 0.01%)}	_532,769k	_532,888k
_{Parse Time}	_{2.55s (± 0.63%)}	_{2.56s (± 0.61%)}	_{+0.00s (+ 0.04%)}	_2.52s	_2.60s
_{Bind Time}	_{1.15s (± 1.10%)}	_{1.15s (± 0.67%)}	_{0.00s ( 0.00%)}	_1.13s	_1.16s
_{Check Time}	_{1.48s (± 0.52%)}	_{1.48s (± 0.57%)}	_{+0.00s (+ 0.27%)}	_1.46s	_1.50s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.25s (± 0.50%)}	_{5.25s (± 0.49%)}	_{+0.00s (+ 0.08%)}	_5.20s	_5.33s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{10 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v10.16.3, x64)
xstate - node (v12.1.0, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₆₉₅₁	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

Ron Buckton (rbuckton) · 2021-12-01T23:05:33Z

TypeScript Bot (@typescript-bot) user test this

TypeScript Bot (typescript-bot) · 2021-12-01T23:05:34Z

Heya Ron Buckton (@rbuckton), I've started to run the parallelized community code test suite on this PR at e19aed3. You can monitor the build here.

Ron Buckton (rbuckton) · 2021-12-02T19:06:28Z

TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this

TypeScript Bot (typescript-bot) · 2021-12-02T19:06:31Z

Heya Ron Buckton (@rbuckton), I've started to run the parallelized community code test suite on this PR at f4b3ef2. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-12-02T19:06:31Z

Heya Ron Buckton (@rbuckton), I've started to run the extended test suite on this PR at f4b3ef2. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-12-02T19:06:31Z

Heya Ron Buckton (@rbuckton), I've started to run the parallelized Definitely Typed test suite on this PR at f4b3ef2. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-12-02T19:49:16Z

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

Andrew Branch (andrewbranch) · 2021-12-07T21:40:39Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-4.5

TypeScript Bot (typescript-bot) · 2021-12-07T21:40:44Z

Heya Andrew Branch (@andrewbranch), I've started to run the task to cherry-pick this into release-4.5 on this PR at f4b3ef2. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2021-12-07T21:46:49Z

Hey Andrew Branch (@andrewbranch), I've opened #47058 for you.

Component commits: e19aed3 Fix Awaited<T> for onfulfilled callbacks with more than one argument f4b3ef2 Merge branch 'main' into fix46934

Component commits: e19aed3 Fix Awaited<T> for onfulfilled callbacks with more than one argument f4b3ef2 Merge branch 'main' into fix46934 Co-authored-by: Ron Buckton <rbuckton@microsoft.com>

Daniel Rosenwasser (DanielRosenwasser) · 2021-12-07T23:20:00Z

Made this 4.5-bound.

…icrosoft#46951)

Fix Awaited<T> for onfulfilled callbacks with more than one argument

e19aed3

Ron Buckton (rbuckton) requested review from Nathan Shively-Sanders (sandersn) and Wesley Wigham (weswigham) November 30, 2021 05:48

TypeScript Bot (typescript-bot) assigned Ron Buckton (rbuckton) Nov 30, 2021

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 30, 2021

Wesley Wigham (weswigham) approved these changes Dec 2, 2021

View reviewed changes

Merge branch 'main' into fix46934

f4b3ef2

TypeScript Bot (typescript-bot) mentioned this pull request Dec 2, 2021

🤖 User test baselines have changed for fix46934 typescript-bot/TypeScript#213

Open

TypeScript Bot (typescript-bot) mentioned this pull request Dec 7, 2021

🤖 Pick PR #46951 (Fix Awaited<T> for onfulfilled call...) into release-4.5 #47058

Merged

Daniel Rosenwasser (DanielRosenwasser) merged commit 67f84ef into main Dec 7, 2021

Daniel Rosenwasser (DanielRosenwasser) deleted the fix46934 branch December 7, 2021 23:21

sync-by-unito Bot mentioned this pull request Jan 1, 2022

build(deps-dev): bump typescript from 4.3.5 to 4.5.4 numbersprotocol/capture-cam#1150

Closed

Martin Probst (mprobst) pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022

Fix Awaited<T> for onfulfilled callbacks with more than one argument (m…

a7d1800

…icrosoft#46951)

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025

Uh oh!

Conversation

Ron Buckton (rbuckton) commented Nov 30, 2021

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Nov 30, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ron Buckton (rbuckton) commented Dec 1, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 1, 2021

Uh oh!

Ron Buckton (rbuckton) commented Dec 1, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ron Buckton (rbuckton) commented Dec 2, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 2, 2021

Uh oh!

Andrew Branch (andrewbranch) commented Dec 7, 2021

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Dec 7, 2021

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Dec 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TypeScript Bot (typescript-bot) commented Nov 30, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Nov 30, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Nov 30, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Nov 30, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Nov 30, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Nov 30, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 1, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 1, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 2, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 2, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 2, 2021 •

edited

Loading

TypeScript Bot (typescript-bot) commented Dec 7, 2021 •

edited

Loading