Skip to content

Close package json watches in watch mode on close - #45642

Merged
Wesley Wigham (weswigham) merged 1 commit into
microsoft:mainfrom
weswigham:watch-close-package-json-watches
Aug 30, 2021
Merged

Close package json watches in watch mode on close#45642
Wesley Wigham (weswigham) merged 1 commit into
microsoft:mainfrom
weswigham:watch-close-package-json-watches

Conversation

@weswigham

Copy link
Copy Markdown
Member

Fixes #45633

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@weswigham
Wesley Wigham (weswigham) merged commit f598076 into microsoft:main Aug 30, 2021
@weswigham

Copy link
Copy Markdown
Member Author

Andrew Branch (@andrewbranch) want this picked into the 4.4 branch?

@andrewbranch

Copy link
Copy Markdown
Member

Yes please

@weswigham

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) cherrypick this into release-4.4

@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the task to cherry-pick this into release-4.4 on this PR at 58e56ed. You can monitor the build here.

@typescript-bot

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), I've opened #45644 for you.

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 30, 2021
Component commits:
58e56ed Close package json watches in watch mode on close
Andrew Branch (andrewbranch) pushed a commit that referenced this pull request Aug 30, 2021
Component commits:
58e56ed Close package json watches in watch mode on close

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
@sunshineplan

Copy link
Copy Markdown

Wesley Wigham (@weswigham) Any plan for a new release?

Nicole Oliveira (nicoleoliveira) added a commit to animaliads/animalia-web-components that referenced this pull request Sep 3, 2021
Tem uma issue no typescript porque está travando o build.
microsoft/TypeScript#45642
rollup/rollup#4213
@andrewbranch

Copy link
Copy Markdown
Member

There will be a patch probably within the next week or two.

Brad Jorsch (anomiex) added a commit to Automattic/jetpack that referenced this pull request Sep 7, 2021
Denis Badurina (enisdenjo) added a commit to enisdenjo/graphql-ws that referenced this pull request Sep 8, 2021
Denis Badurina (enisdenjo) added a commit to enisdenjo/graphql-ws that referenced this pull request Sep 8, 2021
Denis Badurina (enisdenjo) added a commit to enisdenjo/graphql-sse that referenced this pull request Sep 8, 2021
Nicole Oliveira (nicoleoliveira) added a commit to animaliads/animalia-web-components that referenced this pull request Sep 10, 2021
* Novo componente 

* feat: correção da versão do typescript

Tem uma issue no typescript porque está travando o build.
microsoft/TypeScript#45642
rollup/rollup#4213
Paul Pillot (ppillot) added a commit to ppillot/biomsalign that referenced this pull request Jan 1, 2024
This was due to an issue with the typescript version, see microsoft/TypeScript#45642
TS related packages have been upgraded
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript 4.4 leaks watchers

4 participants