Fix verify.baselineCompletions used in fourslash tests - #45615
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit intoAug 30, 2021
Merged
Fix verify.baselineCompletions used in fourslash tests#45615Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
verify.baselineCompletions used in fourslash tests#45615Daniel Rosenwasser (DanielRosenwasser) merged 1 commit into
Conversation
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
TypeScript Bot (typescript-bot)
added
the
For Uncommitted Bug
Contributor
Author
|
Nathan Shively-Sanders (@sandersn) Please review this code. |
Member
|
Thanks! |
Kenta Moriuchi (petamoriken)
deleted the
fix/fourslash-baseline-completions
branch
August 30, 2021 07:49
Cassandra Choi (BobobUnicorn)
pushed a commit
to BobobUnicorn/TypeScript
that referenced
this pull request
Oct 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #43709
I found while working on #43710 that the
verify.baselineCompletionsused in the fourslash tests were not working properly. This pull request is to fix it.#43710 (comment)