Repository navigation
Consider module augmentations in files referenced by imports in watch/incremental - #45156
Merged
Andrew Branch (andrewbranch) merged 5 commits intoJul 23, 2021
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
| * Get the referencedFile from the imported module symbol | ||
| */ | ||
| function getReferencedFileFromImportedModuleSymbol(symbol: Symbol) { | ||
| if (symbol.declarations && symbol.declarations[0]) { |
Member
Author
There was a problem hiding this comment.
It was literally just taking the first declaration and ignoring all others 🤷
Andrew Casey (amcasey)
approved these changes
Jul 22, 2021
Andrew Casey (amcasey)
left a comment
Andrew Casey (amcasey)
left a comment
Member
There was a problem hiding this comment.
Makes sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44094