Indirect calls for imported functions - #44624
Merged
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Contributor
Author
|
TypeScript Bot (@typescript-bot) perf test |
Contributor
|
Heya Ron Buckton (@rbuckton), I've started to run the perf test suite on this PR at f0a7f99. You can monitor the build here. Update: The results are in! |
Contributor
|
Ron Buckton (@rbuckton) Here they are:Comparison Report - main..44624
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Ron Buckton (rbuckton)
marked this pull request as ready for review
June 18, 2021 20:38
Ron Buckton (rbuckton)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Wesley Wigham (weswigham)
June 18, 2021 20:39
Ryan Cavanaugh (RyanCavanaugh)
requested changes
Jun 18, 2021
Ryan Cavanaugh (RyanCavanaugh)
left a comment
Ryan Cavanaugh (RyanCavanaugh)
left a comment
Member
There was a problem hiding this comment.
Other stuff looks fine but let's not include package-lock.json as part of this (if we want to do that at all)
Contributor
Author
|
package-lock existing is surprising. I thought we had an .npmrc that disabled package-lock. |
Ron Buckton (rbuckton)
force-pushed
the
indirectlyCallImportedFunctions
branch
2 times, most recently
from
June 18, 2021 23:23
f9f719a to
143e4a1
Compare
Ron Buckton (rbuckton)
force-pushed
the
indirectlyCallImportedFunctions
branch
from
June 18, 2021 23:33
143e4a1 to
4e056d3
Compare
Contributor
Author
|
I guess we started generating a |
Contributor
Author
|
package-lock.json has been reverted. Ryan Cavanaugh (@RyanCavanaugh): any other concerns or should I merge? |
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Jun 21, 2021
Kristiyan Kostadinov (crisbeto)
added a commit
to crisbeto/angular
that referenced
this pull request
Sep 22, 2021
Adds support for TypeScript 4.4. High-level overview of the changes made in this PR: * Bumps the various packages to `typescript@4.4.2` and `tslib@2.3.0`. * The `useUnknownInCatchVariables` compiler option has been disabled so that we don't have to cast error objects explicitly everywhere. * TS now passes in a third argument to the `__spreadArray` call inside child class constructors. I had to update a couple of places in the runtime and ngcc to be able to pick up the calls correctly. * TS now generates code like `(0, foo)(arg1, arg2)` for imported function calls. I had to update a few of our tests to account for it. See microsoft/TypeScript#44624. * Our `ngtsc` test setup calls the private `matchFiles` function from TS. I had to update our usage, because a new parameter was added. * There was one place where we were setting the readonly `hasTrailingComma` property. I updated the usage to pass in the value when constructing the object instead. * Some browser types were updated which meant that I had to resolve some trivial type errors. * The downlevel decorators tranform was running into an issue where the Closure synthetic comments were being emitted twice. I've worked around it by recreating the class declaration node instead of cloning it.
Alex Rickabaugh (alxhub)
pushed a commit
to angular/angular
that referenced
this pull request
Sep 23, 2021
Adds support for TypeScript 4.4. High-level overview of the changes made in this PR: * Bumps the various packages to `typescript@4.4.2` and `tslib@2.3.0`. * The `useUnknownInCatchVariables` compiler option has been disabled so that we don't have to cast error objects explicitly everywhere. * TS now passes in a third argument to the `__spreadArray` call inside child class constructors. I had to update a couple of places in the runtime and ngcc to be able to pick up the calls correctly. * TS now generates code like `(0, foo)(arg1, arg2)` for imported function calls. I had to update a few of our tests to account for it. See microsoft/TypeScript#44624. * Our `ngtsc` test setup calls the private `matchFiles` function from TS. I had to update our usage, because a new parameter was added. * There was one place where we were setting the readonly `hasTrailingComma` property. I updated the usage to pass in the value when constructing the object instead. * Some browser types were updated which meant that I had to resolve some trivial type errors. * The downlevel decorators tranform was running into an issue where the Closure synthetic comments were being emitted twice. I've worked around it by recreating the class declaration node instead of cloning it. PR Close #43281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt to address indirect calls for imported functions.
Fixes #35420