Correct path segment regex - #44149
Merged
Merged
Conversation
The old version incorrectly matched anything with a leading or trailing slash. The empty segment should only be detected between two slashes.
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Andrew Casey (amcasey)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
May 19, 2021 16:53
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version incorrectly matched anything with a leading or trailing slash. The empty segment should only be detected between two slashes. This made it much less likely that we'd take the fast path, especially on *nix.