Node factory should insert override modifier between static and astnc - #43699
Merged
Wesley Wigham (weswigham) merged 1 commit intoApr 16, 2021
Merged
Conversation
Wesley Wigham (weswigham)
requested review from
Wenlu Wang (Kingwl) and
Andrew Branch (andrewbranch)
April 15, 2021 23:49
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Andrew Branch (andrewbranch)
approved these changes
Apr 16, 2021
Andrew Branch (andrewbranch)
left a comment
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
Ah thank you, great catch 🌟
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking over #43660 and realized that while it added an error, it didn't adjust our function for serializing modifier flags,
createModifiersFromModifierFlagsto respect the new order.createModifiersFromModifierFlags's listed order is implicitly our modifier flag priority order right now, at least for output. In this case, you'd probably only notice the difference in a TS -> TS transform orchestrated by our compiler where the node-with-modifiers is edited (sinceoverrideis a TS only modifier).