Do not erase signatures in getSignatureOfTypeTag - #43688
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoApr 15, 2021
Merged
Conversation
I don't see a reason for it, and it doesn't cause any tests to fail.
Member
Author
|
TypeScript Bot (@typescript-bot) user test this |
Nathan Shively-Sanders (sandersn)
requested review from
Anders Hejlsberg (ahejlsberg) and
Wesley Wigham (weswigham)
April 15, 2021 16:20
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Contributor
|
Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized community code test suite on this PR at 04613a6. You can monitor the build here. |
Wesley Wigham (weswigham)
approved these changes
Apr 15, 2021
Contributor
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Member
Author
|
User tests are clean. |
Nathan Shively-Sanders (sandersn)
deleted the
no-erasure-of-type-tag-signatures
branch
April 15, 2021 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #26236, but with no tests.
Fixes #42060