fix(43535): TypeScript preserves 'override' modifier in JavaScript output - #43536
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit intoApr 6, 2021
Merged
Conversation
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Apr 5, 2021
Wenlu Wang (Kingwl)
approved these changes
Apr 6, 2021
Contributor
|
Thanks! |
Merged
| } | ||
|
|
||
| class B extends A { | ||
| override m1() { |
There was a problem hiding this comment.
🤦♂️
Contributor
Author
There was a problem hiding this comment.
Wenlu Wang (@Kingwl) Daniel Rosenwasser (@DanielRosenwasser) Could you clarify this case? //// [override12.js] does not contain override keywords.
Contributor
There was a problem hiding this comment.
But if useDefineForClassFields is on....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43535