If there are no open files, do not schedule ensureProjectForOpenFiles - #41537
Merged
Conversation
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
Sheetal Nandi (sheetalkamat)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Andrew Casey (amcasey)
November 14, 2020 00:57
Sheetal Nandi (sheetalkamat)
force-pushed
the
ensureOpenProjects
branch
from
November 18, 2020 23:41
832f130 to
784bd0f
Compare
Andrew Casey (amcasey)
approved these changes
Nov 18, 2020
Andrew Casey (amcasey)
left a comment
Andrew Casey (amcasey)
left a comment
Member
There was a problem hiding this comment.
The checkTimeoutQueueLengthAndRun change looks unrelated. Otherwise, LGTM.
Member
Author
This shows that we are not scheduling ensuring project for open files when there are no open files. In all those test cases there are no open files. Just external projects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on #39656