Reverts #39277 removing bundledPackageName

[Orta Therox (orta)]

Re: #39277 - note that there is #41510 which instead turns this into a suggestion instead of a compiler error.

It's looking like we don't want to ship 4.1 with bundledPackageName included as-is, this PR reverts those changes and tests.

[Wesley Wigham (weswigham)]

Orta Therox (@orta) rather than reverting the whole thing, why not just remove the new error on program construction if the break is too undesirable... (or, better yet, convert it to a suggestion diagnostic somehow rather than removing it outright)? The flag definitely allows you to get better declaration file output.

[Orta Therox (orta)]

Yeah, I'm totally open to this instead. Does that work for you Daniel Rosenwasser (@DanielRosenwasser) / Ryan Cavanaugh (@RyanCavanaugh)?

Will take a fresh stab at that tomorrow 👍🏻

[Orta Therox (orta)]

I'll make a PR to release-4.1 cherry-picking either this PR or #41510 when one is merged

[Daniel Rosenwasser (DanielRosenwasser)]

Even if we want to keep the feature, I'm not sold on the name and there isn't much time to bikeshed that.

TypeScript Bot (@typescript-bot) cherry-pick this to release-4.1

[TypeScript Bot (typescript-bot)]

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-4.1 on this PR at 0c00853. You can monitor the build here.

[TypeScript Bot (typescript-bot)]

Hey Daniel Rosenwasser (@DanielRosenwasser), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.1 manually.

[Wesley Wigham (weswigham)]

Even if we want to keep the feature, I'm not sold on the name and there isn't much time to bikeshed that.

Whoa, we've had the flag shipped in the whole beta process - we've already bikeshedded the name. Removing just the error is way less disruptive than stripping the whole feature, and lower risk to the release as a whole.

[Nathan Shively-Sanders (sandersn)]

Orta Therox (@orta) Since #41510 is less disruptive, do you want to keep this PR around?

[Orta Therox (orta)]

When this came up in a design meeting, the consensus was still to remove this option, but I'd like to give it one last discussion before dropping completely.

[Orta Therox (orta)]

OK, dropping this flag from 4.2 also.

[menduz]

Oh no! Decentraland was really relying on this feature.

Help me with the planning for our tooling: is this completely removed from the plans or it is a temporary thing?

Thanks

[Wesley Wigham (weswigham)]

We have plans to bring it back, but with a different name, and without the error requiring its use - some contention was had that the name bundledPackageName potentially implied that we were some kind of full service bundler, rather than a relatively dumb concatenator.

[Alexander Rose (arose)]

We have plans to bring it back, but with a different name, and without the error requiring its us

Any update on this?