Fix crash on attempting to suggest a ts import for a synthetic js resolution - #41467
Merged
Wesley Wigham (weswigham) merged 3 commits intoNov 11, 2020
Merged
Conversation
Wesley Wigham (weswigham)
requested review from
Nathan Shively-Sanders (sandersn) and
Sheetal Nandi (sheetalkamat)
November 9, 2020 22:05
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Nathan Shively-Sanders (sandersn)
approved these changes
Nov 10, 2020
Comment on lines
+1094
to
+1095
| if (location.pos < 0 || location.end < 0) { | ||
| // Psuedo-synthesized input node |
There was a problem hiding this comment.
Suggested change
| if (location.pos < 0 || location.end < 0) { | |
| // Psuedo-synthesized input node | |
| // Pseudo-synthesized input node | |
| if (location.pos < 0 || location.end < 0) { |
Sheetal Nandi (sheetalkamat)
approved these changes
Nov 11, 2020
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this into release-4.1 |
Contributor
|
Heya Wesley Wigham (@weswigham), I've started to run the task to cherry-pick this into |
Contributor
|
Hey Wesley Wigham (@weswigham), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.1 manually. |
Wesley Wigham (weswigham)
added a commit
that referenced
this pull request
Nov 11, 2020
Port #41467 to `release-4.1`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41410
After looking at it a bit, I realized we were checking if
ignoreErrorswas set, but were unconditionally making a diagnostic because we wanted to try and offer a suggestion (namely, a suggestion to try to install types for it when the js seems to be present, but not any types). I simply changed our suggestion-or-error adding function to more gracefully handle the psuedo-synthetic nodes we use for some compiler-option-added imports. Now that I know how it works, I can say it was theoretically possible to trigger the same issue withimportHelpers, but you'd have needed to have atslibon disk with no accompanying types, which is obviously not what we distribute (therefore very unlikely to occur).