Properly reduce intersections of string literal and template literal types - #41162
Merged
Conversation
Anders Hejlsberg (ahejlsberg)
requested a review
from Wesley Wigham (weswigham)
October 19, 2020 15:47
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Wesley Wigham (weswigham)
approved these changes
Oct 19, 2020
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
Hm, this is fine, but the reduce operation has the potential to be very expensive on large input sets. Are we sure there's not a way re can rejigger how we read the cache to keep the operation cached (even when the final result is never)?
Member
Author
|
Wesley Wigham (@weswigham) I think it's going to be quite rare to have large intersection input sets that contain both string literal types and template literal types so I'm not too worried about it. I think the common pattern here will be intersecting a large union of string literal types with a template literal type, but that'll normalize to a large union of little intersections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41161.