fix(40640) add missing notApplicableReason in protocol - #40680
Conversation
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Andrew Casey (@amcasey), Matt Bierner (@mjbvz), Mine Starks (@minestarks) for you. Feel free to loop in other consumers/maintainers if necessary |
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
|
Is there a protocol baseline that needs to be updated? |
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-4.0 |
* update protocol * fix lint error
|
For annoying reasons, the bot doesn't cherry-pick merged PRs |
|
but... I've seen it do it... |
|
Same! I have no idea how anything works. Maybe Wesley Wigham (@weswigham) knows. |
|
Github GC's the ref if you take too long (and deleted the source branch), and once the ref is gone, it can't be picked anymore. That's about the only thing I can think of. |
|
So I guess try not to delete the source branch immediately in the future and give that a shot - thanks Wesley Wigham (@weswigham)! |
|
|
|
Maybe it's a difficulty across repos too. |
|
That's usually fine... it looks like the pipeline never even triggered, so it seems like the comment didn't even get picked up. Lemme try... TypeScript Bot (@typescript-bot) cherrypick this into release-4.0 |
|
Heya Wesley Wigham (@weswigham), I've started to run the task to cherry-pick this into |
|
🤷 github dropped the webhook, maybe? I dunno. Definitely triggered for me, and the accompanying logs seem fine, too (though maybe I should update the code for the latest octokit - there's some deprecation warnings). |
|
Hey Wesley Wigham (@weswigham), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually. |
5 participants
Fixes #40640
protocol changes were missed in #37871
We will need to cherry pick this to
release-4.0