fix(31046): more accurate error message when derived class has different constructor signature - #40073
Merged
Daniel Rosenwasser (DanielRosenwasser) merged 1 commit intoAug 22, 2020
Conversation
TypeScript Bot (typescript-bot)
added
the
For Backlog Bug
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/31046
branch
from
August 16, 2020 12:18
9ad640f to
886079b
Compare
Daniel Rosenwasser (DanielRosenwasser)
requested changes
Aug 19, 2020
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/31046
branch
from
August 19, 2020 07:37
886079b to
22d94fd
Compare
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
August 19, 2020 07:41
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/31046
branch
from
August 21, 2020 07:51
22d94fd to
23fe54a
Compare
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
August 21, 2020 08:33
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/31046
branch
from
August 22, 2020 05:12
23fe54a to
d709265
Compare
Oleksandr Tarasiuk (a-tarasyuk)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
August 22, 2020 05:15
Member
|
Definitely looks like an improvement to me! |
TypeScript Bot (typescript-bot)
added
the
For Milestone Bug
Wenlu Wang (Kingwl)
pushed a commit
to Kingwl/TypeScript
that referenced
this pull request
Aug 24, 2020
Wenlu Wang (Kingwl)
pushed a commit
to Kingwl/TypeScript
that referenced
this pull request
Aug 24, 2020
Nathan Shively-Sanders (sandersn)
pushed a commit
that referenced
this pull request
Sep 9, 2020
* Add see tag parser * add baseline * fix symbol resolve * add more case * fix unittests * improve tests and parser * accept baseline * Adopt package-lock.json and npm ci * Add a workflow to update package-lock.json daily * Git ignore package-lock.json and forcibly update in workflow * Update bot email address * Delete extra npm update * Update package-lock.json * Add compactDisplay and signDisplay to NumberFormatOptions (#40039) * Fix typo in (Readonly)Set.keys comment (fixes #40164) (#40176) * fix(26325): use a unique name for reserved words in 'constructor like' function name (#39684) * fix(25770): add diagnostic message for the possible mapped type used as an index (#39973) * fix(31046): add new diagnostic message for incompatible constructor signature (#40073) * Update package-lock.json * Update package-lock.json * Add rename support * Accpet baseline * wip * fix anders * Revert "fix anders" This reverts commit b3178d4. * Fix call hierarchy item serialization and server tests (#40348) * Avoid error * accept baseline * Add more tests * Add signature name resolve Co-authored-by: Andrew Casey <andrew.casey@microsoft.com> Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com> Co-authored-by: Neil Kistner <neil.kistner@gmail.com> Co-authored-by: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com> Co-authored-by: Alexander T <alexander.tarasyuk@outlook.com> Co-authored-by: Erich Gamma <egamma@microsoft.com> Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31046
Fixes #21253