Improve inference for Promise.all of 'never[]' - #39336
Improve inference for Promise.all of 'never[]'#39336Ron Buckton (rbuckton) wants to merge 2 commits into
Conversation
|
Makes sense to me, but should we run user tests? TypeScript Bot (@typescript-bot) user test this |
|
Heya Andrew Branch (@andrewbranch), I've started to run the parallelized community code test suite on this PR at eb27d3e. You can monitor the build here. |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
There’s one relevant change: https://github.com/typescript-bot/TypeScript/pull/54/files#diff-ce8b151b649148d02935b814380073d7 |
|
Yeah, looking at this a little bit more, there really isn't a way to craft the overload list to get the correct result here. |
|
Actually, I may have found a solution. I'll try that first before giving up on this line of thought... |
|
TypeScript Bot (@typescript-bot) test this |
|
Heya Ron Buckton (@rbuckton), I've started to run the parallelized community code test suite on this PR at b486b5e. You can monitor the build here. |
|
Heya Ron Buckton (@rbuckton), I've started to run the extended test suite on this PR at b486b5e. You can monitor the build here. |
|
Even this doesn't work because it collides with For reference: |
|
I'm switching this to a draft PR for the time being while I consider other alternatives. |
4 participants
This adds overloads to
Promise.allto improve treat aPromise.allfor an array of typenever[]as aPromise<never>rather than aPromise<never[]>.Fixes #37856