Include reexported names in list of exported names - #38809
Conversation
Wenlu Wang (Kingwl)
left a comment
There was a problem hiding this comment.
I‘m not sure what happend... but LGTM...
|
Ping Ron Buckton (@rbuckton) ❤️ |
| } | ||
| } | ||
|
|
||
| for (const externalImport of moduleInfo.externalImports) { |
There was a problem hiding this comment.
I didn't see any tests affected that use SystemJS, so I'm not sure what effect (if any) this change made. Is it handled by the change in utilities.ts, or are we missing test cases?
There was a problem hiding this comment.
This removed code duplicated the reexports preservation for systemjs. In effect, for systemjs only, we were tracking reexports in a second list. So, rather than duplicating the systemjs code into all the other module systems, I removed code from the systemjs resolver and let it rely on the single list having the reexports in it (since every module mode needs them now).
Ron Buckton (rbuckton)
left a comment
There was a problem hiding this comment.
Looks good, assuming we have adequate coverage for system modules, per my other comment.
|
Ryan Cavanaugh (@RyanCavanaugh) should we backport this change to 3.9? |
|
Yes please 🙏😅 |
|
Wesley Wigham (@weswigham) I think you may have missed a test baseline. PR builds are currently failing: It looks like the diff is due to this change. |
|
Semantic merge conflicts shakes fist |
Fixes #38530