Skip to content

Skip default when initially iterating exports in __importStar, same as __exportStar - #38808

Merged
Wesley Wigham (weswigham) merged 2 commits into
microsoft:masterfrom
weswigham:importstar-fixes
Jun 1, 2020
Merged

Skip default when initially iterating exports in __importStar, same as __exportStar#38808
Wesley Wigham (weswigham) merged 2 commits into
microsoft:masterfrom
weswigham:importstar-fixes

Conversation

@weswigham

@weswigham Wesley Wigham (weswigham) commented May 27, 2020

Copy link
Copy Markdown
Member

Fixes #38540

@weswigham Wesley Wigham (weswigham) mentioned this pull request May 27, 2020
Merged
@weswigham

Wesley Wigham (weswigham) commented May 27, 2020

Copy link
Copy Markdown
Member Author

Ryan Cavanaugh (@RyanCavanaugh) will we want to backport this to the 3.9 servicing release?

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented May 27, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) pack this
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.9

@typescript-bot

TypeScript Bot (typescript-bot) commented May 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at 1da7d7a. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented May 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-3.9 on this PR at 1da7d7a. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented May 27, 2020

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #38811 for you.

Merged
TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request May 27, 2020
@weswigham @typescript-bot
Cherry-pick PR microsoft#38808 into release-3.9
c34b39b 
Component commits:
2906ce4 Skip default when iterating exports in __importStar, same as __exportStar

1da7d7a Accept baselines
Merged
@typescript-bot

TypeScript Bot (typescript-bot) commented May 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/75073/artifacts?artifactName=tgz&fileId=6C00FE3605AD1F9E537C858359588BAD1248C4EF90BBFF217AA57949BBD75F0F02&fileName=/typescript-4.0.0-insiders.20200527.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

Closed
Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request May 28, 2020
@DanielRosenwasser
Merge pull request #38811 from typescript-bot/pick/38808/release-3.9
28ea935 
🤖 Pick PR #38808 (Skip default when initially iterati...) into release-3.9
@weswigham
Wesley Wigham (weswigham) merged commit b36b803 into microsoft:master Jun 1, 2020
AllenLee (cangSDARM) added a commit to cangSDARM/TypeScript that referenced this pull request Jun 2, 2020
@cangSDARM
Merge remote-tracking branch 'upstream/master'
59a3320 
* upstream/master: (78 commits)
  LEGO: check in for master to temporary branch.
  Skip default when initially iterating exports in __importStar, same as __exportStar (microsoft#38808)
  fix line endings
  Improve error range for ts2657 (jsx expr must have parent element), add code fix for it (microsoft#37917)
  fix(32341): add prefix name for module exports properties (microsoft#38541)
  fix(19385): add space after brace in the multiline string template (microsoft#38742)
  fix(38815): dive in arrow functions to check only this usage instead of checking all statements (microsoft#38865)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Convert HTML tags in doc-comments into markdown
  fix linting error
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  fix(38722): change error message for use-before-declaration on const enum (microsoft#38728)
  ...
This was referenced Jul 7, 2020
Closed
Closed
@rbuckton Ron Buckton (rbuckton) mentioned this pull request Jan 7, 2021
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat approved these changes
@rbuckton Ron Buckton (rbuckton) Awaiting requested review from rbuckton
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh

Assignees

@weswigham Wesley Wigham (weswigham)

Labels

Author: Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Runtime error with *esModuleInterop* when CJS module has an export named "default"

4 participants

@weswigham @DanielRosenwasser @typescript-bot @sheetalkamat