Introduces new flag for optimization hints - #38602
Closed
Ryan Delaney (rrdelaney) wants to merge 2 commits into
Closed
Introduces new flag for optimization hints#38602Ryan Delaney (rrdelaney) wants to merge 2 commits into
Ryan Delaney (rrdelaney) wants to merge 2 commits into
Conversation
|
|
Ryan Delaney (rrdelaney)
force-pushed
the
add-optimization-hints
branch
from
May 18, 2020 20:46
2369289 to
5f83ffe
Compare
Ryan Delaney (rrdelaney)
force-pushed
the
add-optimization-hints
branch
from
May 18, 2020 20:46
5f83ffe to
e1a1dad
Compare
Ryan Delaney (rrdelaney)
force-pushed
the
add-optimization-hints
branch
from
May 18, 2020 21:10
e1a1dad to
cef1fcd
Compare
Nathan Shively-Sanders (sandersn)
added
For Uncommitted Bug
Author
|
Closing this out, please see #38374 (comment) for our write up. Thanks for taking the time to look at this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38374
This is an implementation of the
addOptimizationHintscompiler flag suggested in #38374. The intent of this feature is to allow must users to receive the benefits of the/** @class */and IIFE wrapper introduced by #32011, while being able to opt-out if needed. In our case, opting out is helpful because we have an optimization toolchain that attempts to understand and decompose classes rather than treating them as an opaque value.This is based on PR #38566 to include that bug fix.
As far as the name goes, I am not tied to
addOptimizationHintsat all, it's just an example. I am very open to changing the name, description, and default value for this compiler option. Also if I missed some places new compiler options need to be introduced or documented please point them out 😄