Skip to content

Fix crash caused by assertion with evolving array type - #38398

Merged
Anders Hejlsberg (ahejlsberg) merged 2 commits into
masterfrom
fix38369
May 7, 2020
Merged

Fix crash caused by assertion with evolving array type#38398
Anders Hejlsberg (ahejlsberg) merged 2 commits into
masterfrom
fix38369

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented May 7, 2020

Copy link
Copy Markdown
Member

Fixes #38369.

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented May 7, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.9

@typescript-bot

TypeScript Bot (typescript-bot) commented May 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized Definitely Typed test suite on this PR at b355cd4. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented May 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at b355cd4. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented May 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized community code test suite on this PR at b355cd4. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented May 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-3.9 on this PR at b355cd4. You can monitor the build here.

Merged
@typescript-bot

TypeScript Bot (typescript-bot) commented May 7, 2020

Copy link
Copy Markdown
Contributor

Hey Daniel Rosenwasser (@DanielRosenwasser), I've opened #38400 for you.

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request May 7, 2020
@ahejlsberg @typescript-bot
Cherry-pick PR microsoft#38398 into release-3.9
7d5b207 
Component commits:
99c5c09 Properly finalize evolving array type in getTypeAtFlowCall

b355cd4 Add regression test
Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request May 8, 2020
TypeScript Bot @ahejlsberg
Cherry-pick PR #38398 into release-3.9 (#38400)
d906a47 
Component commits:
99c5c09 Properly finalize evolving array type in getTypeAtFlowCall

b355cd4 Add regression test

Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
AllenLee (cangSDARM) added a commit to cangSDARM/TypeScript that referenced this pull request May 12, 2020
@cangSDARM
Merge remote-tracking branch 'upstream/master'
2e7319b 
* upstream/master: (54 commits)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Fix for jsdoc modifiers on constructor params (microsoft#38403)
  Improve assert message in binder (microsoft#38270)
  fix broken regex on "src/services/completions.ts#getCompletionData" (microsoft#37546)
  report error for duplicate @type declaration (microsoft#38340)
  fix(38073): hide 'Extract to function in global scope' action for arrow functions which use 'this' (microsoft#38107)
  Update user baselines (microsoft#38472)
  Update user baselines (microsoft#38405)
  Changed template strings to emit void 0 instead of undefined (microsoft#38430)
  Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit (microsoft#38368)
  LEGO: check in for master to temporary branch.
  Make isDynamicFileName available publicly (microsoft#38269)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Exclude arrays and tuples from full intersection property check (microsoft#38395)
  Fix crash caused by assertion with evolving array type (microsoft#38398)
  Update user baselines (microsoft#38128)
  LEGO: check in for master to temporary branch.
  moveToNewFile: handle namespace imports too
  ...

# Conflicts:
#	src/compiler/types.ts
#	src/compiler/utilities.ts
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
@weswigham Wesley Wigham (weswigham) weswigham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Checker crash in isWeakType

4 participants

@ahejlsberg @DanielRosenwasser @typescript-bot @weswigham