Properly handle private/protected members in unions of object types by ahejlsberg · Pull Request #38277 · microsoft/TypeScript

Anders Hejlsberg (ahejlsberg) · 2020-04-30T20:15:06Z

Daniel Rosenwasser (DanielRosenwasser) · 2020-04-30T20:19:44Z

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2020-04-30T20:19:47Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at 0f76e2f. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2020-04-30T20:19:47Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized community code test suite on this PR at 0f76e2f. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2020-04-30T20:19:47Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at 0f76e2f. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2020-04-30T20:49:14Z

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

TypeScript Bot (typescript-bot) · 2020-04-30T20:55:48Z

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..38277

_Metric	_master	₃₈₂₇₇	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{328,163k (± 0.02%)}	_{327,601k (± 0.03%)}	_{-562k (- 0.17%)}	_327,338k	_327,846k
_{Parse Time}	_{1.64s (± 0.41%)}	_{1.64s (± 0.57%)}	_{-0.00s (- 0.12%)}	_1.62s	_1.66s
_{Bind Time}	_{0.90s (± 0.54%)}	_{0.90s (± 0.86%)}	_{-0.00s (- 0.33%)}	_0.89s	_0.92s
_{Check Time}	_{4.81s (± 0.47%)}	_{4.81s (± 0.69%)}	_{+0.00s (+ 0.08%)}	_4.73s	_4.87s
_{Emit Time}	_{5.40s (± 0.77%)}	_{5.40s (± 0.49%)}	_{-0.01s (- 0.13%)}	_5.34s	_5.46s
_{Total Time}	_{12.75s (± 0.26%)}	_{12.74s (± 0.43%)}	_{-0.01s (- 0.05%)}	_12.64s	_12.88s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{327,203k (± 0.02%)}	_{327,195k (± 0.02%)}	_{-8k (- 0.00%)}	_327,045k	_327,312k
_{Parse Time}	_{1.27s (± 0.45%)}	_{1.26s (± 0.38%)}	_{-0.01s (- 0.55%)}	_1.25s	_1.27s
_{Bind Time}	_{0.78s (± 0.57%)}	_{0.78s (± 0.51%)}	_{-0.00s (- 0.13%)}	_0.77s	_0.79s
_{Check Time}	_{4.79s (± 0.41%)}	_{4.80s (± 0.35%)}	_{+0.00s (+ 0.10%)}	_4.75s	_4.83s
_{Emit Time}	_{2.94s (± 0.86%)}	_{2.94s (± 0.87%)}	_{+0.00s (+ 0.03%)}	_2.88s	_2.98s
_{Total Time}	_{9.78s (± 0.33%)}	_{9.78s (± 0.38%)}	_{+0.00s (+ 0.01%)}	_9.67s	_9.86s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{292,255k (± 0.02%)}	_{292,256k (± 0.02%)}	_{+1k (+ 0.00%)}	_292,140k	_292,382k
_{Parse Time}	_{0.96s (± 0.49%)}	_{0.96s (± 0.62%)}	_{+0.00s (+ 0.42%)}	_0.95s	_0.98s
_{Bind Time}	_{0.75s (± 0.80%)}	_{0.75s (± 1.10%)}	_{+0.01s (+ 1.07%)}	_0.73s	_0.77s
_{Check Time}	_{4.36s (± 0.44%)}	_{4.34s (± 0.32%)}	_{-0.03s (- 0.57%)}	_4.30s	_4.36s
_{Emit Time}	_{3.10s (± 0.73%)}	_{3.10s (± 1.07%)}	_{0.00s ( 0.00%)}	_3.05s	_3.18s
_{Total Time}	_{9.17s (± 0.31%)}	_{9.15s (± 0.49%)}	_{-0.02s (- 0.16%)}	_9.06s	_9.25s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{449,315k (± 0.01%)}	_{449,052k (± 0.02%)}	_{-263k (- 0.06%)}	_448,823k	_449,186k
_{Parse Time}	_{1.78s (± 0.37%)}	_{1.78s (± 0.51%)}	_{-0.00s (- 0.06%)}	_1.76s	_1.80s
_{Bind Time}	_{0.70s (± 0.88%)}	_{0.70s (± 0.88%)}	_{0.00s ( 0.00%)}	_0.69s	_0.71s
_{Check Time}	_{12.58s (± 0.70%)}	_{12.54s (± 0.86%)}	_{-0.03s (- 0.25%)}	_12.34s	_12.91s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.06s (± 0.59%)}	_{15.03s (± 0.77%)}	_{-0.03s (- 0.22%)}	_14.82s	_15.41s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{303,637k (± 0.02%)}	_{303,175k (± 0.02%)}	_{-461k (- 0.15%)}	_303,019k	_303,308k
_{Parse Time}	_{1.59s (± 0.46%)}	_{1.59s (± 0.60%)}	_{-0.00s (- 0.13%)}	_1.56s	_1.60s
_{Bind Time}	_{0.89s (± 1.13%)}	_{0.88s (± 0.51%)}	_{-0.01s (- 1.34%)}	_0.87s	_0.89s
_{Check Time}	_{4.71s (± 0.37%)}	_{4.69s (± 0.36%)}	_{-0.02s (- 0.45%)}	_4.65s	_4.73s
_{Emit Time}	_{5.54s (± 0.54%)}	_{5.55s (± 0.97%)}	_{+0.01s (+ 0.18%)}	_5.47s	_5.73s
_{Total Time}	_{12.73s (± 0.33%)}	_{12.70s (± 0.49%)}	_{-0.03s (- 0.20%)}	_12.58s	_12.86s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{307,238k (± 0.02%)}	_{307,182k (± 0.02%)}	_{-55k (- 0.02%)}	_307,078k	_307,316k
_{Parse Time}	_{1.23s (± 0.57%)}	_{1.21s (± 0.62%)}	_{-0.02s (- 1.22%)}	_1.20s	_1.23s
_{Bind Time}	_{0.75s (± 0.99%)}	_{0.76s (± 0.79%)}	_{+0.00s (+ 0.27%)}	_0.74s	_0.77s
_{Check Time}	_{4.63s (± 0.54%)}	_{4.62s (± 0.37%)}	_{-0.01s (- 0.22%)}	_4.58s	_4.65s
_{Emit Time}	_{2.99s (± 0.62%)}	_{3.00s (± 0.89%)}	_{+0.01s (+ 0.30%)}	_2.97s	_3.08s
_{Total Time}	_{9.61s (± 0.37%)}	_{9.59s (± 0.41%)}	_{-0.02s (- 0.16%)}	_9.53s	_9.69s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{274,560k (± 0.02%)}	_{274,612k (± 0.02%)}	_{+52k (+ 0.02%)}	_274,498k	_274,829k
_{Parse Time}	_{0.93s (± 0.60%)}	_{0.93s (± 0.56%)}	_{-0.00s (- 0.11%)}	_0.92s	_0.94s
_{Bind Time}	_{0.72s (± 1.32%)}	_{0.73s (± 0.92%)}	_{+0.00s (+ 0.28%)}	_0.71s	_0.74s
_{Check Time}	_{4.24s (± 0.34%)}	_{4.25s (± 0.48%)}	_{+0.00s (+ 0.12%)}	_4.19s	_4.28s
_{Emit Time}	_{3.12s (± 1.54%)}	_{3.15s (± 1.62%)}	_{+0.03s (+ 1.12%)}	_3.07s	_3.31s
_{Total Time}	_{9.02s (± 0.54%)}	_{9.06s (± 0.50%)}	_{+0.04s (+ 0.44%)}	_8.98s	_9.16s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{426,721k (± 0.02%)}	_{426,464k (± 0.02%)}	_{-257k (- 0.06%)}	_426,239k	_426,570k
_{Parse Time}	_{1.76s (± 0.42%)}	_{1.75s (± 0.57%)}	_{-0.01s (- 0.51%)}	_1.73s	_1.78s
_{Bind Time}	_{0.64s (± 0.76%)}	_{0.65s (± 1.17%)}	_{+0.00s (+ 0.31%)}	_0.63s	_0.67s
_{Check Time}	_{11.11s (± 0.48%)}	_{11.16s (± 0.31%)}	_{+0.06s (+ 0.52%)}	_11.11s	_11.28s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{13.51s (± 0.44%)}	_{13.56s (± 0.23%)}	_{+0.05s (+ 0.35%)}	_13.51s	_13.66s
_{Angular - node (v8.9.0, x64)}
_{Memory used}	_{323,093k (± 0.01%)}	_{322,604k (± 0.01%)}	_{-489k (- 0.15%)}	_322,558k	_322,682k
_{Parse Time}	_{2.13s (± 0.46%)}	_{2.13s (± 0.64%)}	_{-0.00s (- 0.05%)}	_2.10s	_2.17s
_{Bind Time}	_{0.94s (± 0.87%)}	_{0.94s (± 0.81%)}	_{-0.00s (- 0.43%)}	_0.92s	_0.96s
_{Check Time}	_{5.36s (± 1.84%)}	_{5.43s (± 1.79%)}	_{+0.07s (+ 1.29%)}	_5.26s	_5.59s
_{Emit Time}	_{6.35s (± 1.65%)}	_{6.35s (± 0.89%)}	_{-0.01s (- 0.11%)}	_6.24s	_6.50s
_{Total Time}	_{14.78s (± 0.75%)}	_{14.84s (± 0.48%)}	_{+0.06s (+ 0.39%)}	_14.72s	_15.04s
_{Monaco - node (v8.9.0, x64)}
_{Memory used}	_{325,821k (± 0.01%)}	_{325,821k (± 0.01%)}	_{-0k (- 0.00%)}	_325,709k	_325,944k
_{Parse Time}	_{1.56s (± 0.49%)}	_{1.55s (± 0.57%)}	_{-0.00s (- 0.19%)}	_1.54s	_1.58s
_{Bind Time}	_{0.92s (± 1.48%)}	_{0.92s (± 2.03%)}	_{-0.00s (- 0.22%)}	_0.89s	_0.98s
_{Check Time}	_{5.41s (± 0.38%)}	_{5.44s (± 0.64%)}	_{+0.03s (+ 0.48%)}	_5.37s	_5.54s
_{Emit Time}	_{3.50s (± 0.42%)}	_{3.53s (± 0.64%)}	_{+0.03s (+ 0.77%)}	_3.46s	_3.58s
_{Total Time}	_{11.38s (± 0.21%)}	_{11.43s (± 0.38%)}	_{+0.05s (+ 0.44%)}	_11.34s	_11.54s
_{TFS - node (v8.9.0, x64)}
_{Memory used}	_{291,839k (± 0.01%)}	_{291,826k (± 0.01%)}	_{-13k (- 0.00%)}	_291,722k	_291,903k
_{Parse Time}	_{1.27s (± 0.41%)}	_{1.26s (± 0.62%)}	_{-0.01s (- 0.79%)}	_1.25s	_1.28s
_{Bind Time}	_{0.76s (± 0.53%)}	_{0.76s (± 1.00%)}	_{-0.00s (- 0.40%)}	_0.74s	_0.77s
_{Check Time}	_{5.05s (± 1.61%)}	_{5.03s (± 2.01%)}	_{-0.03s (- 0.51%)}	_4.87s	_5.23s
_{Emit Time}	_{3.24s (± 2.38%)}	_{3.25s (± 2.81%)}	_{+0.01s (+ 0.28%)}	_3.08s	_3.47s
_{Total Time}	_{10.32s (± 0.29%)}	_{10.29s (± 0.50%)}	_{-0.03s (- 0.27%)}	_10.19s	_10.41s
_{material-ui - node (v8.9.0, x64)}
_{Memory used}	_{452,273k (± 0.03%)}	_{451,886k (± 0.02%)}	_{-387k (- 0.09%)}	_451,744k	_452,070k
_{Parse Time}	_{2.13s (± 0.52%)}	_{2.12s (± 0.63%)}	_{-0.00s (- 0.14%)}	_2.09s	_2.15s
_{Bind Time}	_{0.83s (± 0.90%)}	_{0.82s (± 0.89%)}	_{-0.01s (- 1.32%)}	_0.81s	_0.84s
_{Check Time}	_{16.79s (± 0.79%)}	_{16.72s (± 1.28%)}	_{-0.07s (- 0.39%)}	_16.38s	_17.25s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{19.75s (± 0.70%)}	_{19.67s (± 1.08%)}	_{-0.08s (- 0.39%)}	_19.34s	_20.22s
_{Angular - node (v8.9.0, x86)}
_{Memory used}	_{186,084k (± 0.02%)}	_{185,819k (± 0.04%)}	_{-265k (- 0.14%)}	_185,687k	_185,965k
_{Parse Time}	_{2.06s (± 0.68%)}	_{2.07s (± 0.85%)}	_{+0.01s (+ 0.34%)}	_2.04s	_2.12s
_{Bind Time}	_{1.08s (± 0.48%)}	_{1.09s (± 0.96%)}	_{+0.01s (+ 0.83%)}	_1.07s	_1.11s
_{Check Time}	_{5.01s (± 0.51%)}	_{5.06s (± 0.94%)}	_{+0.04s (+ 0.88%)}	_4.97s	_5.19s
_{Emit Time}	_{6.10s (± 1.27%)}	_{6.13s (± 0.58%)}	_{+0.03s (+ 0.44%)}	_6.06s	_6.22s
_{Total Time}	_{14.26s (± 0.50%)}	_{14.34s (± 0.62%)}	_{+0.09s (+ 0.60%)}	_14.16s	_14.63s
_{Monaco - node (v8.9.0, x86)}
_{Memory used}	_{185,620k (± 0.03%)}	_{185,597k (± 0.01%)}	_{-23k (- 0.01%)}	_185,553k	_185,645k
_{Parse Time}	_{1.60s (± 0.66%)}	_{1.61s (± 1.18%)}	_{+0.01s (+ 0.75%)}	_1.58s	_1.68s
_{Bind Time}	_{0.78s (± 1.07%)}	_{0.77s (± 0.80%)}	_{-0.00s (- 0.64%)}	_0.76s	_0.78s
_{Check Time}	_{5.42s (± 0.33%)}	_{5.45s (± 0.46%)}	_{+0.03s (+ 0.59%)}	_5.40s	_5.50s
_{Emit Time}	_{2.89s (± 0.63%)}	_{2.89s (± 0.80%)}	_{+0.01s (+ 0.21%)}	_2.85s	_2.96s
_{Total Time}	_{10.68s (± 0.21%)}	_{10.73s (± 0.56%)}	_{+0.04s (+ 0.40%)}	_10.63s	_10.89s
_{TFS - node (v8.9.0, x86)}
_{Memory used}	_{167,157k (± 0.03%)}	_{167,145k (± 0.02%)}	_{-12k (- 0.01%)}	_167,068k	_167,198k
_{Parse Time}	_{1.29s (± 0.53%)}	_{1.30s (± 0.80%)}	_{+0.00s (+ 0.31%)}	_1.28s	_1.32s
_{Bind Time}	_{0.72s (± 1.06%)}	_{0.72s (± 0.77%)}	_{+0.00s (+ 0.28%)}	_0.71s	_0.73s
_{Check Time}	_{4.66s (± 0.48%)}	_{4.67s (± 0.48%)}	_{+0.01s (+ 0.26%)}	_4.63s	_4.74s
_{Emit Time}	_{3.02s (± 3.03%)}	_{2.99s (± 2.27%)}	_{-0.04s (- 1.16%)}	_2.88s	_3.24s
_{Total Time}	_{9.69s (± 1.00%)}	_{9.68s (± 0.67%)}	_{-0.02s (- 0.20%)}	_9.53s	_9.89s
_{material-ui - node (v8.9.0, x86)}
_{Memory used}	_{256,107k (± 0.01%)}	_{255,979k (± 0.01%)}	_{-128k (- 0.05%)}	_255,886k	_256,029k
_{Parse Time}	_{2.18s (± 0.44%)}	_{2.19s (± 0.72%)}	_{+0.00s (+ 0.18%)}	_2.17s	_2.24s
_{Bind Time}	_{0.70s (± 1.20%)}	_{0.69s (± 1.08%)}	_{-0.01s (- 1.14%)}	_0.68s	_0.71s
_{Check Time}	_{15.31s (± 0.76%)}	_{15.28s (± 0.66%)}	_{-0.03s (- 0.22%)}	_15.07s	_15.47s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{18.20s (± 0.68%)}	_{18.16s (± 0.52%)}	_{-0.04s (- 0.19%)}	_17.97s	_18.34s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-166-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v8.9.0, x64)
material-ui - node (v8.9.0, x86)

_Benchmark	_Name	_Iterations
_Current	₃₈₂₇₇	₁₀
_Baseline	_master	₁₀

Daniel Rosenwasser (DanielRosenwasser) · 2020-05-04T22:37:14Z

TypeScript Bot (@typescript-bot) cherry-pick this to release-3.9

TypeScript Bot (typescript-bot) · 2020-05-04T22:37:16Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the task to cherry-pick this into release-3.9 on this PR at 806cf90. You can monitor the build here.

TypeScript Bot (typescript-bot) · 2020-05-04T22:41:36Z

Hey Daniel Rosenwasser (@DanielRosenwasser), I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.9 manually.

Daniel Rosenwasser (DanielRosenwasser) · 2020-05-04T22:58:10Z

Anders Hejlsberg (@ahejlsberg) I guess we shouldn't pull in before cherry-picking, the bot doesn't seem to like that. Wesley Wigham (@weswigham) any way to fix this that isn't manual?

Daniel Rosenwasser (DanielRosenwasser) · 2020-05-04T23:06:06Z

Ugh, it was a merge conflict...

Wesley Wigham (weswigham) · 2020-05-04T23:07:16Z

Pulling in berfore cherry-picking is usually fine so long as the branch wasn't deleted (and then restored) in the meantime, as I think Github removes the merge reference when the branch is deleted (and has no reason to restore it alongside the branch, as the "new branch" has no active PR).

…38277) * Property handle private/protected properties in unions of object types * Add regression test

…38277) (#38334) * Property handle private/protected properties in unions of object types * Add regression test Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>

Anders Hejlsberg (ahejlsberg) added 2 commits April 30, 2020 13:04

Property handle private/protected properties in unions of object types

0c6404b

Add regression test

0f76e2f

Anders Hejlsberg (ahejlsberg) requested a review from Daniel Rosenwasser (DanielRosenwasser) April 30, 2020 20:15

TypeScript Bot (typescript-bot) mentioned this pull request Apr 30, 2020

🤖 User test baselines have changed for fix38236 typescript-bot/TypeScript#28

Open

Merge branch 'master' into fix38236

806cf90

Nathan Shively-Sanders (sandersn) approved these changes May 4, 2020

View reviewed changes

Anders Hejlsberg (ahejlsberg) merged commit e6390ef into master May 4, 2020

Anders Hejlsberg (ahejlsberg) deleted the fix38236 branch May 4, 2020 22:28

Daniel Rosenwasser (DanielRosenwasser) restored the fix38236 branch May 4, 2020 22:37

Daniel Rosenwasser (DanielRosenwasser) deleted the fix38236 branch May 4, 2020 22:58

Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request May 4, 2020

Properly handle private/protected members in unions of object types (#…

f4d69b9

…38277) * Property handle private/protected properties in unions of object types * Add regression test

Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request May 4, 2020

[Cherry-pick] Properly handle private/protected members in unions of object types (… #38334

Merged

Jake Bailey (jakebailey) mentioned this pull request Jul 6, 2023

Inheritance and type narrowing prevent private member access in base class. #11454

Closed

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025

Navigation Menu

Uh oh!

Properly handle private/protected members in unions of object types - #38277

Properly handle private/protected members in unions of object types#38277
Anders Hejlsberg (ahejlsberg) merged 3 commits into
masterfrom
fix38236

Anders Hejlsberg (ahejlsberg) commented Apr 30, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Apr 30, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 4, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented May 4, 2020 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented May 4, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 4, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 4, 2020

Uh oh!

Wesley Wigham (weswigham) commented May 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Anders Hejlsberg (ahejlsberg) commented Apr 30, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Apr 30, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Apr 30, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 4, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented May 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented May 4, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 4, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented May 4, 2020

Uh oh!

Wesley Wigham (weswigham) commented May 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TypeScript Bot (typescript-bot) commented Apr 30, 2020 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 30, 2020 •

edited

Loading

TypeScript Bot (typescript-bot) commented Apr 30, 2020 •

edited

Loading

TypeScript Bot (typescript-bot) commented May 4, 2020 •

edited

Loading