Skip to content

Generic functions are never context sensitive - #37811

Merged
Anders Hejlsberg (ahejlsberg) merged 2 commits into
masterfrom
fix37110
Apr 6, 2020
Merged

Generic functions are never context sensitive#37811
Anders Hejlsberg (ahejlsberg) merged 2 commits into
masterfrom
fix37110

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Apr 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This PR fixes an issue introduced by #36476 where a generic function would be considered context sensitive even though it never should be (and never was before that PR).

Fixes #37110.

@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Apr 6, 2020

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 2cb8b25. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 2cb8b25. You can monitor the build here.

@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized community code test suite on this PR at 2cb8b25. You can monitor the build here.

Open
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Apr 6, 2020

Copy link
Copy Markdown
Member Author

Ryan Cavanaugh (@RyanCavanaugh) All tests are clean. Want to take a quick look?

@ahejlsberg Anders Hejlsberg (ahejlsberg) mentioned this pull request Apr 17, 2020
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham approved these changes
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh

Assignees

@ahejlsberg Anders Hejlsberg (ahejlsberg)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generic gets lost in 3.8.2

3 participants

@ahejlsberg @typescript-bot @weswigham